You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/03 21:50:22 UTC

[GitHub] [superset] eschutho commented on a change in pull request #12923: fix: added text and changed margins

eschutho commented on a change in pull request #12923:
URL: https://github.com/apache/superset/pull/12923#discussion_r569774522



##########
File path: superset-frontend/stylesheets/less/cosmo/variables.less
##########
@@ -220,7 +220,7 @@
 );
 
 // ** `.form-group` margin
-@form-group-margin-bottom: 16px;
+@form-group-margin-bottom: 8px;

Review comment:
       we're going to be removing the .less styling, and also so that we don't change things too globally, you can add some styling for this selector with the emotion styles in `DatasourceEditor.jsx` under `const DatasourceContainer = styled.div`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org