You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Konstantin Shvachko (JIRA)" <ji...@apache.org> on 2012/05/25 08:26:24 UTC

[jira] [Created] (HDFS-3462) TestDFSClientRetries.busyTest() should restore default xceiver count in the config.

Konstantin Shvachko created HDFS-3462:
-----------------------------------------

             Summary: TestDFSClientRetries.busyTest() should restore default xceiver count in the config.
                 Key: HDFS-3462
                 URL: https://issues.apache.org/jira/browse/HDFS-3462
             Project: Hadoop HDFS
          Issue Type: Bug
          Components: test
    Affects Versions: 3.0.0
            Reporter: Konstantin Shvachko


TestDFSClientRetries.busyTest() sets maximum xceiver count in the config to a small value, but does not restore it back to the default. As the result subsequent tests can fail, especially on slower or busy machines.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3462) TestDFSClientRetries.busyTest() should restore default xceiver count in the config.

Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285488#comment-13285488 ] 

Konstantin Shvachko commented on HDFS-3462:
-------------------------------------------

+    int originalXcievers = conf.getInt(DFSConfigKeys.DFS_DATANODE_MAX_RECEIVER_THREADS_KEY,0);

should use DFS_DATANODE_MAX_RECEIVER_THREADS_DEFAULT rather than 0.
                
> TestDFSClientRetries.busyTest() should restore default xceiver count in the config.
> -----------------------------------------------------------------------------------
>
>                 Key: HDFS-3462
>                 URL: https://issues.apache.org/jira/browse/HDFS-3462
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 3.0.0
>            Reporter: Konstantin Shvachko
>             Fix For: 3.0.0
>
>         Attachments: HDFS-3462.patch, testGetFileChecksum.log.htm
>
>
> TestDFSClientRetries.busyTest() sets maximum xceiver count in the config to a small value, but does not restore it back to the default. As the result subsequent tests can fail, especially on slower or busy machines.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HDFS-3462) TestDFSClientRetries.busyTest() should restore default xceiver count in the config.

Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-3462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Shvachko updated HDFS-3462:
--------------------------------------

    Attachment: testGetFileChecksum.log.htm

Attaching log from Jenkins build for HDFS-3368 with failed testGetFileChecksum().
Suggested fix is to restore the default value for max xceiver count after all busyTest() are done.
                
> TestDFSClientRetries.busyTest() should restore default xceiver count in the config.
> -----------------------------------------------------------------------------------
>
>                 Key: HDFS-3462
>                 URL: https://issues.apache.org/jira/browse/HDFS-3462
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 3.0.0
>            Reporter: Konstantin Shvachko
>         Attachments: testGetFileChecksum.log.htm
>
>
> TestDFSClientRetries.busyTest() sets maximum xceiver count in the config to a small value, but does not restore it back to the default. As the result subsequent tests can fail, especially on slower or busy machines.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3462) TestDFSClientRetries.busyTest() should restore default xceiver count in the config.

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286583#comment-13286583 ] 

Hudson commented on HDFS-3462:
------------------------------

Integrated in Hadoop-Mapreduce-trunk #1096 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1096/])
    HDFS-3476. Correct the default used in TestDFSClientRetries.busyTest() after HDFS-3462. (harsh) (Revision 1344394)

     Result = SUCCESS
harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1344394
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSClientRetries.java

                
> TestDFSClientRetries.busyTest() should restore default xceiver count in the config.
> -----------------------------------------------------------------------------------
>
>                 Key: HDFS-3462
>                 URL: https://issues.apache.org/jira/browse/HDFS-3462
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 3.0.0
>            Reporter: Konstantin Shvachko
>             Fix For: 3.0.0
>
>         Attachments: HDFS-3462.patch, testGetFileChecksum.log.htm
>
>
> TestDFSClientRetries.busyTest() sets maximum xceiver count in the config to a small value, but does not restore it back to the default. As the result subsequent tests can fail, especially on slower or busy machines.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3462) TestDFSClientRetries.busyTest() should restore default xceiver count in the config.

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285995#comment-13285995 ] 

Hudson commented on HDFS-3462:
------------------------------

Integrated in Hadoop-Mapreduce-trunk-Commit #2320 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2320/])
    HDFS-3476. Correct the default used in TestDFSClientRetries.busyTest() after HDFS-3462. (harsh) (Revision 1344394)

     Result = FAILURE
harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1344394
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSClientRetries.java

                
> TestDFSClientRetries.busyTest() should restore default xceiver count in the config.
> -----------------------------------------------------------------------------------
>
>                 Key: HDFS-3462
>                 URL: https://issues.apache.org/jira/browse/HDFS-3462
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 3.0.0
>            Reporter: Konstantin Shvachko
>             Fix For: 3.0.0
>
>         Attachments: HDFS-3462.patch, testGetFileChecksum.log.htm
>
>
> TestDFSClientRetries.busyTest() sets maximum xceiver count in the config to a small value, but does not restore it back to the default. As the result subsequent tests can fail, especially on slower or busy machines.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3462) TestDFSClientRetries.busyTest() should restore default xceiver count in the config.

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13284916#comment-13284916 ] 

Hudson commented on HDFS-3462:
------------------------------

Integrated in Hadoop-Hdfs-trunk-Commit #2369 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2369/])
    HDFS-3462. TestDFSClientRetries.busyTest() should restore default xceiver count in the config. Contributed by Madhukara Phatak. (harsh) (Revision 1343798)

     Result = SUCCESS
harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1343798
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSClientRetries.java

                
> TestDFSClientRetries.busyTest() should restore default xceiver count in the config.
> -----------------------------------------------------------------------------------
>
>                 Key: HDFS-3462
>                 URL: https://issues.apache.org/jira/browse/HDFS-3462
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 3.0.0
>            Reporter: Konstantin Shvachko
>             Fix For: 3.0.0
>
>         Attachments: HDFS-3462.patch, testGetFileChecksum.log.htm
>
>
> TestDFSClientRetries.busyTest() sets maximum xceiver count in the config to a small value, but does not restore it back to the default. As the result subsequent tests can fail, especially on slower or busy machines.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3462) TestDFSClientRetries.busyTest() should restore default xceiver count in the config.

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285676#comment-13285676 ] 

Hudson commented on HDFS-3462:
------------------------------

Integrated in Hadoop-Mapreduce-trunk #1095 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1095/])
    HDFS-3462. TestDFSClientRetries.busyTest() should restore default xceiver count in the config. Contributed by Madhukara Phatak. (harsh) (Revision 1343798)

     Result = SUCCESS
harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1343798
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSClientRetries.java

                
> TestDFSClientRetries.busyTest() should restore default xceiver count in the config.
> -----------------------------------------------------------------------------------
>
>                 Key: HDFS-3462
>                 URL: https://issues.apache.org/jira/browse/HDFS-3462
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 3.0.0
>            Reporter: Konstantin Shvachko
>             Fix For: 3.0.0
>
>         Attachments: HDFS-3462.patch, testGetFileChecksum.log.htm
>
>
> TestDFSClientRetries.busyTest() sets maximum xceiver count in the config to a small value, but does not restore it back to the default. As the result subsequent tests can fail, especially on slower or busy machines.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3462) TestDFSClientRetries.busyTest() should restore default xceiver count in the config.

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285898#comment-13285898 ] 

Hudson commented on HDFS-3462:
------------------------------

Integrated in Hadoop-Hdfs-trunk-Commit #2374 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2374/])
    HDFS-3476. Correct the default used in TestDFSClientRetries.busyTest() after HDFS-3462. (harsh) (Revision 1344394)

     Result = SUCCESS
harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1344394
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSClientRetries.java

                
> TestDFSClientRetries.busyTest() should restore default xceiver count in the config.
> -----------------------------------------------------------------------------------
>
>                 Key: HDFS-3462
>                 URL: https://issues.apache.org/jira/browse/HDFS-3462
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 3.0.0
>            Reporter: Konstantin Shvachko
>             Fix For: 3.0.0
>
>         Attachments: HDFS-3462.patch, testGetFileChecksum.log.htm
>
>
> TestDFSClientRetries.busyTest() sets maximum xceiver count in the config to a small value, but does not restore it back to the default. As the result subsequent tests can fail, especially on slower or busy machines.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3462) TestDFSClientRetries.busyTest() should restore default xceiver count in the config.

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285594#comment-13285594 ] 

Hudson commented on HDFS-3462:
------------------------------

Integrated in Hadoop-Hdfs-trunk #1061 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1061/])
    HDFS-3462. TestDFSClientRetries.busyTest() should restore default xceiver count in the config. Contributed by Madhukara Phatak. (harsh) (Revision 1343798)

     Result = SUCCESS
harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1343798
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSClientRetries.java

                
> TestDFSClientRetries.busyTest() should restore default xceiver count in the config.
> -----------------------------------------------------------------------------------
>
>                 Key: HDFS-3462
>                 URL: https://issues.apache.org/jira/browse/HDFS-3462
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 3.0.0
>            Reporter: Konstantin Shvachko
>             Fix For: 3.0.0
>
>         Attachments: HDFS-3462.patch, testGetFileChecksum.log.htm
>
>
> TestDFSClientRetries.busyTest() sets maximum xceiver count in the config to a small value, but does not restore it back to the default. As the result subsequent tests can fail, especially on slower or busy machines.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3462) TestDFSClientRetries.busyTest() should restore default xceiver count in the config.

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13284795#comment-13284795 ] 

Hadoop QA commented on HDFS-3462:
---------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12529680/HDFS-3462.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 1 new or modified test files.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2530//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2530//console

This message is automatically generated.
                
> TestDFSClientRetries.busyTest() should restore default xceiver count in the config.
> -----------------------------------------------------------------------------------
>
>                 Key: HDFS-3462
>                 URL: https://issues.apache.org/jira/browse/HDFS-3462
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 3.0.0
>            Reporter: Konstantin Shvachko
>         Attachments: HDFS-3462.patch, testGetFileChecksum.log.htm
>
>
> TestDFSClientRetries.busyTest() sets maximum xceiver count in the config to a small value, but does not restore it back to the default. As the result subsequent tests can fail, especially on slower or busy machines.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HDFS-3462) TestDFSClientRetries.busyTest() should restore default xceiver count in the config.

Posted by "Harsh J (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-3462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Harsh J updated HDFS-3462:
--------------------------

    Hadoop Flags: Reviewed
          Status: Patch Available  (was: Open)

+1 pending Jenkins. Thanks!
                
> TestDFSClientRetries.busyTest() should restore default xceiver count in the config.
> -----------------------------------------------------------------------------------
>
>                 Key: HDFS-3462
>                 URL: https://issues.apache.org/jira/browse/HDFS-3462
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 3.0.0
>            Reporter: Konstantin Shvachko
>         Attachments: HDFS-3462.patch, testGetFileChecksum.log.htm
>
>
> TestDFSClientRetries.busyTest() sets maximum xceiver count in the config to a small value, but does not restore it back to the default. As the result subsequent tests can fail, especially on slower or busy machines.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HDFS-3462) TestDFSClientRetries.busyTest() should restore default xceiver count in the config.

Posted by "Harsh J (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-3462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Harsh J updated HDFS-3462:
--------------------------

          Resolution: Fixed
       Fix Version/s: 3.0.0
    Target Version/s:   (was: 3.0.0)
              Status: Resolved  (was: Patch Available)

Committed to trunk. Thanks for your continued contributions Madhukara!
                
> TestDFSClientRetries.busyTest() should restore default xceiver count in the config.
> -----------------------------------------------------------------------------------
>
>                 Key: HDFS-3462
>                 URL: https://issues.apache.org/jira/browse/HDFS-3462
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 3.0.0
>            Reporter: Konstantin Shvachko
>             Fix For: 3.0.0
>
>         Attachments: HDFS-3462.patch, testGetFileChecksum.log.htm
>
>
> TestDFSClientRetries.busyTest() sets maximum xceiver count in the config to a small value, but does not restore it back to the default. As the result subsequent tests can fail, especially on slower or busy machines.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3462) TestDFSClientRetries.busyTest() should restore default xceiver count in the config.

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13284909#comment-13284909 ] 

Hudson commented on HDFS-3462:
------------------------------

Integrated in Hadoop-Common-trunk-Commit #2296 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2296/])
    HDFS-3462. TestDFSClientRetries.busyTest() should restore default xceiver count in the config. Contributed by Madhukara Phatak. (harsh) (Revision 1343798)

     Result = SUCCESS
harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1343798
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSClientRetries.java

                
> TestDFSClientRetries.busyTest() should restore default xceiver count in the config.
> -----------------------------------------------------------------------------------
>
>                 Key: HDFS-3462
>                 URL: https://issues.apache.org/jira/browse/HDFS-3462
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 3.0.0
>            Reporter: Konstantin Shvachko
>             Fix For: 3.0.0
>
>         Attachments: HDFS-3462.patch, testGetFileChecksum.log.htm
>
>
> TestDFSClientRetries.busyTest() sets maximum xceiver count in the config to a small value, but does not restore it back to the default. As the result subsequent tests can fail, especially on slower or busy machines.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3462) TestDFSClientRetries.busyTest() should restore default xceiver count in the config.

Posted by "Harsh J (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285613#comment-13285613 ] 

Harsh J commented on HDFS-3462:
-------------------------------

Konstantin, I thought it to be fine for that test case but I see now what it could cause if there were no defaults. I've filed HDFS-3476 for addressing this. Sorry about this!
                
> TestDFSClientRetries.busyTest() should restore default xceiver count in the config.
> -----------------------------------------------------------------------------------
>
>                 Key: HDFS-3462
>                 URL: https://issues.apache.org/jira/browse/HDFS-3462
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 3.0.0
>            Reporter: Konstantin Shvachko
>             Fix For: 3.0.0
>
>         Attachments: HDFS-3462.patch, testGetFileChecksum.log.htm
>
>
> TestDFSClientRetries.busyTest() sets maximum xceiver count in the config to a small value, but does not restore it back to the default. As the result subsequent tests can fail, especially on slower or busy machines.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HDFS-3462) TestDFSClientRetries.busyTest() should restore default xceiver count in the config.

Posted by "madhukara phatak (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-3462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

madhukara phatak updated HDFS-3462:
-----------------------------------

    Attachment: HDFS-3462.patch

Fixed busyTest method to restore the original value of xceivers.
                
> TestDFSClientRetries.busyTest() should restore default xceiver count in the config.
> -----------------------------------------------------------------------------------
>
>                 Key: HDFS-3462
>                 URL: https://issues.apache.org/jira/browse/HDFS-3462
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 3.0.0
>            Reporter: Konstantin Shvachko
>         Attachments: HDFS-3462.patch, testGetFileChecksum.log.htm
>
>
> TestDFSClientRetries.busyTest() sets maximum xceiver count in the config to a small value, but does not restore it back to the default. As the result subsequent tests can fail, especially on slower or busy machines.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3462) TestDFSClientRetries.busyTest() should restore default xceiver count in the config.

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286500#comment-13286500 ] 

Hudson commented on HDFS-3462:
------------------------------

Integrated in Hadoop-Hdfs-trunk #1062 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1062/])
    HDFS-3476. Correct the default used in TestDFSClientRetries.busyTest() after HDFS-3462. (harsh) (Revision 1344394)

     Result = SUCCESS
harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1344394
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSClientRetries.java

                
> TestDFSClientRetries.busyTest() should restore default xceiver count in the config.
> -----------------------------------------------------------------------------------
>
>                 Key: HDFS-3462
>                 URL: https://issues.apache.org/jira/browse/HDFS-3462
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 3.0.0
>            Reporter: Konstantin Shvachko
>             Fix For: 3.0.0
>
>         Attachments: HDFS-3462.patch, testGetFileChecksum.log.htm
>
>
> TestDFSClientRetries.busyTest() sets maximum xceiver count in the config to a small value, but does not restore it back to the default. As the result subsequent tests can fail, especially on slower or busy machines.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3462) TestDFSClientRetries.busyTest() should restore default xceiver count in the config.

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285902#comment-13285902 ] 

Hudson commented on HDFS-3462:
------------------------------

Integrated in Hadoop-Common-trunk-Commit #2301 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2301/])
    HDFS-3476. Correct the default used in TestDFSClientRetries.busyTest() after HDFS-3462. (harsh) (Revision 1344394)

     Result = SUCCESS
harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1344394
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSClientRetries.java

                
> TestDFSClientRetries.busyTest() should restore default xceiver count in the config.
> -----------------------------------------------------------------------------------
>
>                 Key: HDFS-3462
>                 URL: https://issues.apache.org/jira/browse/HDFS-3462
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 3.0.0
>            Reporter: Konstantin Shvachko
>             Fix For: 3.0.0
>
>         Attachments: HDFS-3462.patch, testGetFileChecksum.log.htm
>
>
> TestDFSClientRetries.busyTest() sets maximum xceiver count in the config to a small value, but does not restore it back to the default. As the result subsequent tests can fail, especially on slower or busy machines.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3462) TestDFSClientRetries.busyTest() should restore default xceiver count in the config.

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13284941#comment-13284941 ] 

Hudson commented on HDFS-3462:
------------------------------

Integrated in Hadoop-Mapreduce-trunk-Commit #2315 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2315/])
    HDFS-3462. TestDFSClientRetries.busyTest() should restore default xceiver count in the config. Contributed by Madhukara Phatak. (harsh) (Revision 1343798)

     Result = FAILURE
harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1343798
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSClientRetries.java

                
> TestDFSClientRetries.busyTest() should restore default xceiver count in the config.
> -----------------------------------------------------------------------------------
>
>                 Key: HDFS-3462
>                 URL: https://issues.apache.org/jira/browse/HDFS-3462
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 3.0.0
>            Reporter: Konstantin Shvachko
>             Fix For: 3.0.0
>
>         Attachments: HDFS-3462.patch, testGetFileChecksum.log.htm
>
>
> TestDFSClientRetries.busyTest() sets maximum xceiver count in the config to a small value, but does not restore it back to the default. As the result subsequent tests can fail, especially on slower or busy machines.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira