You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Alejandro Fernandez <af...@hortonworks.com> on 2014/11/11 00:08:05 UTC
Review Request 27837: Ambari hive-log4j.properties should output the
thread id
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27837/
-----------------------------------------------------------
Review request for Ambari, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Srimanth Gunturi, and Sid Wagle.
Bugs: AMBARI-8265
https://issues.apache.org/jira/browse/AMBARI-8265
Repository: ambari
Description
-------
In HIVE-6876 (https://github.com/hortonworks/hive/blob/champlain/common/src/main/resources/hive-log4j.properties), we added better logging to log thread-ids. Without this, any sort of debugging which involves tracking the flow of a query through server threads, becomes very difficult. For some reason, I don't see the thread id logging pattern ([%t]) in the hive-log4j.properties that gets put into the conf directory.
Diffs
-----
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/hive-log4j.xml cb8d3a9
Diff: https://reviews.apache.org/r/27837/diff/
Testing
-------
----------------------------------------------------------------------
Total run:693
Total errors:0
Total failures:0
OK
Thanks,
Alejandro Fernandez
Re: Review Request 27837: Ambari hive-log4j.properties should output
the thread id
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27837/#review60708
-----------------------------------------------------------
Ship it!
Ship It!
- Jaimin Jetly
On Nov. 10, 2014, 11:15 p.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27837/
> -----------------------------------------------------------
>
> (Updated Nov. 10, 2014, 11:15 p.m.)
>
>
> Review request for Ambari, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Srimanth Gunturi, and Sid Wagle.
>
>
> Bugs: AMBARI-8265
> https://issues.apache.org/jira/browse/AMBARI-8265
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In HIVE-6876 (https://github.com/hortonworks/hive/blob/champlain/common/src/main/resources/hive-log4j.properties), we added better logging to log thread-ids. Without this, any sort of debugging which involves tracking the flow of a query through server threads, becomes very difficult. For some reason, I don't see the thread id logging pattern ([%t]) in the hive-log4j.properties that gets put into the conf directory.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/hive-log4j.xml cb8d3a9
>
> Diff: https://reviews.apache.org/r/27837/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 26:10.966s
> [INFO] Finished at: Mon Nov 10 15:15:17 PST 2014
> [INFO] Final Memory: 64M/434M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 27837: Ambari hive-log4j.properties should output
the thread id
Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27837/#review60710
-----------------------------------------------------------
Ship it!
Ship It!
- Yusaku Sako
On Nov. 10, 2014, 11:15 p.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27837/
> -----------------------------------------------------------
>
> (Updated Nov. 10, 2014, 11:15 p.m.)
>
>
> Review request for Ambari, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Srimanth Gunturi, and Sid Wagle.
>
>
> Bugs: AMBARI-8265
> https://issues.apache.org/jira/browse/AMBARI-8265
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In HIVE-6876 (https://github.com/hortonworks/hive/blob/champlain/common/src/main/resources/hive-log4j.properties), we added better logging to log thread-ids. Without this, any sort of debugging which involves tracking the flow of a query through server threads, becomes very difficult. For some reason, I don't see the thread id logging pattern ([%t]) in the hive-log4j.properties that gets put into the conf directory.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/hive-log4j.xml cb8d3a9
>
> Diff: https://reviews.apache.org/r/27837/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 26:10.966s
> [INFO] Finished at: Mon Nov 10 15:15:17 PST 2014
> [INFO] Final Memory: 64M/434M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 27837: Ambari hive-log4j.properties should output
the thread id
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27837/
-----------------------------------------------------------
(Updated Nov. 10, 2014, 11:15 p.m.)
Review request for Ambari, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Srimanth Gunturi, and Sid Wagle.
Bugs: AMBARI-8265
https://issues.apache.org/jira/browse/AMBARI-8265
Repository: ambari
Description
-------
In HIVE-6876 (https://github.com/hortonworks/hive/blob/champlain/common/src/main/resources/hive-log4j.properties), we added better logging to log thread-ids. Without this, any sort of debugging which involves tracking the flow of a query through server threads, becomes very difficult. For some reason, I don't see the thread id logging pattern ([%t]) in the hive-log4j.properties that gets put into the conf directory.
Diffs
-----
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/hive-log4j.xml cb8d3a9
Diff: https://reviews.apache.org/r/27837/diff/
Testing (updated)
-------
mvn clean test
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 26:10.966s
[INFO] Finished at: Mon Nov 10 15:15:17 PST 2014
[INFO] Final Memory: 64M/434M
[INFO] ------------------------------------------------------------------------
Thanks,
Alejandro Fernandez