You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Adrian Cole <no...@github.com> on 2014/10/05 08:14:06 UTC
[jclouds] Prepare to delete AsyncBlobStore (#546)
This pull request does 3 things in preparation for removing the long deprecated async blobstore.
1. Refactor out LocalAsyncBlobStore so that we don't have any more implementations of AsyncBlobstore.
2. Make SubmissionAsyncBlobstore the implicit implementation of AsyncBlobStore. This will allow us to remove it easier.
3. Replace internal references to AsyncBlobstore with plain old executorService calls.
You can merge this Pull Request by running:
git pull https://github.com/adriancole/jclouds adrian.prepare-to-delete-asyncblobstore
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/546
-- Commit Summary --
* JCLOUDS-40 remove all implementations of AsyncBlobStore except Submission in preparation for complete removal.
* JCLOUDS-40 Remove internal usage of AsyncBlobStore.
-- File Changes --
M apis/atmos/src/main/java/org/jclouds/atmos/blobstore/config/AtmosBlobStoreContextModule.java (3)
M apis/cloudfiles/src/main/java/org/jclouds/cloudfiles/blobstore/CloudFilesBlobStore.java (15)
M apis/filesystem/src/main/java/org/jclouds/filesystem/config/FilesystemBlobStoreContextModule.java (8)
M apis/s3/src/main/java/org/jclouds/s3/blobstore/config/S3BlobStoreContextModule.java (3)
M apis/swift/src/main/java/org/jclouds/openstack/swift/blobstore/SwiftBlobStore.java (34)
M apis/swift/src/main/java/org/jclouds/openstack/swift/blobstore/config/SwiftBlobStoreContextModule.java (3)
M blobstore/src/main/java/org/jclouds/blobstore/AsyncBlobStore.java (3)
D blobstore/src/main/java/org/jclouds/blobstore/LocalAsyncBlobStore.java (558)
M blobstore/src/main/java/org/jclouds/blobstore/config/LocalBlobStore.java (562)
M blobstore/src/main/java/org/jclouds/blobstore/config/TransientBlobStoreContextModule.java (10)
D blobstore/src/main/java/org/jclouds/blobstore/internal/BaseAsyncBlobStore.java (310)
M blobstore/src/main/java/org/jclouds/blobstore/strategy/internal/FetchBlobMetadata.java (18)
M blobstore/src/main/java/org/jclouds/blobstore/strategy/internal/GetAllBlobsInListAndRetryOnFailure.java (18)
M blobstore/src/main/java/org/jclouds/blobstore/strategy/internal/MarkersDeleteDirectoryStrategy.java (20)
M blobstore/src/main/java/org/jclouds/blobstore/strategy/internal/PutBlobsStrategyImpl.java (19)
M blobstore/src/main/java/org/jclouds/blobstore/util/BlobStoreUtils.java (24)
M blobstore/src/test/java/org/jclouds/blobstore/TransientBlobRequestSignerTest.java (3)
M blobstore/src/test/java/org/jclouds/blobstore/util/BlobStoreUtilsTest.java (74)
M providers/aws-s3/src/test/java/org/jclouds/aws/s3/AWSS3ClientLiveTest.java (15)
M providers/azureblob/src/main/java/org/jclouds/azureblob/blobstore/config/AzureBlobStoreContextModule.java (3)
M providers/hpcloud-objectstorage/src/main/java/org/jclouds/hpcloud/objectstorage/blobstore/HPCloudObjectStorageBlobStore.java (27)
M providers/hpcloud-objectstorage/src/main/java/org/jclouds/hpcloud/objectstorage/blobstore/config/HPCloudObjectStorageBlobStoreContextModule.java (4)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/546.patch
https://github.com/jclouds/jclouds/pull/546.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/546
Re: [jclouds] Prepare to delete AsyncBlobStore (#546)
Posted by BuildHive <no...@github.com>.
[jclouds ยป jclouds #1708](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1708/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/546#issuecomment-57928553
Re: [jclouds] Prepare to delete AsyncBlobStore (#546)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests-java-6 #134](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/134/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/546#issuecomment-57927859
Re: [jclouds] Prepare to delete AsyncBlobStore (#546)
Posted by Adrian Cole <no...@github.com>.
unstable is false-negative. clicking link shows it passed!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/546#issuecomment-57940300
Re: [jclouds] Prepare to delete AsyncBlobStore (#546)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #1223](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1223/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/546#issuecomment-57928710
Re: [jclouds] Prepare to delete AsyncBlobStore (#546)
Posted by Adrian Cole <no...@github.com>.
> +import org.jclouds.http.HttpResponseException;
> +import org.jclouds.http.HttpUtils;
> +import org.jclouds.io.ByteStreams2;
> +import org.jclouds.io.ContentMetadata;
> +import org.jclouds.io.ContentMetadataCodec;
> +import org.jclouds.io.Payload;
> +import org.jclouds.logging.Logger;
> +
> +import com.google.common.base.Function;
> +import com.google.common.base.Predicate;
> +import com.google.common.base.Supplier;
> +import com.google.common.collect.ImmutableMap;
> +import com.google.common.collect.Iterables;
> +
> +@Singleton
> +public final class LocalBlobStore implements BlobStore {
This was a copy/paste, unasync of LocalAsyncBlobStore and its base class.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/546/files#r18433456
Re: [jclouds] Prepare to delete AsyncBlobStore (#546)
Posted by Adrian Cole <no...@github.com>.
cherry-picked into master, 1.8.x
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/546#issuecomment-57947210
Re: [jclouds] Prepare to delete AsyncBlobStore (#546)
Posted by Ignasi Barrera <no...@github.com>.
I'm not the blobstore expert here, but change LGTM.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/546#issuecomment-57939129