You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jason Zhou <ja...@gmail.com> on 2024/07/31 18:32:40 UTC
Review Request 75130: [cgroups] Skip enabling of devices controller
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75130/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Repository: mesos
Description
-------
Similar to the `perf_event` controller, the `devices` controller cannot
be written into cgroup.subtree_control file, so we skip the call to
cgroups2::controllers::enable for the device controller. Otherwise
we will run into an "Invalid argument" error from cgroups.
Diffs
-----
src/slave/containerizer/mesos/isolators/cgroups2/cgroups2.cpp 2ca3880790be0cd092ec05a359711e2d8e641314
Diff: https://reviews.apache.org/r/75130/diff/1/
Testing
-------
Code compiles
Thanks,
Jason Zhou
Re: Review Request 75130: [cgroups2] Skip enabling of devices controller
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75130/#review226753
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Mahler
On July 31, 2024, 6:32 p.m., Jason Zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75130/
> -----------------------------------------------------------
>
> (Updated July 31, 2024, 6:32 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Similar to the `perf_event` controller, the `devices` controller cannot
> be written into cgroup.subtree_control file, so we skip the call to
> cgroups2::controllers::enable for the device controller. Otherwise
> we will run into an "Invalid argument" error from cgroups.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/cgroups2/cgroups2.cpp 2ca3880790be0cd092ec05a359711e2d8e641314
>
>
> Diff: https://reviews.apache.org/r/75130/diff/2/
>
>
> Testing
> -------
>
> Code compiles
>
>
> Thanks,
>
> Jason Zhou
>
>