You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2023/05/15 11:37:04 UTC
[GitHub] [airflow] potiuk opened a new pull request, #31289: Add future-compatible mongo Hook typing
potiuk opened a new pull request, #31289:
URL: https://github.com/apache/airflow/pull/31289
We are migrating to new mongo library soon and it has typing support. This one adds propert typing that will prevent MyPy from failing once mongo gets upgraded.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #31289: Add future-compatible mongo Hook typing
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #31289:
URL: https://github.com/apache/airflow/pull/31289#discussion_r1193968183
##########
airflow/providers/mongo/hooks/mongo.py:
##########
@@ -20,10 +20,12 @@
from ssl import CERT_NONE
from types import TracebackType
+from typing import Any, overload
from urllib.parse import quote_plus, urlunsplit
import pymongo
from pymongo import MongoClient, ReplaceOne
+from typing_extensions import Literal
Review Comment:
of course. Silly me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #31289: Add future-compatible mongo Hook typing
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #31289:
URL: https://github.com/apache/airflow/pull/31289#discussion_r1193970025
##########
airflow/providers/mongo/hooks/mongo.py:
##########
@@ -20,10 +20,12 @@
from ssl import CERT_NONE
from types import TracebackType
+from typing import Any, overload
from urllib.parse import quote_plus, urlunsplit
import pymongo
from pymongo import MongoClient, ReplaceOne
+from typing_extensions import Literal
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #31289: Add future-compatible mongo Hook typing
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #31289:
URL: https://github.com/apache/airflow/pull/31289
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] josh-fell commented on a diff in pull request #31289: Add future-compatible mongo Hook typing
Posted by "josh-fell (via GitHub)" <gi...@apache.org>.
josh-fell commented on code in PR #31289:
URL: https://github.com/apache/airflow/pull/31289#discussion_r1193936441
##########
airflow/providers/mongo/hooks/mongo.py:
##########
@@ -20,10 +20,12 @@
from ssl import CERT_NONE
from types import TracebackType
+from typing import Any, overload
from urllib.parse import quote_plus, urlunsplit
import pymongo
from pymongo import MongoClient, ReplaceOne
+from typing_extensions import Literal
Review Comment:
Should `airflow.typing_compat` be used here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #31289: Add future-compatible mongo Hook typing
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #31289:
URL: https://github.com/apache/airflow/pull/31289#issuecomment-1547711198
Looks like two more changes needed in `mongo_to_s3` :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org