You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org> on 2020/01/28 23:44:35 UTC

[kudu-CR] Store the base BlockBloomFilterAllocatorIf ptr in ColumnPredicate

Bankim Bhavsar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15120


Change subject: Store the base BlockBloomFilterAllocatorIf ptr in ColumnPredicate
......................................................................

Store the base BlockBloomFilterAllocatorIf ptr in ColumnPredicate

This allows the flexibility to use not just the ArenaBlockBloomFilterAllocator
for the BlockBloomFilter.

Change-Id: Idd8edf9dd18fc355acd8cd8a4bb5a2a43929e5ee
---
M src/kudu/common/column_predicate.cc
M src/kudu/common/column_predicate.h
2 files changed, 5 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/15120/1
-- 
To view, visit http://gerrit.cloudera.org:8080/15120
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idd8edf9dd18fc355acd8cd8a4bb5a2a43929e5ee
Gerrit-Change-Number: 15120
Gerrit-PatchSet: 1
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>

[kudu-CR] Store the base BlockBloomFilterAllocatorIf ptr in ColumnPredicate

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15120 )

Change subject: Store the base BlockBloomFilterAllocatorIf ptr in ColumnPredicate
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15120
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd8edf9dd18fc355acd8cd8a4bb5a2a43929e5ee
Gerrit-Change-Number: 15120
Gerrit-PatchSet: 2
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 29 Jan 2020 00:42:26 +0000
Gerrit-HasComments: No

[kudu-CR] Store the base BlockBloomFilterAllocatorIf ptr in ColumnPredicate

Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has abandoned this change. ( http://gerrit.cloudera.org:8080/15120 )

Change subject: Store the base BlockBloomFilterAllocatorIf ptr in ColumnPredicate
......................................................................


Abandoned

No need to store the allocator ptr in ColumnPredicate. See patch set 11 onwards on https://gerrit.cloudera.org/c/15034/
-- 
To view, visit http://gerrit.cloudera.org:8080/15120
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Idd8edf9dd18fc355acd8cd8a4bb5a2a43929e5ee
Gerrit-Change-Number: 15120
Gerrit-PatchSet: 2
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] Store the base BlockBloomFilterAllocatorIf ptr in ColumnPredicate

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15120 )

Change subject: Store the base BlockBloomFilterAllocatorIf ptr in ColumnPredicate
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15120
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd8edf9dd18fc355acd8cd8a4bb5a2a43929e5ee
Gerrit-Change-Number: 15120
Gerrit-PatchSet: 1
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 29 Jan 2020 00:15:36 +0000
Gerrit-HasComments: No