You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/08/04 16:55:53 UTC

[GitHub] [kafka] lbradstreet opened a new pull request #9123: MINOR: optimize fetchablePartitions check by performing cheap check first

lbradstreet opened a new pull request #9123:
URL: https://github.com/apache/kafka/pull/9123


   When the consumer fetches a lot of partitions at once the isAvailable
   check can become expensive due to a high number of contains check. We
   might as well perform the isFetchable check first as this is clearly much
   cheaper.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] lbradstreet edited a comment on pull request #9123: MINOR: optimize fetchablePartitions check by performing cheap check first

Posted by GitBox <gi...@apache.org>.
lbradstreet edited a comment on pull request #9123:
URL: https://github.com/apache/kafka/pull/9123#issuecomment-668711747


   ![image](https://user-images.githubusercontent.com/252189/89322318-ecf1be80-d638-11ea-9d5b-4ea11124201c.png)
   
   From a profile fetching from 2500 partitions. This section of code takes 7.85%. In the happy case I would not expect this to improve, but we should see an improvement when partitions are unfetchable.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] lbradstreet closed pull request #9123: MINOR: optimize fetchablePartitions check by performing cheap check first

Posted by GitBox <gi...@apache.org>.
lbradstreet closed pull request #9123:
URL: https://github.com/apache/kafka/pull/9123


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] lbradstreet commented on pull request #9123: MINOR: optimize fetchablePartitions check by performing cheap check first

Posted by GitBox <gi...@apache.org>.
lbradstreet commented on pull request #9123:
URL: https://github.com/apache/kafka/pull/9123#issuecomment-668711747


   ![image](https://user-images.githubusercontent.com/252189/89322318-ecf1be80-d638-11ea-9d5b-4ea11124201c.png)
   
   From a profile fetching from 2500 partitions. This section of code takes 7.85%.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org