[GitHub] [incubator-superset] etr2460 edited a comment on pull request #10129: chore: fix add datasource help string

[GitBox <gi...@apache.org>]

etr2460 edited a comment on pull request #10129:
URL: https://github.com/apache/incubator-superset/pull/10129#issuecomment-647568071


   @ktmud, that's a good point, I didn't know you could set a key for these translation functions. Seems like we could do this programmatically instead of needing humans to choose a shorter key when coding.
   
   However, I took a look at the current data, and the bootstrap payload for translations is about 39KB uncompressed. While way too large, it's a very tiny portion of the 1.5MB uncompressed bootstrap data that we get on dashboards from time to time.
   
   If I had to rearchitect/optimize this, I'd:
   1. Remove the translation object from the bootstrap data
   2. Uniquely hash the translation objects by content and bundle with superset as json files, so that each new deploy/build generates a new translation object for each language
   3. Set a cache time of 1 year for all these files, so that the user only ever needs to download a language once
   4. If optimizations are still required, consider programmatically minifying the keys in the translation objects (note gzip should already be doing a decent job at compressing this)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org