svn commit: r1341326 - /ofbiz/branches/release10.04/applications/order/src/org/ofbiz/order/order/OrderServices.java

[ja...@apache.org]

Author: jacopoc
Date: Tue May 22 07:06:01 2012
New Revision: 1341326

URL: http://svn.apache.org/viewvc?rev=1341326&view=rev
Log:
Applied fix from trunk for revision: 1341314 
===

Fixed error reported in OFBIZ-4892: in orders with more than one promo codes, only one code was stored in OrderProductPromoCode entity.
Thanks to Ritu Raj Lakhera for the report and the patch; the one I have committed fixes the bug in a slightly different way.


Modified:
    ofbiz/branches/release10.04/applications/order/src/org/ofbiz/order/order/OrderServices.java

Modified: ofbiz/branches/release10.04/applications/order/src/org/ofbiz/order/order/OrderServices.java
URL: http://svn.apache.org/viewvc/ofbiz/branches/release10.04/applications/order/src/org/ofbiz/order/order/OrderServices.java?rev=1341326&r1=1341325&r2=1341326&view=diff
==============================================================================
--- ofbiz/branches/release10.04/applications/order/src/org/ofbiz/order/order/OrderServices.java (original)
+++ ofbiz/branches/release10.04/applications/order/src/org/ofbiz/order/order/OrderServices.java Tue May 22 07:06:01 2012
@@ -937,10 +937,9 @@ public class OrderServices {
         // store the orderProductPromoCodes
         Set orderProductPromoCodes = (Set) context.get("orderProductPromoCodes");
         if (UtilValidate.isNotEmpty(orderProductPromoCodes)) {
-            GenericValue orderProductPromoCode = delegator.makeValue("OrderProductPromoCode");
             Iterator orderProductPromoCodeIter = orderProductPromoCodes.iterator();
             while (orderProductPromoCodeIter.hasNext()) {
-                orderProductPromoCode.clear();
+                GenericValue orderProductPromoCode = delegator.makeValue("OrderProductPromoCode");
                 orderProductPromoCode.set("orderId", orderId);
                 orderProductPromoCode.set("productPromoCodeId", orderProductPromoCodeIter.next());
                 toBeStored.add(orderProductPromoCode);