You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Alan Gates (JIRA)" <ji...@apache.org> on 2011/04/23 16:36:05 UTC
[jira] [Created] (PIG-2012) Comments at the begging of file throw
off line numbers in errors
Comments at the begging of file throw off line numbers in errors
----------------------------------------------------------------
Key: PIG-2012
URL: https://issues.apache.org/jira/browse/PIG-2012
Project: Pig
Issue Type: Bug
Components: impl
Affects Versions: 0.9.0
Reporter: Alan Gates
Assignee: Richard Ding
The preprocessor does not appear to be handling leading comments properly when calculating line numbers for error messages. In the attached script, the error is reported to be on line 7. It is actually on line 10.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2012) Comments at the begging of file throw
off line numbers in errors
Posted by "Alan Gates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alan Gates updated PIG-2012:
----------------------------
Attachment: macro.pig
> Comments at the begging of file throw off line numbers in errors
> ----------------------------------------------------------------
>
> Key: PIG-2012
> URL: https://issues.apache.org/jira/browse/PIG-2012
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.9.0
> Reporter: Alan Gates
> Assignee: Richard Ding
> Attachments: macro.pig
>
>
> The preprocessor does not appear to be handling leading comments properly when calculating line numbers for error messages. In the attached script, the error is reported to be on line 7. It is actually on line 10.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2012) Comments at the begining of the file
throws off line numbers in errors
Posted by "Richard Ding (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13028864#comment-13028864 ]
Richard Ding commented on PIG-2012:
-----------------------------------
Unit tests pass.
> Comments at the begining of the file throws off line numbers in errors
> ----------------------------------------------------------------------
>
> Key: PIG-2012
> URL: https://issues.apache.org/jira/browse/PIG-2012
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.9.0
> Reporter: Alan Gates
> Assignee: Richard Ding
> Fix For: 0.9.0
>
> Attachments: PIG-2012_1.patch, macro.pig
>
>
> The preprocessor does not appear to be handling leading comments properly when calculating line numbers for error messages. In the attached script, the error is reported to be on line 7. It is actually on line 10.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2012) Comments at the begining of the file
throws off line numbers in errors
Posted by "Richard Ding (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Richard Ding updated PIG-2012:
------------------------------
Status: Patch Available (was: Open)
> Comments at the begining of the file throws off line numbers in errors
> ----------------------------------------------------------------------
>
> Key: PIG-2012
> URL: https://issues.apache.org/jira/browse/PIG-2012
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.9.0
> Reporter: Alan Gates
> Assignee: Richard Ding
> Fix For: 0.9.0
>
> Attachments: PIG-2012_1.patch, macro.pig
>
>
> The preprocessor does not appear to be handling leading comments properly when calculating line numbers for error messages. In the attached script, the error is reported to be on line 7. It is actually on line 10.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2012) Comments at the begining of the file
throws off line numbers in errors
Posted by "Richard Ding (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Richard Ding updated PIG-2012:
------------------------------
Attachment: PIG-2012_2.patch
Thanks Xuefu. The new patch addresses the review comments.
> Comments at the begining of the file throws off line numbers in errors
> ----------------------------------------------------------------------
>
> Key: PIG-2012
> URL: https://issues.apache.org/jira/browse/PIG-2012
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.9.0
> Reporter: Alan Gates
> Assignee: Richard Ding
> Fix For: 0.9.0
>
> Attachments: PIG-2012_1.patch, PIG-2012_2.patch, macro.pig
>
>
> The preprocessor does not appear to be handling leading comments properly when calculating line numbers for error messages. In the attached script, the error is reported to be on line 7. It is actually on line 10.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2012) Comments at the begining of the file
throws off line numbers in errors
Posted by "Richard Ding (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Richard Ding updated PIG-2012:
------------------------------
Attachment: PIG-2012_1.patch
> Comments at the begining of the file throws off line numbers in errors
> ----------------------------------------------------------------------
>
> Key: PIG-2012
> URL: https://issues.apache.org/jira/browse/PIG-2012
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.9.0
> Reporter: Alan Gates
> Assignee: Richard Ding
> Fix For: 0.9.0
>
> Attachments: PIG-2012_1.patch, macro.pig
>
>
> The preprocessor does not appear to be handling leading comments properly when calculating line numbers for error messages. In the attached script, the error is reported to be on line 7. It is actually on line 10.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2012) Comments at the begining of the file
throws off line numbers in errors
Posted by "Xuefu Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13030930#comment-13030930 ]
Xuefu Zhang commented on PIG-2012:
----------------------------------
+1 to patch PIG-2012_2.patch
> Comments at the begining of the file throws off line numbers in errors
> ----------------------------------------------------------------------
>
> Key: PIG-2012
> URL: https://issues.apache.org/jira/browse/PIG-2012
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.9.0
> Reporter: Alan Gates
> Assignee: Richard Ding
> Fix For: 0.9.0
>
> Attachments: PIG-2012_1.patch, PIG-2012_2.patch, macro.pig
>
>
> The preprocessor does not appear to be handling leading comments properly when calculating line numbers for error messages. In the attached script, the error is reported to be on line 7. It is actually on line 10.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2012) Comments at the begining of the file
throws off line numbers in errors
Posted by "Alan Gates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alan Gates updated PIG-2012:
----------------------------
Summary: Comments at the begining of the file throws off line numbers in errors (was: Comments at the begging of file throw off line numbers in errors)
> Comments at the begining of the file throws off line numbers in errors
> ----------------------------------------------------------------------
>
> Key: PIG-2012
> URL: https://issues.apache.org/jira/browse/PIG-2012
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.9.0
> Reporter: Alan Gates
> Assignee: Richard Ding
> Attachments: macro.pig
>
>
> The preprocessor does not appear to be handling leading comments properly when calculating line numbers for error messages. In the attached script, the error is reported to be on line 7. It is actually on line 10.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2012) Comments at the begining of the file
throws off line numbers in errors
Posted by "Woody Anderson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13031001#comment-13031001 ]
Woody Anderson commented on PIG-2012:
-------------------------------------
thanks for this one! this has been a major pain for me.
> Comments at the begining of the file throws off line numbers in errors
> ----------------------------------------------------------------------
>
> Key: PIG-2012
> URL: https://issues.apache.org/jira/browse/PIG-2012
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.9.0
> Reporter: Alan Gates
> Assignee: Richard Ding
> Fix For: 0.9.0
>
> Attachments: PIG-2012_1.patch, PIG-2012_2.patch, macro.pig
>
>
> The preprocessor does not appear to be handling leading comments properly when calculating line numbers for error messages. In the attached script, the error is reported to be on line 7. It is actually on line 10.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2012) Comments at the begining of the file
throws off line numbers in errors
Posted by "Richard Ding (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Richard Ding updated PIG-2012:
------------------------------
Fix Version/s: 0.9.0
> Comments at the begining of the file throws off line numbers in errors
> ----------------------------------------------------------------------
>
> Key: PIG-2012
> URL: https://issues.apache.org/jira/browse/PIG-2012
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.9.0
> Reporter: Alan Gates
> Assignee: Richard Ding
> Fix For: 0.9.0
>
> Attachments: macro.pig
>
>
> The preprocessor does not appear to be handling leading comments properly when calculating line numbers for error messages. In the attached script, the error is reported to be on line 7. It is actually on line 10.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2012) Comments at the begining of the file
throws off line numbers in errors
Posted by "Xuefu Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029063#comment-13029063 ]
Xuefu Zhang commented on PIG-2012:
----------------------------------
1. Macro invocation stack should be per macro, not per node in a macro. Also, stack seems to be a more appropriate data structure for this.
2. To get line numbers correctly, we should be able to do it more naturally in PigParserNode constractor, rather than prepending \n in the text.
3. It might be cleaner and more OO if we have PigParserMacroNode that inherits from PigParserNode. In that case, we only need to override toString() method, but avoid if-else clauses in the code.
> Comments at the begining of the file throws off line numbers in errors
> ----------------------------------------------------------------------
>
> Key: PIG-2012
> URL: https://issues.apache.org/jira/browse/PIG-2012
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.9.0
> Reporter: Alan Gates
> Assignee: Richard Ding
> Fix For: 0.9.0
>
> Attachments: PIG-2012_1.patch, macro.pig
>
>
> The preprocessor does not appear to be handling leading comments properly when calculating line numbers for error messages. In the attached script, the error is reported to be on line 7. It is actually on line 10.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2012) Comments at the begining of the file
throws off line numbers in errors
Posted by "Richard Ding (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Richard Ding updated PIG-2012:
------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Patch 2 committed to trunk and 0.9 branch.
> Comments at the begining of the file throws off line numbers in errors
> ----------------------------------------------------------------------
>
> Key: PIG-2012
> URL: https://issues.apache.org/jira/browse/PIG-2012
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.9.0
> Reporter: Alan Gates
> Assignee: Richard Ding
> Fix For: 0.9.0
>
> Attachments: PIG-2012_1.patch, PIG-2012_2.patch, macro.pig
>
>
> The preprocessor does not appear to be handling leading comments properly when calculating line numbers for error messages. In the attached script, the error is reported to be on line 7. It is actually on line 10.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2012) Comments at the begining of the file
throws off line numbers in errors
Posted by "Richard Ding (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13027174#comment-13027174 ]
Richard Ding commented on PIG-2012:
-----------------------------------
test-patch result:
{code}
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 3 new or modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] -1 javac. The applied patch generated 964 javac compiler warnings (more than the trunk's current 963 warnings).
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
{code}
> Comments at the begining of the file throws off line numbers in errors
> ----------------------------------------------------------------------
>
> Key: PIG-2012
> URL: https://issues.apache.org/jira/browse/PIG-2012
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.9.0
> Reporter: Alan Gates
> Assignee: Richard Ding
> Fix For: 0.9.0
>
> Attachments: PIG-2012_1.patch, macro.pig
>
>
> The preprocessor does not appear to be handling leading comments properly when calculating line numbers for error messages. In the attached script, the error is reported to be on line 7. It is actually on line 10.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira