You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Peter Ertl (Commented) (JIRA)" <ji...@apache.org> on 2012/01/25 21:03:40 UTC
[jira] [Commented] (WICKET-4357) Calling
WebResponse#enableCaching() is insufficient to enable caching on WebPage
(which by default is non-cacheable)
[ https://issues.apache.org/jira/browse/WICKET-4357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13193267#comment-13193267 ]
Peter Ertl commented on WICKET-4357:
------------------------------------
Actually the javadoc on WebPage#setHeaders is pretty straightforward on this. Nevertheless I added a link to this jira ticket in the javadoc for #enableCaching and potentially save some people's time :-)
> Calling WebResponse#enableCaching() is insufficient to enable caching on WebPage (which by default is non-cacheable)
> --------------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-4357
> URL: https://issues.apache.org/jira/browse/WICKET-4357
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.4, 6.0.0
> Reporter: Michael Allan
> Assignee: Peter Ertl
> Priority: Minor
> Labels: cache
> Fix For: 1.5.5, 6.0.0
>
>
> WebResponse.enableCaching() is documented to enable caching, but it does not. You must also override WebPage.setHeaders(), otherwise it clobbers the headers by calling disableCaching().
> The API docs for WebResponse.enableCaching() should be clear about this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira