[GitHub] [samza] ajothomas commented on a diff in pull request #1616: SAMZA-2751: [Pipeline Drain] RunLoop and High Level API changes for Drain

[GitBox <gi...@apache.org>]

ajothomas commented on code in PR #1616:
URL: https://github.com/apache/samza/pull/1616#discussion_r923695705


##########
samza-core/src/main/scala/org/apache/samza/system/SystemConsumers.scala:
##########
@@ -237,6 +233,13 @@ class SystemConsumers (
     }
   }
 
+  def drain(): Unit = {
+    if (!isDraining) {
+      isDraining = true;
+      info("SystemConsumers is set to drain mode.")
+      writeDrainControlMessageToSspQueue()

Review Comment:
   New envelopes will be added to SystemConsumers' in-memory queue from the registered consumers whenever refresh is called. When in drain mode, refresh will not add new messages from the consumers.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org