You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/18 17:04:44 UTC

[GitHub] [airflow] xinbinhuang edited a comment on pull request #12677: Refactor SQL/BigQuery/Qubole/Druid Check operators

xinbinhuang edited a comment on pull request #12677:
URL: https://github.com/apache/airflow/pull/12677#issuecomment-762371814


   > @xinbinhuang nice work! Just to be sure - there is no breaking change, right? @potiuk would you mind also taking a look?
   
   Yes, there is one place that may be considered fixing rather than breaking. For `airflow/providers/google/cloud/hooks/bigquery.py`, I changed the hook's `conn_type` and `hook_name`  from `google cloud platform`/`Google Cloud` to `bigquery`/`BigQuery`. This fixes the issue where `conn.get_hook` will never return the bigquery hook because `GoogleBaseHook` "hides" the `BigQueryHook` as they have the same `conn_type`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org