You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/09/24 12:05:01 UTC

[GitHub] [apisix] moonming commented on a change in pull request #2305: fix: kafka-logger plugin sent to the same partition everytime

moonming commented on a change in pull request #2305:
URL: https://github.com/apache/apisix/pull/2305#discussion_r494259548



##########
File path: apisix/plugins/kafka-logger.lua
##########
@@ -82,6 +84,11 @@ local function send_kafka_data(conf, log_message)
     end
 
     broker_config["request_timeout"] = conf.timeout * 1000
+    broker_config["partitioner"] = function(key, num, correlation_id)

Review comment:
       It will be better if you can add test cases to cover.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org