You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/03/17 02:47:47 UTC

[GitHub] [incubator-yunikorn-k8shim] wilfred-s edited a comment on pull request #386: [YUNIKORN-1105] Use absolute units for memory

wilfred-s edited a comment on pull request #386:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/386#issuecomment-1069966813


   With the fix for YUNIKORN-1121 we do not need any changes in `pkg/shim/scheduler_test.go` The tests pass without changes and it shows correctly that the tasks are not seen as _PodQOSBestEffort_ and we can schedule any pod size.
   
   Should we revert the changes for that file from this PR?
   Beside that it all looks good, waiting with approval until we decide on the file
   
   EDIT: removed duplicate comment, added missing sentence


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org