[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6139: Remove tyrus dependencies in pinot-tools module

[GitBox <gi...@apache.org>]

mayankshriv commented on a change in pull request #6139:
URL: https://github.com/apache/incubator-pinot/pull/6139#discussion_r504326801



##########
File path: pinot-tools/src/main/java/org/apache/pinot/tools/streams/MeetupRsvpStream.java
##########
@@ -20,102 +20,104 @@
 
 import com.fasterxml.jackson.databind.JsonNode;
 import com.fasterxml.jackson.databind.node.ObjectNode;
-import java.io.IOException;
-import java.net.URI;
+import java.io.BufferedReader;
+import java.io.File;
+import java.io.FileInputStream;
+import java.io.InputStreamReader;
 import java.nio.charset.StandardCharsets;
 import java.util.Properties;
-import javax.websocket.ClientEndpointConfig;
-import javax.websocket.Endpoint;
-import javax.websocket.EndpointConfig;
-import javax.websocket.MessageHandler;
-import javax.websocket.Session;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
 import org.apache.pinot.spi.stream.StreamDataProducer;
 import org.apache.pinot.spi.stream.StreamDataProvider;
 import org.apache.pinot.spi.utils.JsonUtils;
 import org.apache.pinot.tools.utils.KafkaStarterUtils;
-import org.glassfish.tyrus.client.ClientManager;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
 public class MeetupRsvpStream {
   private static final Logger LOGGER = LoggerFactory.getLogger(MeetupRsvpStream.class);
   private StreamDataProducer producer;
   private boolean keepPublishing = true;
-  private ClientManager client;
 
-  public MeetupRsvpStream()
+  private ExecutorService _service;
+  private File _dataFile;
+
+  public MeetupRsvpStream(File dataFile)

Review comment:
       I think getting a live stream was there for a reason. Perhaps we should evaluate if that is a good idea, and if so, still keep it, as opposed to having a dataFile. Once it is a data-file, it is the same as any other provider (not necessarily meetup).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org