You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by gg...@apache.org on 2015/11/30 21:44:30 UTC
svn commit: r1717327 - in
/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/hc/core5/http:
HttpMessage.java message/AbstractHttpMessage.java message/BasicHeader.java
Author: ggregory
Date: Mon Nov 30 20:44:29 2015
New Revision: 1717327
URL: http://svn.apache.org/viewvc?rev=1717327&view=rev
Log:
Update addHeader() and setHeader() APIs to take an Object instead of a String.
Modified:
httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/hc/core5/http/HttpMessage.java
httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/hc/core5/http/message/AbstractHttpMessage.java
httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/hc/core5/http/message/BasicHeader.java
Modified: httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/hc/core5/http/HttpMessage.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/hc/core5/http/HttpMessage.java?rev=1717327&r1=1717326&r2=1717327&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/hc/core5/http/HttpMessage.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/hc/core5/http/HttpMessage.java Mon Nov 30 20:44:29 2015
@@ -55,7 +55,7 @@ public interface HttpMessage<T> extends
* @param name the name of the header.
* @param value the value of the header.
*/
- void addHeader(String name, String value);
+ void addHeader(String name, Object value);
/**
* Overwrites the first header with the same name. The new header will be appended to
@@ -72,7 +72,7 @@ public interface HttpMessage<T> extends
* @param name the name of the header.
* @param value the value of the header.
*/
- void setHeader(String name, String value);
+ void setHeader(String name, Object value);
/**
* Overwrites all the headers in the message.
Modified: httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/hc/core5/http/message/AbstractHttpMessage.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/hc/core5/http/message/AbstractHttpMessage.java?rev=1717327&r1=1717326&r2=1717327&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/hc/core5/http/message/AbstractHttpMessage.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/hc/core5/http/message/AbstractHttpMessage.java Mon Nov 30 20:44:29 2015
@@ -43,13 +43,13 @@ public abstract class AbstractHttpMessag
private HttpEntity entity;
@Override
- public void addHeader(final String name, final String value) {
+ public void addHeader(final String name, final Object value) {
Args.notNull(name, "Header name");
addHeader(new BasicHeader(name, value));
}
@Override
- public void setHeader(final String name, final String value) {
+ public void setHeader(final String name, final Object value) {
Args.notNull(name, "Header name");
setHeader(new BasicHeader(name, value));
}
Modified: httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/hc/core5/http/message/BasicHeader.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/hc/core5/http/message/BasicHeader.java?rev=1717327&r1=1717326&r2=1717327&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/hc/core5/http/message/BasicHeader.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/hc/core5/http/message/BasicHeader.java Mon Nov 30 20:44:29 2015
@@ -28,6 +28,7 @@
package org.apache.hc.core5.http.message;
import java.io.Serializable;
+import java.util.Objects;
import org.apache.hc.core5.annotation.Immutable;
import org.apache.hc.core5.http.Header;
@@ -55,10 +56,10 @@ public class BasicHeader implements Head
* @param name the header name
* @param value the header value
*/
- public BasicHeader(final String name, final String value) {
+ public BasicHeader(final String name, final Object value) {
super();
this.name = Args.notNull(name, "Name");
- this.value = value;
+ this.value = Objects.toString(value, null);
}
@Override