[GitHub] [airflow] mik-laj commented on a change in pull request #6375: [AIRFLOW-5706] Add KubernetesPodYamlOperator

[GitBox <gi...@apache.org>]

mik-laj commented on a change in pull request #6375: [AIRFLOW-5706] Add KubernetesPodYamlOperator
URL: https://github.com/apache/airflow/pull/6375#discussion_r337050245
 
 

 ##########
 File path: airflow/contrib/example_dags/example_kubernetes_operator.py
 ##########
 @@ -63,6 +99,24 @@
             tolerations=tolerations
         )
 
+        start_pod = KubernetesPodYamlOperator(
 
 Review comment:
   I am afraid that it will be very problematic to combine these two ways of defining pods. All we can do is say that the selected parameters are mutually exclusive.  However, it will be very difficult for the user to understand if which parameters work with each other and which do not work.  A similar case is in the configuration of the worker, where when configuring the template it is said that all other fields are ignored.  However, In this case, we will ignore all parameters, but a very long list of parameters that will be difficult to use.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services