You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "dohongdayi (Jira)" <ji...@apache.org> on 2021/10/21 02:28:00 UTC
[jira] [Issue Comment Deleted] (SPARK-37016) Publicise
UpperCaseCharStream
[ https://issues.apache.org/jira/browse/SPARK-37016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dohongdayi updated SPARK-37016:
-------------------------------
Comment: was deleted
(was: I have submitted a PR
[https://github.com/apache/spark/pull/34290|https://github.com/apache/spark/pull/34290])
> Publicise UpperCaseCharStream
> -----------------------------
>
> Key: SPARK-37016
> URL: https://issues.apache.org/jira/browse/SPARK-37016
> Project: Spark
> Issue Type: Improvement
> Components: SQL
> Affects Versions: 2.2.3, 2.3.4, 2.4.8, 3.0.3, 3.1.1, 3.1.2, 3.2.0
> Reporter: dohongdayi
> Priority: Major
>
> Many Spark extension projects are copying `UpperCaseCharStream` because it is private beneath `parser` package, such as:
> [Delta Lake|https://github.com/delta-io/delta/blob/625de3b305f109441ad04b20dba91dd6c4e1d78e/core/src/main/scala/io/delta/sql/parser/DeltaSqlParser.scala#L290]
> [Hudi|https://github.com/apache/hudi/blob/3f8ca1a3552bb866163d3b1648f68d9c4824e21d/hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/parser/HoodieCommonSqlParser.scala#L112]
> [Iceberg|https://github.com/apache/iceberg/blob/c3ac4c6ca74a0013b4705d5bd5d17fade8e6f499/spark3-extensions/src/main/scala/org/apache/spark/sql/catalyst/parser/extensions/IcebergSparkSqlExtensionsParser.scala#L175]
> [Submarine|https://github.com/apache/submarine/blob/2faebb8efd69833853f62d89b4f1fea1b1718148/submarine-security/spark-security/src/main/scala/org/apache/submarine/spark/security/parser/UpperCaseCharStream.scala#L31]
> [Kyuubi|https://github.com/apache/incubator-kyuubi/blob/8a5134e3223844714fc58833a6859d4df5b68d57/dev/kyuubi-extension-spark-common/src/main/scala/org/apache/kyuubi/sql/zorder/ZorderSparkSqlExtensionsParserBase.scala#L108]
> [Spark-ACID|https://github.com/qubole/spark-acid/blob/19bd6db757677c40f448e85c74d9995ba97d5942/src/main/scala/com/qubole/spark/datasources/hiveacid/sql/catalyst/parser/ParseDriver.scala#L13]
> We can publicise `UpperCaseCharStream` to eliminate code duplication.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org