You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by sesuncedu <gi...@git.apache.org> on 2017/06/19 00:02:41 UTC
[GitHub] commons-compress pull request #37: COMPRESS-410 - cherry picked to fix mergi...
GitHub user sesuncedu opened a pull request:
https://github.com/apache/commons-compress/pull/37
COMPRESS-410 - cherry picked to fix merging issues
Remove non-NIO character set encoders.
Fixes rebasing related issues in previous PR
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sesuncedu/commons-compress COMPRESS-410-REDUX
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-compress/pull/37.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #37
----
commit 5a7ecf1a52d078cf005082c22d302ee9dcc2faf0
Author: Simon Spero <se...@gmail.com>
Date: 2017-06-17T00:17:13Z
COMPRESS-410 Remove Non-NIO character set encoders.
As a special case, the UTF-8 encoder will replace malformed / unmappable input with '?'.
This behavior is required for compatibility with existing behavior.
Signed-off-by: Simon Spero <se...@gmail.com>
(cherry picked from commit 0d41ac4)
Signed-off-by: Simon Spero <se...@gmail.com>
commit 8125dccb36792fdcc83c7359d13ecade39852562
Author: Simon Spero <se...@gmail.com>
Date: 2017-06-17T16:45:44Z
javadoc for HasCharset
Signed-off-by: Simon Spero <se...@gmail.com>
(cherry picked from commit b70c7c2)
Signed-off-by: Simon Spero <se...@gmail.com>
commit cf3fa1ecd677b0d405e6018b91aa13f90ecb3b7c
Author: Simon Spero <se...@gmail.com>
Date: 2017-06-17T00:17:13Z
COMPRESS-410 Remove Non-NIO character set encoders.
As a special case, the UTF-8 encoder will replace malformed / unmappable input with '?'.
This behavior is required for compatibility with existing behavior.
Signed-off-by: Simon Spero <se...@gmail.com>
(cherry picked from commit 1987719)
Signed-off-by: Simon Spero <se...@gmail.com>
commit fb52100291ed3f69581f6a6dc5062a07e6d52ae8
Author: Simon Spero <se...@gmail.com>
Date: 2017-06-18T22:55:38Z
Do better estimating of required buffer size for character encoding. If an unencodable character is found that requires output buffer expansion, scan buffer for all such characters, and attempt to expand buffer only once.
Signed-off-by: Simon Spero <se...@gmail.com>
(cherry picked from commit aa30e21)
Signed-off-by: Simon Spero <se...@gmail.com>
commit 9f76e86f71d36897895e1e5f49b522d12602f3cc
Author: Simon Spero <se...@gmail.com>
Date: 2017-06-15T18:27:48Z
Redoing more buffer stuff
Signed-off-by: Simon Spero <se...@gmail.com>
(cherry picked from commit 330c8b3)
Signed-off-by: Simon Spero <se...@gmail.com>
commit b92044a5fe95a8b6901040ee8b4c698c0a650e7d
Author: Simon Spero <se...@gmail.com>
Date: 2017-06-18T23:27:42Z
Test that ebcidic encoding is supported (making sure "%Uxxxx" replacement strings don't use ascii encodings)
Signed-off-by: Simon Spero <se...@gmail.com>
(cherry picked from commit f1ec715)
Signed-off-by: Simon Spero <se...@gmail.com>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-compress pull request #37: COMPRESS-410 - cherry picked to fix mergi...
Posted by sesuncedu <gi...@git.apache.org>.
Github user sesuncedu closed the pull request at:
https://github.com/apache/commons-compress/pull/37
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-compress issue #37: COMPRESS-410 - cherry picked to fix merging issu...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-compress/pull/37
[](https://:/builds/12024033)
Coverage decreased (-0.08%) to 84.652% when pulling **7e01241512f3f4059fa8d909bf7f98379ef4f373 on sesuncedu:COMPRESS-410-REDUX** into **4be9979b45ceadc50dc24607884d34613fead1f5 on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-compress pull request #37: COMPRESS-410 - cherry picked to fix mergi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/commons-compress/pull/37
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-compress issue #37: COMPRESS-410 - cherry picked to fix merging issu...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-compress/pull/37
[](https://:/builds/12055314)
Coverage increased (+0.04%) to 84.77% when pulling **922051d1f2250256697a1b042f1f319b2950fc45 on sesuncedu:COMPRESS-410-REDUX** into **4be9979b45ceadc50dc24607884d34613fead1f5 on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-compress pull request #37: COMPRESS-410 - cherry picked to fix mergi...
Posted by sesuncedu <gi...@git.apache.org>.
GitHub user sesuncedu reopened a pull request:
https://github.com/apache/commons-compress/pull/37
COMPRESS-410 - cherry picked to fix merging issues
Remove non-NIO character set encoders.
Fixes rebasing related issues in previous PR
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sesuncedu/commons-compress COMPRESS-410-REDUX
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-compress/pull/37.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #37
----
commit 5a7ecf1a52d078cf005082c22d302ee9dcc2faf0
Author: Simon Spero <se...@gmail.com>
Date: 2017-06-17T00:17:13Z
COMPRESS-410 Remove Non-NIO character set encoders.
As a special case, the UTF-8 encoder will replace malformed / unmappable input with '?'.
This behavior is required for compatibility with existing behavior.
Signed-off-by: Simon Spero <se...@gmail.com>
(cherry picked from commit 0d41ac4)
Signed-off-by: Simon Spero <se...@gmail.com>
commit 8125dccb36792fdcc83c7359d13ecade39852562
Author: Simon Spero <se...@gmail.com>
Date: 2017-06-17T16:45:44Z
javadoc for HasCharset
Signed-off-by: Simon Spero <se...@gmail.com>
(cherry picked from commit b70c7c2)
Signed-off-by: Simon Spero <se...@gmail.com>
commit cf3fa1ecd677b0d405e6018b91aa13f90ecb3b7c
Author: Simon Spero <se...@gmail.com>
Date: 2017-06-17T00:17:13Z
COMPRESS-410 Remove Non-NIO character set encoders.
As a special case, the UTF-8 encoder will replace malformed / unmappable input with '?'.
This behavior is required for compatibility with existing behavior.
Signed-off-by: Simon Spero <se...@gmail.com>
(cherry picked from commit 1987719)
Signed-off-by: Simon Spero <se...@gmail.com>
commit fb52100291ed3f69581f6a6dc5062a07e6d52ae8
Author: Simon Spero <se...@gmail.com>
Date: 2017-06-18T22:55:38Z
Do better estimating of required buffer size for character encoding. If an unencodable character is found that requires output buffer expansion, scan buffer for all such characters, and attempt to expand buffer only once.
Signed-off-by: Simon Spero <se...@gmail.com>
(cherry picked from commit aa30e21)
Signed-off-by: Simon Spero <se...@gmail.com>
commit 9f76e86f71d36897895e1e5f49b522d12602f3cc
Author: Simon Spero <se...@gmail.com>
Date: 2017-06-15T18:27:48Z
Redoing more buffer stuff
Signed-off-by: Simon Spero <se...@gmail.com>
(cherry picked from commit 330c8b3)
Signed-off-by: Simon Spero <se...@gmail.com>
commit b92044a5fe95a8b6901040ee8b4c698c0a650e7d
Author: Simon Spero <se...@gmail.com>
Date: 2017-06-18T23:27:42Z
Test that ebcidic encoding is supported (making sure "%Uxxxx" replacement strings don't use ascii encodings)
Signed-off-by: Simon Spero <se...@gmail.com>
(cherry picked from commit f1ec715)
Signed-off-by: Simon Spero <se...@gmail.com>
commit ae1e7b07f0e9483c07d33cf49862660cca3da81e
Author: Simon Spero <se...@gmail.com>
Date: 2017-06-19T00:04:35Z
Add licence comment to HasCharset
Signed-off-by: Simon Spero <se...@gmail.com>
commit 7e01241512f3f4059fa8d909bf7f98379ef4f373
Author: Simon Spero <se...@gmail.com>
Date: 2017-06-19T00:10:46Z
Resurrected HasCharset in the wrong place (not beyond the grave).
Signed-off-by: Simon Spero <se...@gmail.com>
commit 922051d1f2250256697a1b042f1f319b2950fc45
Author: Simon Spero <se...@gmail.com>
Date: 2017-06-19T10:07:02Z
Remove methods and change test + throw to assert to please the coveralls
Signed-off-by: Simon Spero <se...@gmail.com>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-compress issue #37: COMPRESS-410 - cherry picked to fix merging issu...
Posted by sesuncedu <gi...@git.apache.org>.
Github user sesuncedu commented on the issue:
https://github.com/apache/commons-compress/pull/37
There seems to be something amiss with Hudson (it can't checkout origin/master ... )
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-compress issue #37: COMPRESS-410 - cherry picked to fix merging issu...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-compress/pull/37
[](https://:/builds/12027861)
Coverage increased (+0.04%) to 84.77% when pulling **922051d1f2250256697a1b042f1f319b2950fc45 on sesuncedu:COMPRESS-410-REDUX** into **4be9979b45ceadc50dc24607884d34613fead1f5 on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-compress issue #37: COMPRESS-410 - cherry picked to fix merging issu...
Posted by bodewig <gi...@git.apache.org>.
Github user bodewig commented on the issue:
https://github.com/apache/commons-compress/pull/37
Thanks a lot Simon,
Please take a look at fde6670 - I've only performed some minor changes that I didn't feel like hackling you for. Things that may be a tiny bit more than just cosmetics:
* I'm not sure why you went for the literal string `UTF-8` rather than the constant and `isUTF8` method in `ZipEncodingHelper`, I've changed that (kinda) back
* I've removed the `assert` from `NioZipEncoding.encode`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---