You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/17 06:35:26 UTC
[GitHub] [doris] xinyiZzz opened a new pull request, #10936: [Enhancement] [Memory] add strict memory usage compile option STRICT_MEMORY_USE
xinyiZzz opened a new pull request, #10936:
URL: https://github.com/apache/doris/pull/10936
# Proposed changes
Issue Number: close #10935
## Problem Summary:
### Solution
In the strict memory usage mode of `STRICT_MEMORY_USE=ON`, when the capacity of the vectorized Hash Table is greater than 2G, it starts to grow when 75% of the capacity is satisfied.
STRICT_MEMORY_USE=ON` expects BE to use less memory, and gives priority to ensuring stability when the cluster memory is limited.
### Future
In the future, expect a dynamic soft memory limit, combined with real-time memory usage of the cluster, to control the main memory consumers, including HashTable, LRU Cache elimination strategy, ChunkAllocator cache strategy, Disk IO buffer cache strategy, etc.
### Motivation
Currently, the vectorized Hash Table starts to grow when it is half full. This is good for performance, but will use more memory.
Compared with performance, some production environments are more sensitive to stability. When the cluster memory is insufficient, it is hoped to sacrifice performance to ensure stability.
## Checklist(Required)
1. Does it affect the original behavior: (No)
2. Has unit tests been added: (No)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (No)
5. Are there any changes that cannot be rolled back: (No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #10936: [Enhancement] [Memory] add strict memory usage compile option STRICT_MEMORY_USE
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #10936:
URL: https://github.com/apache/doris/pull/10936
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on a diff in pull request #10936: [Enhancement] [Memory] add strict memory usage compile option STRICT_MEMORY_USE
Posted by GitBox <gi...@apache.org>.
yiguolei commented on code in PR #10936:
URL: https://github.com/apache/doris/pull/10936#discussion_r923074788
##########
be/src/vec/common/hash_table/hash_table.h:
##########
@@ -244,11 +244,22 @@ template <size_t initial_size_degree = 10>
struct HashTableGrower {
/// The state of this structure is enough to get the buffer size of the hash table.
doris::vectorized::UInt8 size_degree = initial_size_degree;
+ doris::vectorized::Int64 double_grow_degree = 31; // 2GB
Review Comment:
const expr here
and DOUBLE_GROW_DEGREE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10936: [Enhancement] [Memory] add strict memory usage compile option STRICT_MEMORY_USE
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10936:
URL: https://github.com/apache/doris/pull/10936#issuecomment-1186896746
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10936: [Enhancement] [Memory] add strict memory usage compile option STRICT_MEMORY_USE
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10936:
URL: https://github.com/apache/doris/pull/10936#issuecomment-1186896706
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org