You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commons-dev@ws.apache.org by gd...@apache.org on 2007/03/15 23:28:16 UTC

svn commit: r518787 - in /webservices/commons/trunk/modules/axiom/modules: axiom-api/src/main/java/org/apache/axiom/om/ axiom-api/src/main/java/org/apache/axiom/om/impl/builder/ axiom-api/src/main/java/org/apache/axiom/om/impl/traverse/ axiom-api/src/m...

Author: gdaniels
Date: Thu Mar 15 15:28:14 2007
New Revision: 518787

URL: http://svn.apache.org/viewvc?view=rev&rev=518787
Log:
* Fix incorrect use of equalsIgnoreCase() - XML is case sensitive.  Fix incorrect test ("body" instead of "Body")

* Remove unnecessary public/abstract modifiers from interfaces

* Use same trick for DOOM as for LLOM in SOAPEnvelope.getHeader() - now it won't walk the whole tree, assuming instead that if the first child isn't the header, it ain't there.  This should allow us to remove MessageContext.isHeaderPresent() in Axis2.

Modified:
    webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMAttribute.java
    webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMComment.java
    webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMConstants.java
    webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMContainer.java
    webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMDataSource.java
    webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMDocType.java
    webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMDocument.java
    webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMElement.java
    webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMFactory.java
    webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMNamespace.java
    webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMNode.java
    webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMProcessingInstruction.java
    webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/impl/builder/XOPBuilder.java
    webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/impl/traverse/OMChildrenQNameIterator.java
    webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPBody.java
    webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPConstants.java
    webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPEnvelope.java
    webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPFactory.java
    webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPFault.java
    webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPFaultCode.java
    webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPFaultDetail.java
    webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPFaultNode.java
    webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPFaultReason.java
    webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPFaultRole.java
    webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPFaultSubCode.java
    webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPFaultText.java
    webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPHeader.java
    webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPMessage.java
    webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPVersion.java
    webservices/commons/trunk/modules/axiom/modules/axiom-dom/src/main/java/org/apache/axiom/soap/impl/dom/SOAPEnvelopeImpl.java
    webservices/commons/trunk/modules/axiom/modules/axiom-impl/src/main/java/org/apache/axiom/soap/impl/llom/SOAPEnvelopeImpl.java
    webservices/commons/trunk/modules/axiom/modules/axiom-impl/src/main/java/org/apache/axiom/soap/impl/llom/SOAPHeaderImpl.java
    webservices/commons/trunk/modules/axiom/modules/axiom-tests/src/test/java/org/apache/axiom/om/IteratorTest.java

Modified: webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMAttribute.java
URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMAttribute.java?view=diff&rev=518787&r1=518786&r2=518787
==============================================================================
--- webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMAttribute.java (original)
+++ webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMAttribute.java Thu Mar 15 15:28:14 2007
@@ -21,26 +21,26 @@
 /** Interface OMAttribute */
 public interface OMAttribute {
     /** @return Returns localName. */
-    public String getLocalName();
+    String getLocalName();
 
     /** @param localName  */
-    public void setLocalName(String localName);
+    void setLocalName(String localName);
 
     /** @return Returns String. */
-    public String getAttributeValue();
+    String getAttributeValue();
 
     /** @param value  */
-    public void setAttributeValue(String value);
+    void setAttributeValue(String value);
 
     /** @param omNamespace  */
-    public void setOMNamespace(OMNamespace omNamespace);
+    void setOMNamespace(OMNamespace omNamespace);
 
     /** @return Returns OMNamespace. */
-    public OMNamespace getNamespace();
+    OMNamespace getNamespace();
 
     /** @return Returns javax.xml.namespace.QName */
-    public QName getQName();
+    QName getQName();
 
     /** Returns the OMFactory that created this object */
-    public OMFactory getOMFactory();
+    OMFactory getOMFactory();
 }

Modified: webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMComment.java
URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMComment.java?view=diff&rev=518787&r1=518786&r2=518787
==============================================================================
--- webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMComment.java (original)
+++ webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMComment.java Thu Mar 15 15:28:14 2007
@@ -23,12 +23,12 @@
      *
      * @return Returns String.
      */
-    public String getValue();
+    String getValue();
 
     /**
      * Sets the content of this comment to the specified string.
      *
      * @param text
      */
-    public void setValue(String text);
+    void setValue(String text);
 }

Modified: webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMConstants.java
URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMConstants.java?view=diff&rev=518787&r1=518786&r2=518787
==============================================================================
--- webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMConstants.java (original)
+++ webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMConstants.java Thu Mar 15 15:28:14 2007
@@ -21,44 +21,44 @@
 
     // OMBuilder constants
     /** Field PUSH_TYPE_BUILDER */
-    public static final short PUSH_TYPE_BUILDER = 0;
+    static final short PUSH_TYPE_BUILDER = 0;
 
     /** Field PULL_TYPE_BUILDER */
-    public static final short PULL_TYPE_BUILDER = 1;
+    static final short PULL_TYPE_BUILDER = 1;
 
     /** Field ARRAY_ITEM_NSURI */
-    public static final String ARRAY_ITEM_NSURI =
+    static final String ARRAY_ITEM_NSURI =
             "http://axis.apache.org/encoding/Arrays";
 
     /** Field ARRAY_ITEM_LOCALNAME */
-    public static final String ARRAY_ITEM_LOCALNAME = "item";
+    static final String ARRAY_ITEM_LOCALNAME = "item";
 
     /** Field ARRAY_ITEM_NS_PREFIX */
-    public static final String ARRAY_ITEM_NS_PREFIX = "arrays";
+    static final String ARRAY_ITEM_NS_PREFIX = "arrays";
 
     /** Field ARRAY_ITEM_QNAME */
-    public static final String ARRAY_ITEM_QNAME =
+    static final String ARRAY_ITEM_QNAME =
             OMConstants.ARRAY_ITEM_NS_PREFIX + ':'
                     + OMConstants.ARRAY_ITEM_LOCALNAME;
 
     /** Field DEFAULT_CHAR_SET_ENCODING specifies the default character encoding scheme to be used */
-    public static final String DEFAULT_CHAR_SET_ENCODING = "utf-8";
-    public static final String DEFAULT_XML_VERSION = "1.0";
+    static final String DEFAULT_CHAR_SET_ENCODING = "utf-8";
+    static final String DEFAULT_XML_VERSION = "1.0";
 
 
-    public static final String XMLNS_URI =
+    static final String XMLNS_URI =
             "http://www.w3.org/XML/1998/namespace";
 
-    public static final String XMLNS_NS_URI = "http://www.w3.org/2000/xmlns/";
-    public final static String XMLNS_NS_PREFIX = "xmlns";
+    static final String XMLNS_NS_URI = "http://www.w3.org/2000/xmlns/";
+    final static String XMLNS_NS_PREFIX = "xmlns";
 
-    public static final String XMLNS_PREFIX =
+    static final String XMLNS_PREFIX =
             "xml";
     String IS_BINARY = "Axiom.IsBinary";
     String DATA_HANDLER = "Axiom.DataHandler";
     String IS_DATA_HANDLERS_AWARE = "IsDatahandlersAwareParsing";
 
     /** No its not a mistake. This is the default nsURI of the default namespace of a node */
-    public static final String DEFAULT_DEFAULT_NAMESPACE = "\"\"";
+    static final String DEFAULT_DEFAULT_NAMESPACE = "\"\"";
 
 }

Modified: webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMContainer.java
URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMContainer.java?view=diff&rev=518787&r1=518786&r2=518787
==============================================================================
--- webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMContainer.java (original)
+++ webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMContainer.java Thu Mar 15 15:28:14 2007
@@ -32,7 +32,7 @@
      *
      * @param omNode
      */
-    public void addChild(OMNode omNode);
+    void addChild(OMNode omNode);
 
     /**
      * Returns an iterator for child nodes matching the criteria indicated by the given QName.
@@ -52,7 +52,7 @@
      * @return Returns an iterator of {@link OMElement} items that match the given QName
      *         appropriately.
      */
-    public Iterator getChildrenWithName(QName elementQName);
+    Iterator getChildrenWithName(QName elementQName);
 
     /**
      * Returns the first child in document order that matches the given QName criteria.
@@ -65,7 +65,7 @@
      * @throws OMException Could indirectly trigger building of child nodes.
      * @see #getChildrenWithName
      */
-    public OMElement getFirstChildWithName(QName elementQName) throws OMException;
+    OMElement getFirstChildWithName(QName elementQName) throws OMException;
 
     /**
      * Returns an iterator for the children of the container.
@@ -74,16 +74,16 @@
      * @see #getFirstChildWithName
      * @see #getChildrenWithName
      */
-    public Iterator getChildren();
+    Iterator getChildren();
 
     /**
      * Gets the first child.
      *
      * @return Returns the first child.  May return null if the container has no children.
      */
-    public OMNode getFirstOMChild();
+    OMNode getFirstOMChild();
 
-    public boolean isComplete();
+    boolean isComplete();
 
-    public void buildNext();
+    void buildNext();
 }

Modified: webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMDataSource.java
URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMDataSource.java?view=diff&rev=518787&r1=518786&r2=518787
==============================================================================
--- webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMDataSource.java (original)
+++ webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMDataSource.java Thu Mar 15 15:28:14 2007
@@ -22,7 +22,7 @@
      *               supported by data binding even if supplied)
      * @throws XMLStreamException
      */
-    public void serialize(OutputStream output, OMOutputFormat format)
+    void serialize(OutputStream output, OMOutputFormat format)
             throws XMLStreamException;
 
     /**
@@ -33,7 +33,7 @@
      *               supported by data binding even if supplied)
      * @throws XMLStreamException
      */
-    public void serialize(Writer writer, OMOutputFormat format)
+    void serialize(Writer writer, OMOutputFormat format)
             throws XMLStreamException;
 
     /**
@@ -42,7 +42,7 @@
      * @param xmlWriter destination writer
      * @throws XMLStreamException
      */
-    public void serialize(XMLStreamWriter xmlWriter)
+    void serialize(XMLStreamWriter xmlWriter)
             throws XMLStreamException;
 
     /**
@@ -52,5 +52,5 @@
      * @return element parser
      * @throws XMLStreamException
      */
-    public XMLStreamReader getReader() throws XMLStreamException;
+    XMLStreamReader getReader() throws XMLStreamException;
 }

Modified: webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMDocType.java
URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMDocType.java?view=diff&rev=518787&r1=518786&r2=518787
==============================================================================
--- webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMDocType.java (original)
+++ webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMDocType.java Thu Mar 15 15:28:14 2007
@@ -23,12 +23,12 @@
      *
      * @return Returns String.
      */
-    public String getValue();
+    String getValue();
 
     /**
      * Sets the content of this DocType to the specified string.
      *
      * @param text
      */
-    public void setValue(String text);
+    void setValue(String text);
 }

Modified: webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMDocument.java
URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMDocument.java?view=diff&rev=518787&r1=518786&r2=518787
==============================================================================
--- webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMDocument.java (original)
+++ webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMDocument.java Thu Mar 15 15:28:14 2007
@@ -23,31 +23,31 @@
 public interface OMDocument extends OMContainer {
 
     /** Field XML_10 XML Version 1.0 */
-    public final static String XML_10 = "1.0";
+    final static String XML_10 = "1.0";
 
     /** Field XML_11 XML Version 1.1 */
-    public final static String XML_11 = "1.1";
+    final static String XML_11 = "1.1";
 
     /**
      * Returns the document element.
      *
      * @return Returns OMElement.
      */
-    public OMElement getOMDocumentElement();
+    OMElement getOMDocumentElement();
 
     /**
      * Sets the document element of the XML document.
      *
      * @param rootElement
      */
-    public void setOMDocumentElement(OMElement rootElement);
+    void setOMDocumentElement(OMElement rootElement);
 
     /**
      * Returns the XML version.
      *
      * @return Returns String.
      */
-    public String getXMLVersion();
+    String getXMLVersion();
 
     /**
      * Sets the XML version.
@@ -56,30 +56,30 @@
      * @see org.apache.axiom.om.impl.llom.OMDocumentImpl#XML_10 XML 1.0
      * @see org.apache.axiom.om.impl.llom.OMDocumentImpl#XML_11 XML 1.1
      */
-    public void setXMLVersion(String version);
+    void setXMLVersion(String version);
 
     /**
      * Returns the character set encoding scheme.
      *
      * @return Returns String.
      */
-    public String getCharsetEncoding();
+    String getCharsetEncoding();
 
     /**
      * Sets the character set encoding scheme to be used.
      *
      * @param charsetEncoding
      */
-    public void setCharsetEncoding(String charsetEncoding);
+    void setCharsetEncoding(String charsetEncoding);
 
     /**
      * XML standalone value. This will be yes, no or null (if not available)
      *
      * @return Returns boolean.
      */
-    public String isStandalone();
+    String isStandalone();
 
-    public void setStandalone(String isStandalone);
+    void setStandalone(String isStandalone);
 
     /**
      * Serializes the OMDocument.
@@ -88,7 +88,7 @@
      * @param format
      * @throws XMLStreamException
      */
-    public void serializeAndConsume(OutputStream output, OMOutputFormat format)
+    void serializeAndConsume(OutputStream output, OMOutputFormat format)
             throws XMLStreamException;
 
     /**
@@ -98,7 +98,7 @@
      * @param format
      * @throws XMLStreamException
      */
-    public void serialize(OutputStream output, OMOutputFormat format) throws XMLStreamException;
+    void serialize(OutputStream output, OMOutputFormat format) throws XMLStreamException;
 
     /**
      * Serializes the OMDocument.
@@ -106,7 +106,7 @@
      * @param output
      * @throws XMLStreamException
      */
-    public void serializeAndConsume(OutputStream output) throws XMLStreamException;
+    void serializeAndConsume(OutputStream output) throws XMLStreamException;
 
     /**
      * Serializes the document with cache on.
@@ -114,9 +114,9 @@
      * @param output
      * @throws XMLStreamException
      */
-    public void serialize(OutputStream output) throws XMLStreamException;
+    void serialize(OutputStream output) throws XMLStreamException;
 
     /** Returns the OMFactory that created this object */
-    public OMFactory getOMFactory();
+    OMFactory getOMFactory();
 
 }

Modified: webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMElement.java
URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMElement.java?view=diff&rev=518787&r1=518786&r2=518787
==============================================================================
--- webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMElement.java (original)
+++ webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMElement.java Thu Mar 15 15:28:14 2007
@@ -36,7 +36,7 @@
      * @see #getChildren()
      * @see #getChildrenWithName(javax.xml.namespace.QName)
      */
-    public Iterator getChildElements();
+    Iterator getChildElements();
 
     /**
      * Creates a namespace in the current element scope.
@@ -52,7 +52,7 @@
      * @see #findNamespace(String, String)
      * @see #getAllDeclaredNamespaces()
      */
-    public OMNamespace declareNamespace(String uri, String prefix);
+    OMNamespace declareNamespace(String uri, String prefix);
 
 
     /**
@@ -60,13 +60,13 @@
      *
      * @param uri
      */
-    public OMNamespace declareDefaultNamespace(String uri);
+    OMNamespace declareDefaultNamespace(String uri);
 
     /**
      * This will retrieve the default namespace of this element, if available. null returned if none
      * is found.
      */
-    public OMNamespace getDefaultNamespace();
+    OMNamespace getDefaultNamespace();
 
     /**
      * Declares a namespace with the element as its scope.
@@ -77,7 +77,7 @@
      * @see #findNamespace(String, String)
      * @see #getAllDeclaredNamespaces()
      */
-    public OMNamespace declareNamespace(OMNamespace namespace);
+    OMNamespace declareNamespace(OMNamespace namespace);
 
     /**
      * Finds a namespace with the given uri and prefix, in the scope of the hierarchy.
@@ -96,7 +96,7 @@
      * @see #declareNamespace(OMNamespace)
      * @see #getAllDeclaredNamespaces()
      */
-    public OMNamespace findNamespace(String uri, String prefix);
+    OMNamespace findNamespace(String uri, String prefix);
 
     /**
      * Checks for a namespace in the context of this element with the given prefix and returns the
@@ -104,7 +104,7 @@
      *
      * @param prefix
      */
-    public OMNamespace findNamespaceURI(String prefix);
+    OMNamespace findNamespaceURI(String prefix);
 
     /**
      * Returns an iterator for all of the namespaces declared on this element.
@@ -119,7 +119,7 @@
      * @see #declareNamespace(String, String)
      * @see #declareNamespace(OMNamespace)
      */
-    public Iterator getAllDeclaredNamespaces() throws OMException;
+    Iterator getAllDeclaredNamespaces() throws OMException;
 
     /**
      * Returns a list of OMAttributes.
@@ -133,7 +133,7 @@
      * @see #addAttribute(OMAttribute)
      * @see #addAttribute(String, String, OMNamespace)
      */
-    public Iterator getAllAttributes();
+    Iterator getAllAttributes();
 
     /**
      * Returns a named attribute if present.
@@ -141,7 +141,7 @@
      * @param qname the qualified name to search for
      * @return Returns an OMAttribute with the given name if found, or null
      */
-    public OMAttribute getAttribute(QName qname);
+    OMAttribute getAttribute(QName qname);
 
     /**
      * Returns a named attribute's value, if present.
@@ -149,7 +149,7 @@
      * @param qname the qualified name to search for
      * @return Returns a String containing the attribute value, or null
      */
-    public String getAttributeValue(QName qname);
+    String getAttributeValue(QName qname);
 
     /**
      * Adds an attribute to this element.
@@ -159,7 +159,7 @@
      * @param attr The attribute to add.
      * @return Returns the passed in attribute.
      */
-    public OMAttribute addAttribute(OMAttribute attr);
+    OMAttribute addAttribute(OMAttribute attr);
 
     /**
      * Adds an attribute to the current element.
@@ -175,7 +175,7 @@
      *                      ancestors of the parent element of the attribute.
      * @return Returns the added attribute.
      */
-    public OMAttribute addAttribute(String attributeName, String value,
+    OMAttribute addAttribute(String attributeName, String value,
                                     OMNamespace ns);
 
     /**
@@ -183,21 +183,21 @@
      *
      * @param attr
      */
-    public void removeAttribute(OMAttribute attr);
+    void removeAttribute(OMAttribute attr);
 
     /**
      * Method setBuilder.
      *
      * @param wrapper
      */
-    public void setBuilder(OMXMLParserWrapper wrapper);
+    void setBuilder(OMXMLParserWrapper wrapper);
 
     /**
      * Returns the builder object.
      *
      * @return Returns the builder object used to construct the underlying XML infoset on the fly.
      */
-    public OMXMLParserWrapper getBuilder();
+    OMXMLParserWrapper getBuilder();
 
     /**
      * Sets the first child.
@@ -207,7 +207,7 @@
      *             the first child, all the links handling will not happen inside this method. So we
      *             have moved this method to the less visible interface, OMContainerEx.
      */
-    public void setFirstChild(OMNode node);
+    void setFirstChild(OMNode node);
 
     /**
      * Returns the first child element of the element.
@@ -215,7 +215,7 @@
      * @return Returns the first child element of the element, or <tt>null</tt> if none was found.
      */
 
-    public OMElement getFirstElement();
+    OMElement getFirstElement();
 
 
     /**
@@ -225,7 +225,7 @@
      *
      * @return Returns an XMLStreamReader relative to this element.
      */
-    public XMLStreamReader getXMLStreamReader();
+    XMLStreamReader getXMLStreamReader();
 
     /**
      * Returns the pull parser that will generate the pull events relevant to THIS element.
@@ -234,42 +234,42 @@
      *
      * @return Returns an XMLStreamReader relative to this element, with no caching.
      */
-    public XMLStreamReader getXMLStreamReaderWithoutCaching();
+    XMLStreamReader getXMLStreamReaderWithoutCaching();
 
     /** @param text  */
-    public void setText(String text);
+    void setText(String text);
 
-    public void setText(QName text);
+    void setText(QName text);
 
     /**
      * Returns the non-empty text children as a String.
      *
      * @return Returns a String representing the concatenation of the child text nodes.
      */
-    public String getText();
+    String getText();
 
     /** OMText can contain its information as a QName as well. This will return the text as a QName */
-    public QName getTextAsQName();
+    QName getTextAsQName();
 
     /**
      * Returns the local name of the element.
      *
      * @return Returns the local name of the element.
      */
-    public String getLocalName();
+    String getLocalName();
 
     /**
      * Method setLocalName
      *
      * @param localName
      */
-    public void setLocalName(String localName);
+    void setLocalName(String localName);
 
     /**
      * @return Returns the OMNamespace object associated with this element
      * @throws OMException
      */
-    public OMNamespace getNamespace() throws OMException;
+    OMNamespace getNamespace() throws OMException;
 
     /**
      * Sets the Namespace. This will first search for a namespace in the current scope with the
@@ -278,7 +278,7 @@
      *
      * @param namespace
      */
-    public void setNamespace(OMNamespace namespace);
+    void setNamespace(OMNamespace namespace);
 
     /**
      * This will not search the namespace in the scope nor will declare in the current element, as
@@ -286,7 +286,7 @@
      *
      * @param namespace
      */
-    public void setNamespaceWithNoFindInCurrentScope(OMNamespace namespace);
+    void setNamespaceWithNoFindInCurrentScope(OMNamespace namespace);
 
 
     /**
@@ -294,20 +294,20 @@
      *
      * @return Returns the {@link QName} for the element.
      */
-    public QName getQName();
+    QName getQName();
 
     /**
      * This is a convenience method only. This will basically serialize the given OMElement to a
      * String but will build the OMTree in the memory
      */
-    public String toString();
+    String toString();
 
     /**
      * This is a convenience method only. This basically serializes the given OMElement to a String
      * but will NOT build the OMTree in the memory. So you are at your own risk of losing
      * information.
      */
-    public String toStringWithConsume() throws XMLStreamException;
+    String toStringWithConsume() throws XMLStreamException;
 
 
     /**
@@ -325,9 +325,9 @@
      *
      * @return Returns OMElement.
      */
-    public OMElement cloneOMElement();
+    OMElement cloneOMElement();
 
-    public void setLineNumber(int lineNumber);
+    void setLineNumber(int lineNumber);
 
-    public int getLineNumber();
+    int getLineNumber();
 }

Modified: webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMFactory.java
URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMFactory.java?view=diff&rev=518787&r1=518786&r2=518787
==============================================================================
--- webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMFactory.java (original)
+++ webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMFactory.java Thu Mar 15 15:28:14 2007
@@ -22,18 +22,18 @@
 public interface OMFactory {
 
     /** Creates a new OMDocument. */
-    public OMDocument createOMDocument();
+    OMDocument createOMDocument();
 
-    public OMDocument createOMDocument(OMXMLParserWrapper builder);
+    OMDocument createOMDocument(OMXMLParserWrapper builder);
 
 
     /**
      * @param localName
      * @param ns        - This can be null
      */
-    public OMElement createOMElement(String localName, OMNamespace ns);
+    OMElement createOMElement(String localName, OMNamespace ns);
 
-    public OMElement createOMElement(String localName, OMNamespace ns, OMContainer parent)
+    OMElement createOMElement(String localName, OMNamespace ns, OMContainer parent)
             throws OMException;
 
     /**
@@ -42,7 +42,7 @@
      * @param parent
      * @param builder
      */
-    public OMElement createOMElement(String localName, OMNamespace ns,
+    OMElement createOMElement(String localName, OMNamespace ns,
                                      OMContainer parent,
                                      OMXMLParserWrapper builder);
 
@@ -54,7 +54,7 @@
      * @param localName
      * @param ns
      */
-    public OMElement createOMElement(OMDataSource source, String localName,
+    OMElement createOMElement(OMDataSource source, String localName,
                                      OMNamespace ns);
 
     /**
@@ -68,7 +68,7 @@
      * @param namespacePrefix
      * @return Returns the newly created OMElement.
      */
-    public OMElement createOMElement(String localName,
+    OMElement createOMElement(String localName,
                                      String namespaceURI,
                                      String namespacePrefix);
 
@@ -81,7 +81,7 @@
      * @return Returns the new OMElement.
      * @throws OMException
      */
-    public OMElement createOMElement(QName qname, OMContainer parent)
+    OMElement createOMElement(QName qname, OMContainer parent)
             throws OMException;
 
     /**
@@ -89,20 +89,20 @@
      * @param prefix
      * @return Returns OMNameSpace.
      */
-    public OMNamespace createOMNamespace(String uri, String prefix);
+    OMNamespace createOMNamespace(String uri, String prefix);
 
     /**
      * @param parent
      * @param text
      * @return Returns OMText.
      */
-    public OMText createOMText(OMContainer parent, String text);
+    OMText createOMText(OMContainer parent, String text);
 
     /**
      * @param parent
      * @param text   - This text itself can contain a namespace inside it.
      */
-    public OMText createOMText(OMContainer parent, QName text);
+    OMText createOMText(OMContainer parent, QName text);
 
     /**
      * @param parent
@@ -111,22 +111,22 @@
      *               XMLStreamConstants.CDATA, XMLStreamConstants.SPACE, XMLStreamConstants.ENTITY_REFERENCE
      * @return Returns OMText.
      */
-    public OMText createOMText(OMContainer parent, String text, int type);
+    OMText createOMText(OMContainer parent, String text, int type);
 
-    public OMText createOMText(OMContainer parent, char[] charArary, int type);
+    OMText createOMText(OMContainer parent, char[] charArary, int type);
 
     /**
      * @param parent
      * @param text   - This text itself can contain a namespace inside it.
      * @param type
      */
-    public OMText createOMText(OMContainer parent, QName text, int type);
+    OMText createOMText(OMContainer parent, QName text, int type);
 
     /**
      * @param s
      * @return Returns OMText.
      */
-    public OMText createOMText(String s);
+    OMText createOMText(String s);
 
     /**
      * @param s
@@ -134,19 +134,19 @@
      *             Constants, use either XMLStreamConstants or constants found in OMNode.
      * @return Returns OMText.
      */
-    public OMText createOMText(String s, int type);
+    OMText createOMText(String s, int type);
 
-    public OMText createOMText(String s, String mimeType, boolean optimize);
+    OMText createOMText(String s, String mimeType, boolean optimize);
 
-    public OMText createOMText(Object dataHandler, boolean optimize);
+    OMText createOMText(Object dataHandler, boolean optimize);
 
-    public OMText createOMText(OMContainer parent, String s, String mimeType,
+    OMText createOMText(OMContainer parent, String s, String mimeType,
                                boolean optimize);
 
-    public OMText createOMText(String contentID, OMContainer parent,
+    OMText createOMText(String contentID, OMContainer parent,
                                OMXMLParserWrapper builder);
 
-    public OMAttribute createOMAttribute(String localName,
+    OMAttribute createOMAttribute(String localName,
                                          OMNamespace ns,
                                          String value);
 
@@ -157,7 +157,7 @@
      * @param content
      * @return Returns doctype.
      */
-    public OMDocType createOMDocType(OMContainer parent, String content);
+    OMDocType createOMDocType(OMContainer parent, String content);
 
     /**
      * Creates a PI.
@@ -167,7 +167,7 @@
      * @param piData
      * @return Returns OMProcessingInstruction.
      */
-    public OMProcessingInstruction createOMProcessingInstruction(OMContainer parent,
+    OMProcessingInstruction createOMProcessingInstruction(OMContainer parent,
                                                                  String piTarget, String piData);
 
     /**
@@ -177,5 +177,5 @@
      * @param content
      * @return Returns OMComment.
      */
-    public OMComment createOMComment(OMContainer parent, String content);
+    OMComment createOMComment(OMContainer parent, String content);
 }

Modified: webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMNamespace.java
URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMNamespace.java?view=diff&rev=518787&r1=518786&r2=518787
==============================================================================
--- webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMNamespace.java (original)
+++ webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMNamespace.java Thu Mar 15 15:28:14 2007
@@ -25,14 +25,14 @@
      * @param prefix
      * @return Returns boolean.
      */
-    public boolean equals(String uri, String prefix);
+    boolean equals(String uri, String prefix);
 
     /**
      * Method getPrefix.
      *
      * @return Returns String.
      */
-    public String getPrefix();
+    String getPrefix();
 
     /**
      * Method getName.
@@ -40,12 +40,12 @@
      * @return Returns String.
      * @deprecated This method is deprecated. Please use getNamespaceURI() method instead.
      */
-    public String getName();
+    String getName();
 
     /**
      * Provides the namespace URI of this namespace.
      *
      * @return - the namespace URI of the namespace.
      */
-    public String getNamespaceURI();
+    String getNamespaceURI();
 }

Modified: webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMNode.java
URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMNode.java?view=diff&rev=518787&r1=518786&r2=518787
==============================================================================
--- webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMNode.java (original)
+++ webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMNode.java Thu Mar 15 15:28:14 2007
@@ -42,56 +42,56 @@
      *
      * @see #getType()
      */
-    public static final short ELEMENT_NODE = 1;
+    static final short ELEMENT_NODE = 1;
 
     /**
      * The node is a <code>Text</code> node.
      *
      * @see #getType()
      */
-    public static final short TEXT_NODE = XMLStreamConstants.CHARACTERS;
+    static final short TEXT_NODE = XMLStreamConstants.CHARACTERS;
 
     /**
      * The node is a <code>CDATASection</code>.
      *
      * @see #getType()
      */
-    public static final short CDATA_SECTION_NODE = XMLStreamConstants.CDATA;
+    static final short CDATA_SECTION_NODE = XMLStreamConstants.CDATA;
 
     /**
      * The node is a <code>Comment</code>.
      *
      * @see #getType()
      */
-    public static final short COMMENT_NODE = XMLStreamConstants.COMMENT;
+    static final short COMMENT_NODE = XMLStreamConstants.COMMENT;
 
     /**
      * This node is a <code>DTD</code>.
      *
      * @see #getType()
      */
-    public static final short DTD_NODE = XMLStreamConstants.DTD;
+    static final short DTD_NODE = XMLStreamConstants.DTD;
 
     /**
      * This node is a <code>ProcessingInstruction</code>.
      *
      * @see #getType()
      */
-    public static final short PI_NODE = XMLStreamConstants.PROCESSING_INSTRUCTION;
+    static final short PI_NODE = XMLStreamConstants.PROCESSING_INSTRUCTION;
 
     /**
      * This node is an <code>Entity Reference</code>.
      *
      * @see #getType()
      */
-    public static final short ENTITY_REFERENCE_NODE = XMLStreamConstants.ENTITY_REFERENCE;
+    static final short ENTITY_REFERENCE_NODE = XMLStreamConstants.ENTITY_REFERENCE;
 
     /**
      * This node is an <code>Entity Reference</code>.
      *
      * @see #getType()
      */
-    public static final short SPACE_NODE = XMLStreamConstants.SPACE;
+    static final short SPACE_NODE = XMLStreamConstants.SPACE;
 
     /**
      * Returns the parent containing node.
@@ -101,14 +101,14 @@
      *
      * @return The {@link OMContainer} of the node.
      */
-    public OMContainer getParent();
+    OMContainer getParent();
 
     /**
      * Returns the next sibling in document order.
      *
      * @return Returns the next sibling in document order.
      */
-    public OMNode getNextOMSibling() throws OMException;
+    OMNode getNextOMSibling() throws OMException;
 
     /**
      * Indicates whether parser has parsed this information item completely or not. If some info are
@@ -117,7 +117,7 @@
      *
      * @return Returns boolean.
      */
-    public boolean isComplete();
+    boolean isComplete();
 
     /**
      * Removes a node (and all of its children) from its containing parent.
@@ -132,7 +132,7 @@
      * @throws OMException If a node is not complete, the detach can trigger further parsing, which may
      *                     cause an exception.
      */
-    public OMNode detach() throws OMException;
+    OMNode detach() throws OMException;
 
     /**
      * Discards a node.
@@ -143,7 +143,7 @@
      *
      * @throws OMException
      */
-    public void discard() throws OMException;
+    void discard() throws OMException;
 
     /**
      * Inserts a new sibling after the current node.
@@ -151,7 +151,7 @@
      * @param sibling The node that will be added after the current node.
      * @throws OMException
      */
-    public void insertSiblingAfter(OMNode sibling) throws OMException;
+    void insertSiblingAfter(OMNode sibling) throws OMException;
 
     /**
      * Inserts a sibling just before the current node.
@@ -159,7 +159,7 @@
      * @param sibling The node that will be added before the current node.
      * @throws OMException
      */
-    public void insertSiblingBefore(OMNode sibling) throws OMException;
+    void insertSiblingBefore(OMNode sibling) throws OMException;
 
     /**
      * Returns the type of node.
@@ -168,14 +168,14 @@
      *         {@link #COMMENT_NODE}, {@link #DTD_NODE}, {@link #PI_NODE}, {@link
      *         #ENTITY_REFERENCE_NODE}, {@link #SPACE_NODE}, or {@link #TEXT_NODE}.
      */
-    public int getType();
+    int getType();
 
     /**
      * Gets the previous sibling.
      *
      * @return Returns node.
      */
-    public OMNode getPreviousOMSibling();
+    OMNode getPreviousOMSibling();
 
     /**
      * Serializes the node with caching.
@@ -183,7 +183,7 @@
      * @param xmlWriter
      * @throws XMLStreamException
      */
-    public void serialize(XMLStreamWriter xmlWriter) throws XMLStreamException;
+    void serialize(XMLStreamWriter xmlWriter) throws XMLStreamException;
 
     /**
      * Serializes the node with caching.
@@ -191,7 +191,7 @@
      * @param output
      * @throws XMLStreamException
      */
-    public void serialize(OutputStream output) throws XMLStreamException;
+    void serialize(OutputStream output) throws XMLStreamException;
 
     /**
      * Serializes the node with caching.
@@ -199,7 +199,7 @@
      * @param writer
      * @throws XMLStreamException
      */
-    public void serialize(Writer writer) throws XMLStreamException;
+    void serialize(Writer writer) throws XMLStreamException;
 
     /**
      * Serializes the node with caching.
@@ -208,7 +208,7 @@
      * @param format
      * @throws XMLStreamException
      */
-    public void serialize(OutputStream output, OMOutputFormat format)
+    void serialize(OutputStream output, OMOutputFormat format)
             throws XMLStreamException;
 
     /**
@@ -218,7 +218,7 @@
      * @param format
      * @throws XMLStreamException
      */
-    public void serialize(Writer writer, OMOutputFormat format)
+    void serialize(Writer writer, OMOutputFormat format)
             throws XMLStreamException;
 
     /**
@@ -227,7 +227,7 @@
      * @param xmlWriter
      * @throws XMLStreamException
      */
-    public void serializeAndConsume(XMLStreamWriter xmlWriter)
+    void serializeAndConsume(XMLStreamWriter xmlWriter)
             throws XMLStreamException;
 
     /**
@@ -236,7 +236,7 @@
      * @param output
      * @throws XMLStreamException
      */
-    public void serializeAndConsume(OutputStream output)
+    void serializeAndConsume(OutputStream output)
             throws XMLStreamException;
 
     /**
@@ -245,7 +245,7 @@
      * @param writer
      * @throws XMLStreamException
      */
-    public void serializeAndConsume(Writer writer) throws XMLStreamException;
+    void serializeAndConsume(Writer writer) throws XMLStreamException;
 
     /**
      * Serializes the node without caching.
@@ -254,7 +254,7 @@
      * @param format
      * @throws XMLStreamException
      */
-    public void serializeAndConsume(OutputStream output, OMOutputFormat format)
+    void serializeAndConsume(OutputStream output, OMOutputFormat format)
             throws XMLStreamException;
 
     /**
@@ -264,11 +264,11 @@
      * @param format
      * @throws XMLStreamException
      */
-    public void serializeAndConsume(Writer writer, OMOutputFormat format)
+    void serializeAndConsume(Writer writer, OMOutputFormat format)
             throws XMLStreamException;
 
     /** Builds itself. */
-    public void build();
+    void build();
 
     /**
      * Builds itself with the OMText binary content. AXIOM supports two levels of deffered building.
@@ -277,11 +277,11 @@
      * getDataHandler(). build() method builds the OM without the attachments. buildAll() builds the OM
      * together with attachement data. This becomes handy when user wants to free the input stream.
      */
-    public void buildWithAttachments();
+    void buildWithAttachments();
 
     /**
      * Returns the OMFactory that created this object
 	 */
-	public OMFactory getOMFactory();
+	OMFactory getOMFactory();
 
 }

Modified: webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMProcessingInstruction.java
URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMProcessingInstruction.java?view=diff&rev=518787&r1=518786&r2=518787
==============================================================================
--- webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMProcessingInstruction.java (original)
+++ webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMProcessingInstruction.java Thu Mar 15 15:28:14 2007
@@ -23,26 +23,26 @@
      *
      * @param target
      */
-    public void setTarget(String target);
+    void setTarget(String target);
 
     /**
      * Gets the target of this Processing Instruction.
      *
      * @return Returns string.
      */
-    public String getTarget();
+    String getTarget();
 
     /**
      * Sets the value of this Processing Instruction.
      *
      * @param value
      */
-    public void setValue(String value);
+    void setValue(String value);
 
     /**
      * Gets the value of this Processing Instruction.
      *
      * @return Returns String.
      */
-    public String getValue();
+    String getValue();
 }

Modified: webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/impl/builder/XOPBuilder.java
URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/impl/builder/XOPBuilder.java?view=diff&rev=518787&r1=518786&r2=518787
==============================================================================
--- webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/impl/builder/XOPBuilder.java (original)
+++ webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/impl/builder/XOPBuilder.java Thu Mar 15 15:28:14 2007
@@ -6,7 +6,7 @@
 
 public interface XOPBuilder {
 
-    public abstract DataHandler getDataHandler(String blobContentID)
+    DataHandler getDataHandler(String blobContentID)
             throws OMException;
 
 }

Modified: webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/impl/traverse/OMChildrenQNameIterator.java
URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/impl/traverse/OMChildrenQNameIterator.java?view=diff&rev=518787&r1=518786&r2=518787
==============================================================================
--- webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/impl/traverse/OMChildrenQNameIterator.java (original)
+++ webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/impl/traverse/OMChildrenQNameIterator.java Thu Mar 15 15:28:14 2007
@@ -117,8 +117,7 @@
                         ||
                         ((elementQName != null)
                                 &&
-                                elementQName.getLocalPart().equalsIgnoreCase(
-                                        localPart));
+                                elementQName.getLocalPart().equals(localPart));
         String namespaceURI = qNameToBeMatched.getNamespaceURI();
         boolean namespaceURIMatch =
                 (namespaceURI == null)
@@ -126,8 +125,7 @@
                         ||
                         ((elementQName != null)
                                 &&
-                                elementQName.getNamespaceURI().equalsIgnoreCase(
-                                        namespaceURI));
+                                elementQName.getNamespaceURI().equals(namespaceURI));
         return localNameMatch && namespaceURIMatch;
     }
 }

Modified: webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPBody.java
URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPBody.java?view=diff&rev=518787&r1=518786&r2=518787
==============================================================================
--- webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPBody.java (original)
+++ webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPBody.java Thu Mar 15 15:28:14 2007
@@ -39,7 +39,7 @@
      * @throws org.apache.axiom.om.OMException
      *
      */
-    public abstract SOAPFault addFault(Exception e) throws OMException;
+    SOAPFault addFault(Exception e) throws OMException;
 
     /**
      * Indicates whether a <code>SOAPFault</code> object exists in this <code>SOAPBody</code>
@@ -48,20 +48,20 @@
      * @return <code>true</code> if a <code>SOAPFault</code> object exists in this
      *         <code>SOAPBody</code> object; <code>false</code> otherwise
      */
-    public abstract boolean hasFault();
+    boolean hasFault();
 
     /**
      * Returns the <code>SOAPFault</code> object in this <code>SOAPBody</code> object.
      *
      * @return the <code>SOAPFault</code> object in this <code>SOAPBody</code> object
      */
-    public abstract SOAPFault getFault();
+    SOAPFault getFault();
 
     /**
      * @param soapFault
      * @throws OMException
      */
-    public abstract void addFault(SOAPFault soapFault) throws OMException;
+    void addFault(SOAPFault soapFault) throws OMException;
 
 
 }

Modified: webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPConstants.java
URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPConstants.java?view=diff&rev=518787&r1=518786&r2=518787
==============================================================================
--- webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPConstants.java (original)
+++ webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPConstants.java Thu Mar 15 15:28:14 2007
@@ -21,41 +21,41 @@
      * Eran Chinthaka (chinthaka@apache.org)
      */
     /** Field SOAP_DEFAULT_NAMESPACE_PREFIX */
-    public static final String SOAP_DEFAULT_NAMESPACE_PREFIX = "soapenv";
+    static final String SOAP_DEFAULT_NAMESPACE_PREFIX = "soapenv";
     /** Field SOAPENVELOPE_LOCAL_NAME */
-    public static final String SOAPENVELOPE_LOCAL_NAME = "Envelope";
+    static final String SOAPENVELOPE_LOCAL_NAME = "Envelope";
 
     /** Field HEADER_LOCAL_NAME */
-    public static final String HEADER_LOCAL_NAME = "Header";
+    static final String HEADER_LOCAL_NAME = "Header";
 
     /** Field BODY_LOCAL_NAME */
-    public static final String BODY_LOCAL_NAME = "Body";
+    static final String BODY_LOCAL_NAME = "Body";
     /** Field BODY_NAMESPACE_PREFIX */
-    public static final String BODY_NAMESPACE_PREFIX =
+    static final String BODY_NAMESPACE_PREFIX =
             SOAP_DEFAULT_NAMESPACE_PREFIX;
     /** Field BODY_FAULT_LOCAL_NAME */
-    public static final String BODY_FAULT_LOCAL_NAME = "Fault";
+    static final String BODY_FAULT_LOCAL_NAME = "Fault";
 
     /** Field ATTR_MUSTUNDERSTAND */
-    public static final String ATTR_MUSTUNDERSTAND = "mustUnderstand";
-    public static final String ATTR_MUSTUNDERSTAND_TRUE = "true";
-    public static final String ATTR_MUSTUNDERSTAND_FALSE = "false";
-    public static final String ATTR_MUSTUNDERSTAND_0 = "0";
-    public static final String ATTR_MUSTUNDERSTAND_1 = "1";
+    static final String ATTR_MUSTUNDERSTAND = "mustUnderstand";
+    static final String ATTR_MUSTUNDERSTAND_TRUE = "true";
+    static final String ATTR_MUSTUNDERSTAND_FALSE = "false";
+    static final String ATTR_MUSTUNDERSTAND_0 = "0";
+    static final String ATTR_MUSTUNDERSTAND_1 = "1";
     /** Field SOAPFAULT_LOCAL_NAME */
-    public static final String SOAPFAULT_LOCAL_NAME = "Fault";
+    static final String SOAPFAULT_LOCAL_NAME = "Fault";
     /** Field SOAPFAULT_DETAIL_LOCAL_NAME */
-    public static final String SOAPFAULT_DETAIL_LOCAL_NAME = "detail";
+    static final String SOAPFAULT_DETAIL_LOCAL_NAME = "detail";
 
-    public static final String SOAP_FAULT_DETAIL_EXCEPTION_ENTRY = "Exception";
+    static final String SOAP_FAULT_DETAIL_EXCEPTION_ENTRY = "Exception";
 
     // -------- SOAP Fault Codes ------------------------------
-    public static final String FAULT_CODE_VERSION_MISMATCH = "VersionMismatch";
-    public static final String FAULT_CODE_MUST_UNDERSTAND = "MustUnderstand";
-    public static final String FAULT_CODE_DATA_ENCODING_UNKNOWN = "DataEncodingUnknown";
+    static final String FAULT_CODE_VERSION_MISMATCH = "VersionMismatch";
+    static final String FAULT_CODE_MUST_UNDERSTAND = "MustUnderstand";
+    static final String FAULT_CODE_DATA_ENCODING_UNKNOWN = "DataEncodingUnknown";
 
     // Followings are different in SOAP 1.1 and 1.2 specifications
-    public static final String FAULT_CODE_SENDER = "";
-    public static final String FAULT_CODE_RECEIVER = "";
+    static final String FAULT_CODE_SENDER = "";
+    static final String FAULT_CODE_RECEIVER = "";
 
 }

Modified: webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPEnvelope.java
URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPEnvelope.java?view=diff&rev=518787&r1=518786&r2=518787
==============================================================================
--- webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPEnvelope.java (original)
+++ webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPEnvelope.java Thu Mar 15 15:28:14 2007
@@ -30,7 +30,7 @@
      * @throws org.apache.axiom.om.OMException
      *          if there is a problem obtaining the <CODE>SOAPHeader</CODE> object
      */
-    public abstract SOAPHeader getHeader() throws OMException;
+    SOAPHeader getHeader() throws OMException;
 
     /**
      * Returns the <CODE>SOAPBody</CODE> object associated with this <CODE>SOAPEnvelope</CODE>
@@ -41,5 +41,5 @@
      *         <CODE>null</CODE> if there is none
      * @throws OMException if there is a problem obtaining the <CODE>SOAPBody</CODE> object
      */
-    public abstract SOAPBody getBody() throws OMException;
+    SOAPBody getBody() throws OMException;
 }

Modified: webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPFactory.java
URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPFactory.java?view=diff&rev=518787&r1=518786&r2=518787
==============================================================================
--- webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPFactory.java (original)
+++ webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPFactory.java Thu Mar 15 15:28:14 2007
@@ -23,35 +23,35 @@
 
 public interface SOAPFactory extends OMFactory {
 
-    public String getSoapVersionURI();
+    String getSoapVersionURI();
 
     /** Eran Chinthaka (chinthaka@apache.org) */
 
-    public SOAPMessage createSOAPMessage();
+    SOAPMessage createSOAPMessage();
 
-    public SOAPMessage createSOAPMessage(OMXMLParserWrapper builder);
+    SOAPMessage createSOAPMessage(OMXMLParserWrapper builder);
 
-    public SOAPMessage createSOAPMessage(SOAPEnvelope envelope, OMXMLParserWrapper parserWrapper);
+    SOAPMessage createSOAPMessage(SOAPEnvelope envelope, OMXMLParserWrapper parserWrapper);
 
     /** @return Returns SOAPEnvelope. */
-    public SOAPEnvelope createSOAPEnvelope() throws SOAPProcessingException;
+    SOAPEnvelope createSOAPEnvelope() throws SOAPProcessingException;
 
-    public SOAPEnvelope createSOAPEnvelope(OMXMLParserWrapper builder);
+    SOAPEnvelope createSOAPEnvelope(OMXMLParserWrapper builder);
 
     /**
      * @param envelope
      * @return Returns SOAPHeader.
      */
-    public SOAPHeader createSOAPHeader(SOAPEnvelope envelope) throws SOAPProcessingException;
+    SOAPHeader createSOAPHeader(SOAPEnvelope envelope) throws SOAPProcessingException;
 
-    public SOAPHeader createSOAPHeader() throws SOAPProcessingException;
+    SOAPHeader createSOAPHeader() throws SOAPProcessingException;
 
     /**
      * @param envelope
      * @param builder
      * @return Returns SOAPHeader.
      */
-    public SOAPHeader createSOAPHeader(SOAPEnvelope envelope,
+    SOAPHeader createSOAPHeader(SOAPEnvelope envelope,
                                        OMXMLParserWrapper builder);
 
     /**
@@ -59,11 +59,11 @@
      * @param ns
      * @return Returns SOAPHeaderBlock.
      */
-    public SOAPHeaderBlock createSOAPHeaderBlock(String localName,
+    SOAPHeaderBlock createSOAPHeaderBlock(String localName,
                                                  OMNamespace ns,
                                                  SOAPHeader parent) throws SOAPProcessingException;
 
-    public SOAPHeaderBlock createSOAPHeaderBlock(String localName,
+    SOAPHeaderBlock createSOAPHeaderBlock(String localName,
                                                  OMNamespace ns) throws SOAPProcessingException;
 
     /**
@@ -73,7 +73,7 @@
      * @param builder
      * @return Returns SOAPHeaderBlock.
      */
-    public SOAPHeaderBlock createSOAPHeaderBlock(String localName,
+    SOAPHeaderBlock createSOAPHeaderBlock(String localName,
                                                  OMNamespace ns,
                                                  SOAPHeader parent,
                                                  OMXMLParserWrapper builder)
@@ -84,34 +84,34 @@
      * @param e
      * @return Returns SOAPFault.
      */
-    public SOAPFault createSOAPFault(SOAPBody parent, Exception e) throws SOAPProcessingException;
+    SOAPFault createSOAPFault(SOAPBody parent, Exception e) throws SOAPProcessingException;
 
-    public SOAPFault createSOAPFault(SOAPBody parent) throws SOAPProcessingException;
+    SOAPFault createSOAPFault(SOAPBody parent) throws SOAPProcessingException;
 
-    public SOAPFault createSOAPFault() throws SOAPProcessingException;
+    SOAPFault createSOAPFault() throws SOAPProcessingException;
 
     /**
      * @param parent
      * @param builder
      * @return Returns SOAPFault.
      */
-    public SOAPFault createSOAPFault(SOAPBody parent,
+    SOAPFault createSOAPFault(SOAPBody parent,
                                      OMXMLParserWrapper builder);
 
     /**
      * @param envelope
      * @return Returns SOAPBody.
      */
-    public SOAPBody createSOAPBody(SOAPEnvelope envelope) throws SOAPProcessingException;
+    SOAPBody createSOAPBody(SOAPEnvelope envelope) throws SOAPProcessingException;
 
-    public SOAPBody createSOAPBody() throws SOAPProcessingException;
+    SOAPBody createSOAPBody() throws SOAPProcessingException;
 
     /**
      * @param envelope
      * @param builder
      * @return Returns SOAPBody.
      */
-    public SOAPBody createSOAPBody(SOAPEnvelope envelope,
+    SOAPBody createSOAPBody(SOAPEnvelope envelope,
                                    OMXMLParserWrapper builder);
 
     /* ========================
@@ -124,9 +124,9 @@
      * @param parent
      * @return Returns SOAPFaultCode.
      */
-    public SOAPFaultCode createSOAPFaultCode(SOAPFault parent) throws SOAPProcessingException;
+    SOAPFaultCode createSOAPFaultCode(SOAPFault parent) throws SOAPProcessingException;
 
-    public SOAPFaultCode createSOAPFaultCode() throws SOAPProcessingException;
+    SOAPFaultCode createSOAPFaultCode() throws SOAPProcessingException;
 
     /**
      * Code eii under SOAPFault (parent)
@@ -135,7 +135,7 @@
      * @param builder
      * @return Returns SOAPFaultCode.
      */
-    public SOAPFaultCode createSOAPFaultCode(SOAPFault parent,
+    SOAPFaultCode createSOAPFaultCode(SOAPFault parent,
                                              OMXMLParserWrapper builder);
 
     /*========================
@@ -148,9 +148,9 @@
      * @param parent
      * @return Returns SOAPFaultValue.
      */
-    public SOAPFaultValue createSOAPFaultValue(SOAPFaultCode parent) throws SOAPProcessingException;
+    SOAPFaultValue createSOAPFaultValue(SOAPFaultCode parent) throws SOAPProcessingException;
 
-    public SOAPFaultValue createSOAPFaultValue() throws SOAPProcessingException;
+    SOAPFaultValue createSOAPFaultValue() throws SOAPProcessingException;
 
     /**
      * Value eii under Code (parent)
@@ -159,7 +159,7 @@
      * @param builder
      * @return Returns SOAPFaultValue.
      */
-    public SOAPFaultValue createSOAPFaultValue(SOAPFaultCode parent,
+    SOAPFaultValue createSOAPFaultValue(SOAPFaultCode parent,
                                                OMXMLParserWrapper builder);
 
     /*========================
@@ -174,18 +174,18 @@
      */
 
     //added
-    public SOAPFaultValue createSOAPFaultValue(SOAPFaultSubCode parent)
+    SOAPFaultValue createSOAPFaultValue(SOAPFaultSubCode parent)
             throws SOAPProcessingException;
 
     //added
-    public SOAPFaultValue createSOAPFaultValue(SOAPFaultSubCode parent,
+    SOAPFaultValue createSOAPFaultValue(SOAPFaultSubCode parent,
                                                OMXMLParserWrapper builder);
 
     //changed
-    public SOAPFaultSubCode createSOAPFaultSubCode(SOAPFaultCode parent)
+    SOAPFaultSubCode createSOAPFaultSubCode(SOAPFaultCode parent)
             throws SOAPProcessingException;
 
-    public SOAPFaultSubCode createSOAPFaultSubCode() throws SOAPProcessingException;
+    SOAPFaultSubCode createSOAPFaultSubCode() throws SOAPProcessingException;
 
     /**
      * SubCode eii under Value (parent)
@@ -195,7 +195,7 @@
      * @return Returns SOAPFaultSubCode.
      */
     //changed
-    public SOAPFaultSubCode createSOAPFaultSubCode(SOAPFaultCode parent,
+    SOAPFaultSubCode createSOAPFaultSubCode(SOAPFaultCode parent,
                                                    OMXMLParserWrapper builder);
 
     /**
@@ -204,7 +204,7 @@
      * @param parent
      * @return Returns SOAPFaultSubCode.
      */
-    public SOAPFaultSubCode createSOAPFaultSubCode(SOAPFaultSubCode parent)
+    SOAPFaultSubCode createSOAPFaultSubCode(SOAPFaultSubCode parent)
             throws SOAPProcessingException;
 
     /**
@@ -214,7 +214,7 @@
      * @param builder
      * @return Returns SOAPFaultSubCode.
      */
-    public SOAPFaultSubCode createSOAPFaultSubCode(SOAPFaultSubCode parent,
+    SOAPFaultSubCode createSOAPFaultSubCode(SOAPFaultSubCode parent,
                                                    OMXMLParserWrapper builder);
 
     /*========================
@@ -227,9 +227,9 @@
      * @param parent
      * @return Returns SOAPFaultReason.
      */
-    public SOAPFaultReason createSOAPFaultReason(SOAPFault parent) throws SOAPProcessingException;
+    SOAPFaultReason createSOAPFaultReason(SOAPFault parent) throws SOAPProcessingException;
 
-    public SOAPFaultReason createSOAPFaultReason() throws SOAPProcessingException;
+    SOAPFaultReason createSOAPFaultReason() throws SOAPProcessingException;
 
     /**
      * Reason eii under SOAPFault (parent)
@@ -238,7 +238,7 @@
      * @param builder
      * @return Returns SOAPFaultReason.
      */
-    public SOAPFaultReason createSOAPFaultReason(SOAPFault parent,
+    SOAPFaultReason createSOAPFaultReason(SOAPFault parent,
                                                  OMXMLParserWrapper builder);
 
     /*========================
@@ -251,9 +251,9 @@
      * @param parent
      * @return Returns SOAPFaultText.
      */
-    public SOAPFaultText createSOAPFaultText(SOAPFaultReason parent) throws SOAPProcessingException;
+    SOAPFaultText createSOAPFaultText(SOAPFaultReason parent) throws SOAPProcessingException;
 
-    public SOAPFaultText createSOAPFaultText() throws SOAPProcessingException;
+    SOAPFaultText createSOAPFaultText() throws SOAPProcessingException;
 
     /**
      * SubCode eii under SubCode (parent)
@@ -262,7 +262,7 @@
      * @param builder
      * @return Returns SOAPFaultText.
      */
-    public SOAPFaultText createSOAPFaultText(SOAPFaultReason parent,
+    SOAPFaultText createSOAPFaultText(SOAPFaultReason parent,
                                              OMXMLParserWrapper builder);
 
     /*========================
@@ -275,9 +275,9 @@
      * @param parent
      * @return Returns SOAPFaultNode.
      */
-    public SOAPFaultNode createSOAPFaultNode(SOAPFault parent) throws SOAPProcessingException;
+    SOAPFaultNode createSOAPFaultNode(SOAPFault parent) throws SOAPProcessingException;
 
-    public SOAPFaultNode createSOAPFaultNode() throws SOAPProcessingException;
+    SOAPFaultNode createSOAPFaultNode() throws SOAPProcessingException;
 
     /**
      * Node eii under SOAPFault (parent)
@@ -286,7 +286,7 @@
      * @param builder
      * @return Returns SOAPFaultNode.
      */
-    public SOAPFaultNode createSOAPFaultNode(SOAPFault parent,
+    SOAPFaultNode createSOAPFaultNode(SOAPFault parent,
                                              OMXMLParserWrapper builder);
 
     /*========================
@@ -299,9 +299,9 @@
      * @param parent
      * @return Returns SOAPFaultRole.
      */
-    public SOAPFaultRole createSOAPFaultRole(SOAPFault parent) throws SOAPProcessingException;
+    SOAPFaultRole createSOAPFaultRole(SOAPFault parent) throws SOAPProcessingException;
 
-    public SOAPFaultRole createSOAPFaultRole() throws SOAPProcessingException;
+    SOAPFaultRole createSOAPFaultRole() throws SOAPProcessingException;
 
     /**
      * Role eii under SOAPFault (parent)
@@ -310,7 +310,7 @@
      * @param builder
      * @return Returns SOAPFaultRole.
      */
-    public SOAPFaultRole createSOAPFaultRole(SOAPFault parent,
+    SOAPFaultRole createSOAPFaultRole(SOAPFault parent,
                                              OMXMLParserWrapper builder);
 
     /*========================
@@ -323,9 +323,9 @@
      * @param parent
      * @return Returns SOAPFaultDetail.
      */
-    public SOAPFaultDetail createSOAPFaultDetail(SOAPFault parent) throws SOAPProcessingException;
+    SOAPFaultDetail createSOAPFaultDetail(SOAPFault parent) throws SOAPProcessingException;
 
-    public SOAPFaultDetail createSOAPFaultDetail() throws SOAPProcessingException;
+    SOAPFaultDetail createSOAPFaultDetail() throws SOAPProcessingException;
 
     /**
      * Role eii under SOAPFault (parent)
@@ -334,7 +334,7 @@
      * @param builder
      * @return Returns SOAPFaultDetail.
      */
-    public SOAPFaultDetail createSOAPFaultDetail(SOAPFault parent,
+    SOAPFaultDetail createSOAPFaultDetail(SOAPFault parent,
                                                  OMXMLParserWrapper builder);
 
 
@@ -344,10 +344,10 @@
      *
      * @return Returns SOAPEnvelope.
      */
-    public SOAPEnvelope getDefaultEnvelope() throws SOAPProcessingException;
+    SOAPEnvelope getDefaultEnvelope() throws SOAPProcessingException;
 
-    public SOAPEnvelope getDefaultFaultEnvelope() throws SOAPProcessingException;
+    SOAPEnvelope getDefaultFaultEnvelope() throws SOAPProcessingException;
 
-    public OMNamespace getNamespace();
+    OMNamespace getNamespace();
 
 }

Modified: webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPFault.java
URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPFault.java?view=diff&rev=518787&r1=518786&r2=518787
==============================================================================
--- webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPFault.java (original)
+++ webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPFault.java Thu Mar 15 15:28:14 2007
@@ -41,45 +41,45 @@
      *
      * @param soapFaultCode
      */
-    public void setCode(SOAPFaultCode soapFaultCode) throws SOAPProcessingException;
+    void setCode(SOAPFaultCode soapFaultCode) throws SOAPProcessingException;
 
-    public SOAPFaultCode getCode();
+    SOAPFaultCode getCode();
 
     /**
      * SOAPFaultReason is a mandatory item in a Fault, in SOAP 1.2 specification
      *
      * @param reason
      */
-    public void setReason(SOAPFaultReason reason) throws SOAPProcessingException;
+    void setReason(SOAPFaultReason reason) throws SOAPProcessingException;
 
-    public SOAPFaultReason getReason();
+    SOAPFaultReason getReason();
 
     /**
      * SOAPFaultNode is an optional item in a Fault, in SOAP 1.2 specification
      *
      * @param node
      */
-    public void setNode(SOAPFaultNode node) throws SOAPProcessingException;
+    void setNode(SOAPFaultNode node) throws SOAPProcessingException;
 
-    public SOAPFaultNode getNode();
+    SOAPFaultNode getNode();
 
     /**
      * SOAPFaultRoleImpl is an optional item in a Fault, in SOAP 1.2 specification
      *
      * @param role
      */
-    public void setRole(SOAPFaultRole role) throws SOAPProcessingException;
+    void setRole(SOAPFaultRole role) throws SOAPProcessingException;
 
-    public SOAPFaultRole getRole();
+    SOAPFaultRole getRole();
 
     /**
      * SOAPFaultRoleImpl is an optional item in a Fault, in SOAP 1.2 specification
      *
      * @param detail
      */
-    public void setDetail(SOAPFaultDetail detail) throws SOAPProcessingException;
+    void setDetail(SOAPFaultDetail detail) throws SOAPProcessingException;
 
-    public SOAPFaultDetail getDetail();
+    SOAPFaultDetail getDetail();
 
     /**
      * Returns Exception if there is one in the SOAP fault.
@@ -91,7 +91,7 @@
      * @throws org.apache.axiom.om.OMException
      *
      */
-    public Exception getException() throws OMException;
+    Exception getException() throws OMException;
 
-    public void setException(Exception e) throws OMException;
+    void setException(Exception e) throws OMException;
 }

Modified: webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPFaultCode.java
URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPFaultCode.java?view=diff&rev=518787&r1=518786&r2=518787
==============================================================================
--- webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPFaultCode.java (original)
+++ webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPFaultCode.java Thu Mar 15 15:28:14 2007
@@ -24,15 +24,15 @@
      */
 
     /** @param value  */
-    public void setValue(SOAPFaultValue value) throws SOAPProcessingException;
+    void setValue(SOAPFaultValue value) throws SOAPProcessingException;
 
     /** @return Returns SOAPFaultValue. */
-    public SOAPFaultValue getValue();
+    SOAPFaultValue getValue();
 
     /** @param value  */
-    public void setSubCode(SOAPFaultSubCode value) throws SOAPProcessingException;
+    void setSubCode(SOAPFaultSubCode value) throws SOAPProcessingException;
 
     /** @return Returns SOAPFaultSubCode. */
-    public SOAPFaultSubCode getSubCode();
+    SOAPFaultSubCode getSubCode();
 
 }

Modified: webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPFaultDetail.java
URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPFaultDetail.java?view=diff&rev=518787&r1=518786&r2=518787
==============================================================================
--- webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPFaultDetail.java (original)
+++ webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPFaultDetail.java Thu Mar 15 15:28:14 2007
@@ -31,8 +31,8 @@
  */
 public interface SOAPFaultDetail extends OMElement {
     /** Eran Chinthaka (chinthaka@apache.org) */
-    public void addDetailEntry(OMElement detailElement);
+    void addDetailEntry(OMElement detailElement);
 
-    public Iterator getAllDetailEntries();
+    Iterator getAllDetailEntries();
 
 }

Modified: webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPFaultNode.java
URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPFaultNode.java?view=diff&rev=518787&r1=518786&r2=518787
==============================================================================
--- webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPFaultNode.java (original)
+++ webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPFaultNode.java Thu Mar 15 15:28:14 2007
@@ -32,7 +32,7 @@
      *
      * @param uri
      */
-    public void setNodeValue(String uri);
+    void setNodeValue(String uri);
 
-    public String getNodeValue();
+    String getNodeValue();
 }

Modified: webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPFaultReason.java
URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPFaultReason.java?view=diff&rev=518787&r1=518786&r2=518787
==============================================================================
--- webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPFaultReason.java (original)
+++ webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPFaultReason.java Thu Mar 15 15:28:14 2007
@@ -23,11 +23,11 @@
 public interface SOAPFaultReason extends OMElement {
     /** Eran Chinthaka (chinthaka@apache.org) */
 
-    public void addSOAPText(SOAPFaultText soapFaultText) throws SOAPProcessingException;
+    void addSOAPText(SOAPFaultText soapFaultText) throws SOAPProcessingException;
 
-    public SOAPFaultText getFirstSOAPText();
+    SOAPFaultText getFirstSOAPText();
 
-    public List getAllSoapTexts();
+    List getAllSoapTexts();
 
-    public SOAPFaultText getSOAPFaultText(String language);
+    SOAPFaultText getSOAPFaultText(String language);
 }

Modified: webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPFaultRole.java
URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPFaultRole.java?view=diff&rev=518787&r1=518786&r2=518787
==============================================================================
--- webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPFaultRole.java (original)
+++ webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPFaultRole.java Thu Mar 15 15:28:14 2007
@@ -37,7 +37,7 @@
      *
      * @param uri
      */
-    public void setRoleValue(String uri);
+    void setRoleValue(String uri);
 
-    public String getRoleValue();
+    String getRoleValue();
 }

Modified: webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPFaultSubCode.java
URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPFaultSubCode.java?view=diff&rev=518787&r1=518786&r2=518787
==============================================================================
--- webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPFaultSubCode.java (original)
+++ webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPFaultSubCode.java Thu Mar 15 15:28:14 2007
@@ -28,9 +28,9 @@
      *
      * @param soapFaultSubCodeValue
      */
-    public void setValue(SOAPFaultValue soapFaultSubCodeValue) throws SOAPProcessingException;
+    void setValue(SOAPFaultValue soapFaultSubCodeValue) throws SOAPProcessingException;
 
-    public SOAPFaultValue getValue();
+    SOAPFaultValue getValue();
 
 
     /**
@@ -38,7 +38,7 @@
      *
      * @param subCode
      */
-    public void setSubCode(SOAPFaultSubCode subCode) throws SOAPProcessingException;
+    void setSubCode(SOAPFaultSubCode subCode) throws SOAPProcessingException;
 
-    public SOAPFaultSubCode getSubCode();
+    SOAPFaultSubCode getSubCode();
 }

Modified: webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPFaultText.java
URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPFaultText.java?view=diff&rev=518787&r1=518786&r2=518787
==============================================================================
--- webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPFaultText.java (original)
+++ webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPFaultText.java Thu Mar 15 15:28:14 2007
@@ -31,9 +31,9 @@
      *
      * @param lang
      */
-    public void setLang(String lang);
+    void setLang(String lang);
 
-    public String getLang();
+    String getLang();
 
 
 }

Modified: webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPHeader.java
URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPHeader.java?view=diff&rev=518787&r1=518786&r2=518787
==============================================================================
--- webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPHeader.java (original)
+++ webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPHeader.java Thu Mar 15 15:28:14 2007
@@ -116,5 +116,5 @@
      * @param nsURI
      * @return Returns ArrayList.
      */
-    public ArrayList getHeaderBlocksWithNSURI(String nsURI);
+    ArrayList getHeaderBlocksWithNSURI(String nsURI);
 }

Modified: webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPMessage.java
URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPMessage.java?view=diff&rev=518787&r1=518786&r2=518787
==============================================================================
--- webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPMessage.java (original)
+++ webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPMessage.java Thu Mar 15 15:28:14 2007
@@ -20,8 +20,8 @@
 
 public interface SOAPMessage extends OMDocument {
 
-    public SOAPEnvelope getSOAPEnvelope() throws SOAPProcessingException;
+    SOAPEnvelope getSOAPEnvelope() throws SOAPProcessingException;
 
-    public void setSOAPEnvelope(SOAPEnvelope envelope) throws SOAPProcessingException;
+    void setSOAPEnvelope(SOAPEnvelope envelope) throws SOAPProcessingException;
 
 }

Modified: webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPVersion.java
URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPVersion.java?view=diff&rev=518787&r1=518786&r2=518787
==============================================================================
--- webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPVersion.java (original)
+++ webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/soap/SOAPVersion.java Thu Mar 15 15:28:14 2007
@@ -25,20 +25,20 @@
     /**
      * Obtain the envelope namespace for this version of SOAP
      */
-    public String getEnvelopeURI();
+    String getEnvelopeURI();
 
     /**
      * Obtain the encoding namespace for this version of SOAP
      */
-    public String getEncodingURI();
+    String getEncodingURI();
 
     /**
      * Obtain the QName for the role attribute (actor/role)
      */
-    public QName getRoleAttributeQName();
+    QName getRoleAttributeQName();
 
     /**
      * Obtain the "next" role/actor URI
      */
-    public String getNextRoleURI();
+    String getNextRoleURI();
 }

Modified: webservices/commons/trunk/modules/axiom/modules/axiom-dom/src/main/java/org/apache/axiom/soap/impl/dom/SOAPEnvelopeImpl.java
URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-dom/src/main/java/org/apache/axiom/soap/impl/dom/SOAPEnvelopeImpl.java?view=diff&rev=518787&r1=518786&r2=518787
==============================================================================
--- webservices/commons/trunk/modules/axiom/modules/axiom-dom/src/main/java/org/apache/axiom/soap/impl/dom/SOAPEnvelopeImpl.java (original)
+++ webservices/commons/trunk/modules/axiom/modules/axiom-dom/src/main/java/org/apache/axiom/soap/impl/dom/SOAPEnvelopeImpl.java Thu Mar 15 15:28:14 2007
@@ -76,7 +76,13 @@
      * @throws OMException
      */
     public SOAPHeader getHeader() throws OMException {
-        return (SOAPHeader) getFirstChildWithName(new QName(SOAPConstants.HEADER_LOCAL_NAME));
+        // Header must be the first child
+        OMElement header = getFirstElement();
+        if (header == null || !(header instanceof SOAPHeader)) {
+            return null;
+        }
+
+        return (SOAPHeader) header;
     }
 
     public void addChild(OMNode child) {
@@ -201,7 +207,7 @@
             element.getBuilder().setCache(false);
             OMSerializerUtil.serializeByPullStream(element, writer, false);
         }
-        child = (NodeImpl) child.getNextOMSibling();
+//        child = (NodeImpl) child.getNextOMSibling();
     }
 
     public OMNode getNextOMSibling() throws OMException {

Modified: webservices/commons/trunk/modules/axiom/modules/axiom-impl/src/main/java/org/apache/axiom/soap/impl/llom/SOAPEnvelopeImpl.java
URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-impl/src/main/java/org/apache/axiom/soap/impl/llom/SOAPEnvelopeImpl.java?view=diff&rev=518787&r1=518786&r2=518787
==============================================================================
--- webservices/commons/trunk/modules/axiom/modules/axiom-impl/src/main/java/org/apache/axiom/soap/impl/llom/SOAPEnvelopeImpl.java (original)
+++ webservices/commons/trunk/modules/axiom/modules/axiom-impl/src/main/java/org/apache/axiom/soap/impl/llom/SOAPEnvelopeImpl.java Thu Mar 15 15:28:14 2007
@@ -225,6 +225,6 @@
             element.getBuilder().setCache(false);
             OMSerializerUtil.serializeByPullStream(element, writer, false);
         }
-        child = (OMNodeImpl) child.getNextOMSibling();
+        child.getNextOMSibling();
     }
 }

Modified: webservices/commons/trunk/modules/axiom/modules/axiom-impl/src/main/java/org/apache/axiom/soap/impl/llom/SOAPHeaderImpl.java
URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-impl/src/main/java/org/apache/axiom/soap/impl/llom/SOAPHeaderImpl.java?view=diff&rev=518787&r1=518786&r2=518787
==============================================================================
--- webservices/commons/trunk/modules/axiom/modules/axiom-impl/src/main/java/org/apache/axiom/soap/impl/llom/SOAPHeaderImpl.java (original)
+++ webservices/commons/trunk/modules/axiom/modules/axiom-impl/src/main/java/org/apache/axiom/soap/impl/llom/SOAPHeaderImpl.java Thu Mar 15 15:28:14 2007
@@ -40,9 +40,15 @@
  * A local interface we can use to make "header checker" objects which can be used by
  * HeaderIterators to filter results.  This really SHOULD be done with anonymous classes:
  * <p/>
- * public void getHeadersByRole(final String role) { return new HeaderIterator() { public boolean
- * checkHeader(SOAPHeaderBlock header) { ... if (role.equals(headerRole)) return true; return false;
- * } } }
+ * public void getHeadersByRole(final String role) {
+ *     return new HeaderIterator() {
+ *         public boolean checkHeader(SOAPHeaderBlock header) {
+ *             ...
+ *             if (role.equals(headerRole)) return true;
+ *             return false;
+ *         }
+ *     }
+ * }
  * <p/>
  * ...but there appears to be some kind of weird problem with the JVM not correctly scoping the
  * passed "role" value in a situation like the above.  As such, we have to make Checker objects

Modified: webservices/commons/trunk/modules/axiom/modules/axiom-tests/src/test/java/org/apache/axiom/om/IteratorTest.java
URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-tests/src/test/java/org/apache/axiom/om/IteratorTest.java?view=diff&rev=518787&r1=518786&r2=518787
==============================================================================
--- webservices/commons/trunk/modules/axiom/modules/axiom-tests/src/test/java/org/apache/axiom/om/IteratorTest.java (original)
+++ webservices/commons/trunk/modules/axiom/modules/axiom-tests/src/test/java/org/apache/axiom/om/IteratorTest.java Thu Mar 15 15:28:14 2007
@@ -18,6 +18,7 @@
 
 import org.apache.axiom.om.impl.builder.StAXOMBuilder;
 import org.apache.axiom.om.impl.llom.factory.OMLinkedListImplFactory;
+import org.apache.axiom.soap.SOAP11Constants;
 
 import javax.activation.DataHandler;
 import javax.activation.FileDataSource;
@@ -80,7 +81,8 @@
     /** Test the element iterator */
     public void testElementQNameIterator() {
         OMElement elt = envelope;
-        QName qname = new QName("http://schemas.xmlsoap.org/soap/envelope/", "body");
+        QName qname = new QName(SOAP11Constants.SOAP_ENVELOPE_NAMESPACE_URI,
+                                SOAP11Constants.BODY_LOCAL_NAME);
         Iterator iter = elt.getChildrenWithName(qname);
         int counter = 0;
         while (iter.hasNext()) {
@@ -202,9 +204,7 @@
             image.addChild(textData);
 
             OMElement imageName = fac.createOMElement("fileName", omNs);
-            if (imageSource != null) {
-                imageName.setText(imageSource.getAbsolutePath());
-            }
+            imageName.setText(imageSource.getAbsolutePath());
             data.addChild(image);
             data.addChild(imageName);
 
@@ -220,7 +220,7 @@
         Iterator imageElementIter = mtomSampleElement.getChildrenWithName(new QName("image"));
         // do something with the iterator
         while (imageElementIter.hasNext()) {
-            OMNode omNode = (OMNode) imageElementIter.next();
+            imageElementIter.next();
             // do nothing
         }
 



---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: commons-dev-help@ws.apache.org