[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #284: LOG4J2-2639 - Allow logging calls to be constructed using a builder pattern

[GitBox <gi...@apache.org>]

carterkozak commented on a change in pull request #284: LOG4J2-2639 - Allow logging calls to be constructed using a builder pattern
URL: https://github.com/apache/logging-log4j2/pull/284#discussion_r296490684
 
 

 ##########
 File path: log4j-api/src/main/java/org/apache/logging/log4j/internal/LogBuilder.java
 ##########
 @@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache license, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the license for the specific language governing permissions and
+ * limitations under the license.
+ */
+package org.apache.logging.log4j.internal;
+
+import org.apache.logging.log4j.Marker;
+import org.apache.logging.log4j.message.Message;
+
+/**
+ * Class Description goes here.
+ */
+public interface LogBuilder {
+
+    public static final LogBuilder INSTANCE = new LogBuilder() {};
+
+    default LogBuilder withMarker(Marker marker) {
+        return this;
+    }
+
+    default LogBuilder withThrowable(Throwable throwable) {
+        return this;
+    }
+
+    default LogBuilder withLocation() {
+        return this;
+    }
+
+    default LogBuilder withLocation(StackTraceElement location) {
+        return this;
+    }
+
+    default LogBuilder withMessage(Message msg) {
+        return this;
+    }
+
+    default LogBuilder withMessage(String msg) {
+        return this;
+    }
+
+    default LogBuilder withMessage(Object msg) {
+        return this;
+    }
+
+
+    default LogBuilder withParameters(Object... params) {
 
 Review comment:
   How does this interact with `withMessage(Message)`? Do we expect to overload this method with variable numbers of arguments similarly to existing logger.<level> methods?
   
   Would it be possible to use a single method which adds a parameter?
   
   ```java
   log.info()
     .message("{}, {}!)
     .parameter("Hello")
     .parameter("World")
     .log();
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services