You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by sehriff <gi...@git.apache.org> on 2017/03/10 03:31:38 UTC
[GitHub] incubator-carbondata pull request #640: Update CarbonExample.scala
GitHub user sehriff opened a pull request:
https://github.com/apache/incubator-carbondata/pull/640
Update CarbonExample.scala
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[CARBONDATA-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- What manual testing you have done?
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sehriff/incubator-carbondata patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-carbondata/pull/640.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #640
----
commit e0a342882d6acb8ca5c8df65b1782a1620c6c8df
Author: sehriff <13...@qq.com>
Date: 2017-03-10T03:18:58Z
Update CarbonExample.scala
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #640: [CARBONDATA-755]Confusing comment ab...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/640#discussion_r105393496
--- Diff: examples/spark/src/main/scala/org/apache/carbondata/examples/CarbonExample.scala ---
@@ -44,7 +44,7 @@ object CarbonExample {
// Currently there are two data loading flows in CarbonData, one uses Kettle as ETL tool
// in each node to do data loading, another uses a multi-thread framework without Kettle (See
// AbstractDataLoadProcessorStep)
- // Load data with Kettle
+ // Load data without Kettle(by Default,use_kettle='false')
--- End diff --
I think it does not need to mention kettle, as it may be totally removed in the future
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #640: Update CarbonExample.scala
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/640
Build Failed with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1069/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #640: [CARBONDATA-755]Confusing comment ab...
Posted by sehriff <gi...@git.apache.org>.
Github user sehriff closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/640
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #640: [CARBONDATA-755]Confusing comment about def...
Posted by sehriff <gi...@git.apache.org>.
Github user sehriff commented on the issue:
https://github.com/apache/incubator-carbondata/pull/640
Already create a JIRA,[CARBONDATA-755]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #640: Update CarbonExample.scala
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/640
add to whitelist
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #640: [CARBONDATA-755]Confusing comment ab...
Posted by sehriff <gi...@git.apache.org>.
Github user sehriff commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/640#discussion_r105523285
--- Diff: examples/spark/src/main/scala/org/apache/carbondata/examples/CarbonExample.scala ---
@@ -44,7 +44,7 @@ object CarbonExample {
// Currently there are two data loading flows in CarbonData, one uses Kettle as ETL tool
// in each node to do data loading, another uses a multi-thread framework without Kettle (See
// AbstractDataLoadProcessorStep)
- // Load data with Kettle
+ // Load data without Kettle(by Default,use_kettle='false')
--- End diff --
Thank you for your reply.
But this example really messed me up at the beginning,making me believe that use kettle or not can cause different query results.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #640: [CARBONDATA-755]Confusing comment ab...
Posted by sehriff <gi...@git.apache.org>.
Github user sehriff commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/640#discussion_r105523009
--- Diff: examples/spark/src/main/scala/org/apache/carbondata/examples/CarbonExample.scala ---
@@ -57,10 +57,21 @@ object CarbonExample {
GROUP BY country
""").show()
- // Load data without kettle
+ // Not rebuilding table will cause the query result doubled,which is confusing.
--- End diff --
I agree.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #640: Update CarbonExample.scala
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/640
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #640: [CARBONDATA-755]Confusing comment about def...
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/640
please close this PR, because you have raised another PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #640: Update CarbonExample.scala
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/640
@sehriff Thanks for your contributions.
Please create a JIRA issue as per the guide : https://github.com/apache/incubator-carbondata/blob/master/docs/How-to-contribute-to-Apache-CarbonData.md
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #640: [CARBONDATA-755]Confusing comment ab...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/640#discussion_r105393694
--- Diff: examples/spark/src/main/scala/org/apache/carbondata/examples/CarbonExample.scala ---
@@ -57,10 +57,21 @@ object CarbonExample {
GROUP BY country
""").show()
- // Load data without kettle
+ // Not rebuilding table will cause the query result doubled,which is confusing.
--- End diff --
suggest to change to "clean up before creating table"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #640: [CARBONDATA-755]Confusing comment ab...
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/640#discussion_r105523770
--- Diff: examples/spark/src/main/scala/org/apache/carbondata/examples/CarbonExample.scala ---
@@ -44,7 +44,7 @@ object CarbonExample {
// Currently there are two data loading flows in CarbonData, one uses Kettle as ETL tool
// in each node to do data loading, another uses a multi-thread framework without Kettle (See
// AbstractDataLoadProcessorStep)
- // Load data with Kettle
+ // Load data without Kettle(by Default,use_kettle='false')
--- End diff --
Yes, your PR is valid. I suggest : you can remove all kettle related code, make the example more clear and simple :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---