You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "abetomo (via GitHub)" <gi...@apache.org> on 2023/02/25 13:52:15 UTC

[GitHub] [arrow] abetomo opened a new pull request, #34350: GH-33849: [C++] Fix builds with ARROW_BUILD_SHARED=OFF and ARROW_BUILD_EXAMPLES=ON

abetomo opened a new pull request, #34350:
URL: https://github.com/apache/arrow/pull/34350

   <!--
   Thanks for opening a pull request!
   If this is your first pull request you can find detailed information on how 
   to contribute here:
     * [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
     * [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
   
   
   If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
   
   Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
   
   Then could you also rename the pull request title in the following format?
   
       GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
   
   or
   
       MINOR: [${COMPONENT}] ${SUMMARY}
   
   In the case of PARQUET issues on JIRA the title also supports:
   
       PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
   
   -->
   
   ### Rationale for this change
   
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.  
   -->
   
   Building with `ARROW_BUILD_SHARED=OFF` and `ARROW_BUILD_EXAMPLES=ON` causes an error.
   
   ### What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   At `examples/arrow/CMakeLists.txt`, set `arrow_substrait_[shared|static]` and `gandiva_[shared|static]` appropriately according to `ARROW_BUILD_SHARED`.
   
   ### Are these changes tested?
   
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   2. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
   -->
   
   In `--preset ninja-debug-maximal`, `ARROW_BUILD_EXAMPLES=ON`.
   
   ```
   $ cmake .. --preset ninja-debug-maximal -DARROW_BUILD_SHARED=OFF -DARROW_BUILD_STATIC=ON
   $ cmake --build .
   ```
   
   Build was completed.
   
   
   ```
   $ cmake .. --preset ninja-debug-maximal -DARROW_BUILD_SHARED=ON -DARROW_BUILD_STATIC=ON
   $ cmake --build .
   ```
   
   Build was completed.
   
   ### Are there any user-facing changes?
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please uncomment the line below and explain which changes are breaking.
   -->
   <!-- **This PR includes breaking changes to public APIs.** -->
   
   <!--
   Please uncomment the line below (and provide explanation) if the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld). We use this to highlight fixes to issues that may affect users without their knowledge. For this reason, fixing bugs that cause errors don't count, since those are usually obvious.
   -->
   <!-- **This PR contains a "Critical Fix".** -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] kou commented on pull request #34350: GH-33849: [C++] Fix builds with ARROW_BUILD_SHARED=OFF and ARROW_BUILD_EXAMPLES=ON

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #34350:
URL: https://github.com/apache/arrow/pull/34350#issuecomment-1445209179

   It seems that we also need to care Apache Arrow Flight related examples:
   
   ```diff
   diff --git a/cpp/examples/arrow/CMakeLists.txt b/cpp/examples/arrow/CMakeLists.txt
   index aa33c18e76..76c176086a 100644
   --- a/cpp/examples/arrow/CMakeLists.txt
   +++ b/cpp/examples/arrow/CMakeLists.txt
   @@ -34,7 +40,7 @@ endif()
    if(ARROW_FLIGHT)
      # Static gRPC means we cannot linked to shared Arrow, since then
      # we'll violate ODR for gRPC symbols
   -  if(ARROW_GRPC_USE_SHARED)
   +  if(ARROW_BUILD_SHARED AND ARROW_GRPC_USE_SHARED)
        set(FLIGHT_EXAMPLES_LINK_LIBS arrow_flight_shared)
        if(APPLE)
          set(GRPC_REFLECTION_LINK_LIBS gRPC::grpc++_reflection)
   @@ -100,7 +106,7 @@ if(ARROW_FLIGHT)
                        "${CMAKE_CURRENT_BINARY_DIR}/helloworld.grpc.pb.cc")
    
      if(ARROW_FLIGHT_SQL)
   -    if(ARROW_GRPC_USE_SHARED)
   +    if(ARROW_BUILD_SHARED AND ARROW_GRPC_USE_SHARED)
          set(FLIGHT_SQL_EXAMPLES_LINK_LIBS arrow_flight_sql_shared)
        else()
          set(FLIGHT_SQL_EXAMPLES_LINK_LIBS arrow_flight_sql_static)
   ```
   
   Could you install gRPC and try `cmake .. --preset ninja-debug-maximal -DARROW_BUILD_SHARED=OFF -DARROW_BUILD_STATIC=ON -DgRPC_SOURCE=SYSTEM`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] kou commented on pull request #34350: GH-33849: [C++] Fix builds with ARROW_BUILD_SHARED=OFF and ARROW_BUILD_EXAMPLES=ON

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #34350:
URL: https://github.com/apache/arrow/pull/34350#issuecomment-1454902867

   Yes.
   They should be built with both of `-DgRPC_SOURCE=SYSTEM` configuration and `-DgRPC_SOURCE=BUNDLED`.
   With this pull request, they are built with `-DgRPC_SOURCE=BUNDLED` but are NOT built (build error) with `-DgRPC_SOURCE=SYSTEM`.
   https://github.com/apache/arrow/pull/34350#issuecomment-1445209179 may fix the latter.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] ursabot commented on pull request #34350: GH-33849: [C++] Fix builds with ARROW_BUILD_SHARED=OFF and ARROW_BUILD_EXAMPLES=ON

Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #34350:
URL: https://github.com/apache/arrow/pull/34350#issuecomment-1465541037

   Benchmark runs are scheduled for baseline = 5b2fbade23eda9bc95b1e3854b19efff177cd0bd and contender = 29ec77901b6e5193af65723c463899fb9a140d6a. 29ec77901b6e5193af65723c463899fb9a140d6a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/6d6d72159b19444a9a164e864308dab8...2add8f2e924d45eeb3af9806754ac1d2/)
   [Failed :arrow_down:0.36% :arrow_up:0.36%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/340dc776b57249fdb2d43483c84a90e1...0dc6cffe98b74fe1858fb252e1ba5e2e/)
   [Finished :arrow_down:4.08% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/8fc38aa7c69448b3a48b4835cb7cf022...6d4c2489351f464fb6dc8521c1322d8d/)
   [Finished :arrow_down:0.38% :arrow_up:0.09%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/14289aae9d4e4bad973007c3483b1baf...67c2590d2d474b23bbfd26bdb71f4206/)
   Buildkite builds:
   [Finished] [`29ec7790` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2512)
   [Finished] [`29ec7790` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2542)
   [Finished] [`29ec7790` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2510)
   [Finished] [`29ec7790` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2533)
   [Finished] [`5b2fbade` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2511)
   [Failed] [`5b2fbade` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2541)
   [Finished] [`5b2fbade` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2509)
   [Finished] [`5b2fbade` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2532)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] abetomo commented on pull request #34350: GH-33849: [C++] Fix builds with ARROW_BUILD_SHARED=OFF and ARROW_BUILD_EXAMPLES=ON

Posted by "abetomo (via GitHub)" <gi...@apache.org>.
abetomo commented on PR #34350:
URL: https://github.com/apache/arrow/pull/34350#issuecomment-1454582909

   @kou As for Flight, if `debug/flight-grpc-example` and `debug/flight-sql-example` are generated, is it building as expected?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] kou commented on pull request #34350: GH-33849: [C++] Fix builds with ARROW_BUILD_SHARED=OFF and ARROW_BUILD_EXAMPLES=ON

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #34350:
URL: https://github.com/apache/arrow/pull/34350#issuecomment-1465341249

   @github-actions crossbow submit *example*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] github-actions[bot] commented on pull request #34350: GH-33849: [C++] Fix builds with ARROW_BUILD_SHARED=OFF and ARROW_BUILD_EXAMPLES=ON

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34350:
URL: https://github.com/apache/arrow/pull/34350#issuecomment-1465342258

   Revision: d9fa80545a201c4defc79aad68868091f5d93d6a
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-46b0d97237](https://github.com/ursacomputing/crossbow/branches/all?query=actions-46b0d97237)
   
   |Task|Status|
   |----|------|
   |cpp-tutorial-example|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-46b0d97237-github-cpp-tutorial-example)](https://github.com/ursacomputing/crossbow/actions/runs/4400151503/jobs/7705181351)|
   |example-cpp-minimal-build-static|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-46b0d97237-github-example-cpp-minimal-build-static)](https://github.com/ursacomputing/crossbow/actions/runs/4400151639/jobs/7705181556)|
   |example-cpp-minimal-build-static-system-dependency|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-46b0d97237-github-example-cpp-minimal-build-static-system-dependency)](https://github.com/ursacomputing/crossbow/actions/runs/4400152602/jobs/7705183540)|
   |example-python-minimal-build-fedora-conda|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-46b0d97237-github-example-python-minimal-build-fedora-conda)](https://github.com/ursacomputing/crossbow/actions/runs/4400152307/jobs/7705182963)|
   |example-python-minimal-build-ubuntu-venv|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-46b0d97237-github-example-python-minimal-build-ubuntu-venv)](https://github.com/ursacomputing/crossbow/actions/runs/4400151865/jobs/7705182034)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] abetomo commented on pull request #34350: GH-33849: [C++] Fix builds with ARROW_BUILD_SHARED=OFF and ARROW_BUILD_EXAMPLES=ON

Posted by "abetomo (via GitHub)" <gi...@apache.org>.
abetomo commented on PR #34350:
URL: https://github.com/apache/arrow/pull/34350#issuecomment-1465329898

   I could reproduce the error.
   
   ```
   $ cmake --build .
   [1/152] Linking CXX executable debug/flight-grpc-example
   [2/152] Linking CXX executable debug/compute-register-example
   [3/152] Linking CXX executable debug/rapidjson-row-converter
   ninja: job failed: : && /usr/bin/c++ -Wno-noexcept-type  -fdiagnostics-color=always  -Wall -Wno-conversion -Wno-sign-conversion -Wunused-result -fno-semantic-interposition -msse4.2  -g -Werror -O0 -ggdb  examples/arrow/CMakeFiles/flight-grpc-example.dir/flight_grpc_example.cc.o examples/arrow/CMakeFiles/flight-grpc-example.dir/helloworld.pb.cc.o examples/arrow/CMakeFiles/flight-grpc-example.dir/helloworld.grpc.pb.cc.o -o debug/flight-grpc-example  debug/libarrow.a  -larrow_flight_shared  -Wl,--no-as-needed  /usr/lib/libgrpc++_reflection.so.1.50.1  -Wl,--as-needed  /usr/lib/libprotobuf.so  gflags_ep-prefix/src/gflags_ep/lib/libgflags_debug.a  /usr/lib/libbrotlienc.so  /usr/lib/libbrotlidec.so  /usr/lib/libbrotlicommon.so  bzip2_ep-install/lib/libbz2.a  orc_ep-install/lib/liborc.a  lz4_ep-install/lib/liblz4.a  snappy_ep/src/snappy_ep-install/lib/libsnappy.a  /usr/lib/libzstd.so.1.5.2  google_cloud_cpp_ep-install/lib/libgoogle_cloud_cpp_storage.a  google_cloud_cpp_ep-install/lib/libg
 oogle_cloud_cpp_rest_internal.a  google_cloud_cpp_ep-install/lib/libgoogle_cloud_cpp_common.a  crc32c_ep-install/lib/libcrc32c.a  awssdk_ep-install/lib/libaws-cpp-sdk-identity-management.a  awssdk_ep-install/lib/libaws-cpp-sdk-sts.a  awssdk_ep-install/lib/libaws-cpp-sdk-cognito-identity.a  awssdk_ep-install/lib/libaws-cpp-sdk-s3.a  awssdk_ep-install/lib/libaws-cpp-sdk-core.a  /usr/lib/libcurl.so  awssdk_ep-install/lib/libaws-crt-cpp.a  awssdk_ep-install/lib/libaws-c-s3.a  awssdk_ep-install/lib/libaws-c-auth.a  awssdk_ep-install/lib/libaws-c-mqtt.a  awssdk_ep-install/lib/libaws-c-http.a  awssdk_ep-install/lib/libaws-c-compression.a  awssdk_ep-install/lib/libaws-c-sdkutils.a  awssdk_ep-install/lib/libaws-c-event-stream.a  awssdk_ep-install/lib/libaws-c-io.a  awssdk_ep-install/lib/libaws-c-cal.a  awssdk_ep-install/lib/libaws-checksums.a  awssdk_ep-install/lib/libaws-c-common.a  awssdk_ep-install/lib/libs2n.a  utf8proc_ep-install/lib/libutf8proc.a  jemalloc_ep-prefix/src/jemalloc_ep/dis
 t//lib/libjemalloc_pic.a  mimalloc_ep/src/mimalloc_ep/lib/mimalloc-2.0/libmimalloc-debug.a  /usr/lib/libgrpc++.so.1.50.1  /usr/lib/libgrpc.so.28.0.0  /usr/lib/libssl.so  /usr/lib/libcrypto.so  /lib/libz.so  re2_ep-install/lib/libre2.a  /usr/lib/libcares.so.2.5.1  /usr/lib/libaddress_sorting.so.28.0.0  /usr/lib/libupb.so.28.0.0  /usr/lib/libabsl_raw_hash_set.so.2206.0.0  /usr/lib/libabsl_hashtablez_sampler.so.2206.0.0  /usr/lib/libabsl_hash.so.2206.0.0  /usr/lib/libabsl_city.so.2206.0.0  /usr/lib/libabsl_low_level_hash.so.2206.0.0  /usr/lib/libabsl_statusor.so.2206.0.0  /usr/lib/libgpr.so.28.0.0  /usr/lib/libabsl_bad_variant_access.so.2206.0.0  /usr/lib/libabsl_status.so.2206.0.0  /usr/lib/libabsl_str_format_internal.so.2206.0.0  /usr/lib/libabsl_strerror.so.2206.0.0  /usr/lib/libabsl_random_distributions.so.2206.0.0  /usr/lib/libabsl_random_seed_sequences.so.2206.0.0  /usr/lib/libabsl_random_internal_pool_urbg.so.2206.0.0  /usr/lib/libabsl_random_internal_randen.so.2206.0.0  /usr/li
 b/libabsl_random_internal_randen_hwaes.so.2206.0.0  /usr/lib/libabsl_random_internal_randen_hwaes_impl.so.2206.0.0  /usr/lib/libabsl_random_internal_randen_slow.so.2206.0.0  /usr/lib/libabsl_random_internal_platform.so.2206.0.0  /usr/lib/libabsl_random_internal_seed_material.so.2206.0.0  /usr/lib/libabsl_random_seed_gen_exception.so.2206.0.0  /usr/lib/libabsl_cord.so.2206.0.0  /usr/lib/libabsl_bad_optional_access.so.2206.0.0  /usr/lib/libabsl_cordz_info.so.2206.0.0  /usr/lib/libabsl_cord_internal.so.2206.0.0  /usr/lib/libabsl_cordz_functions.so.2206.0.0  /usr/lib/libabsl_exponential_biased.so.2206.0.0  /usr/lib/libabsl_cordz_handle.so.2206.0.0  /usr/lib/libabsl_synchronization.so.2206.0.0  /usr/lib/libabsl_stacktrace.so.2206.0.0  /usr/lib/libabsl_symbolize.so.2206.0.0  /usr/lib/libabsl_debugging_internal.so.2206.0.0  /usr/lib/libabsl_demangle_internal.so.2206.0.0  /usr/lib/libabsl_graphcycles_internal.so.2206.0.0  /usr/lib/libabsl_time.so.2206.0.0  /usr/lib/libabsl_strings.so.2206.0
 .0  /usr/lib/libabsl_strings_internal.so.2206.0.0  /usr/lib/libabsl_throw_delegate.so.2206.0.0  /usr/lib/libabsl_int128.so.2206.0.0  /usr/lib/libabsl_civil_time.so.2206.0.0  /usr/lib/libabsl_time_zone.so.2206.0.0  /usr/lib/libabsl_malloc_internal.so.2206.0.0  /usr/lib/libabsl_base.so.2206.0.0  /usr/lib/libabsl_spinlock_wait.so.2206.0.0  /usr/lib/libabsl_raw_logging_internal.so.2206.0.0  /usr/lib/libabsl_log_severity.so.2206.0.0  /usr/lib/libprotobuf.so  -ldl  -lm  -lrt && :
   /usr/lib/gcc/x86_64-alpine-linux-musl/12.2.1/../../../../x86_64-alpine-linux-musl/bin/ld: cannot find -larrow_flight_shared: No such file or directory
   collect2: error: ld returned 1 exit status
   ninja: subcommand failed
   ```
   
   ```
   $ cmake --build .
   [1/70] Linking CXX executable debug/flight-sql-example
   [2/70] Linking CXX executable debug/flight-test-server
   [3/70] Linking CXX executable debug/arrow-flight-internals-test
   ninja: job failed: : && /usr/bin/c++ -Wno-noexcept-type  -fdiagnostics-color=always  -Wall -Wno-conversion -Wno-sign-conversion -Wunused-result -fno-semantic-interposition -msse4.2  -g -Werror -O0 -ggdb  examples/arrow/CMakeFiles/flight-sql-example.dir/flight_sql_example.cc.o -o debug/flight-sql-example  debug/libarrow.a  debug/libarrow_flight.a  -larrow_flight_sql_shared  /usr/lib/libgrpc++.so.1.50.1  /usr/lib/libprotobuf.so  gflags_ep-prefix/src/gflags_ep/lib/libgflags_nothreads_debug.a  debug/libarrow.a  /usr/lib/libbrotlienc.so  /usr/lib/libbrotlidec.so  /usr/lib/libbrotlicommon.so  bzip2_ep-install/lib/libbz2.a  orc_ep-install/lib/liborc.a  lz4_ep-install/lib/liblz4.a  snappy_ep/src/snappy_ep-install/lib/libsnappy.a  /usr/lib/libzstd.so.1.5.2  google_cloud_cpp_ep-install/lib/libgoogle_cloud_cpp_storage.a  google_cloud_cpp_ep-install/lib/libgoogle_cloud_cpp_rest_internal.a  google_cloud_cpp_ep-install/lib/libgoogle_cloud_cpp_common.a  crc32c_ep-install/lib/libcrc32c.a  awssdk_
 ep-install/lib/libaws-cpp-sdk-identity-management.a  awssdk_ep-install/lib/libaws-cpp-sdk-sts.a  awssdk_ep-install/lib/libaws-cpp-sdk-cognito-identity.a  awssdk_ep-install/lib/libaws-cpp-sdk-s3.a  awssdk_ep-install/lib/libaws-cpp-sdk-core.a  /usr/lib/libcurl.so  awssdk_ep-install/lib/libaws-crt-cpp.a  awssdk_ep-install/lib/libaws-c-s3.a  awssdk_ep-install/lib/libaws-c-auth.a  awssdk_ep-install/lib/libaws-c-mqtt.a  awssdk_ep-install/lib/libaws-c-http.a  awssdk_ep-install/lib/libaws-c-compression.a  awssdk_ep-install/lib/libaws-c-sdkutils.a  awssdk_ep-install/lib/libaws-c-event-stream.a  awssdk_ep-install/lib/libaws-c-io.a  awssdk_ep-install/lib/libaws-c-cal.a  awssdk_ep-install/lib/libaws-checksums.a  awssdk_ep-install/lib/libaws-c-common.a  awssdk_ep-install/lib/libs2n.a  utf8proc_ep-install/lib/libutf8proc.a  jemalloc_ep-prefix/src/jemalloc_ep/dist//lib/libjemalloc_pic.a  mimalloc_ep/src/mimalloc_ep/lib/mimalloc-2.0/libmimalloc-debug.a  /usr/lib/libgrpc.so.28.0.0  /usr/lib/libssl.s
 o  /usr/lib/libcrypto.so  /lib/libz.so  re2_ep-install/lib/libre2.a  /usr/lib/libcares.so.2.5.1  /usr/lib/libaddress_sorting.so.28.0.0  /usr/lib/libupb.so.28.0.0  /usr/lib/libabsl_raw_hash_set.so.2206.0.0  /usr/lib/libabsl_hashtablez_sampler.so.2206.0.0  /usr/lib/libabsl_hash.so.2206.0.0  /usr/lib/libabsl_city.so.2206.0.0  /usr/lib/libabsl_low_level_hash.so.2206.0.0  /usr/lib/libabsl_statusor.so.2206.0.0  /usr/lib/libgpr.so.28.0.0  -ldl  -lm  -lrt  /usr/lib/libabsl_bad_variant_access.so.2206.0.0  /usr/lib/libabsl_status.so.2206.0.0  /usr/lib/libabsl_str_format_internal.so.2206.0.0  /usr/lib/libabsl_strerror.so.2206.0.0  /usr/lib/libabsl_random_distributions.so.2206.0.0  /usr/lib/libabsl_random_seed_sequences.so.2206.0.0  /usr/lib/libabsl_random_internal_pool_urbg.so.2206.0.0  /usr/lib/libabsl_random_internal_randen.so.2206.0.0  /usr/lib/libabsl_random_internal_randen_hwaes.so.2206.0.0  /usr/lib/libabsl_random_internal_randen_hwaes_impl.so.2206.0.0  /usr/lib/libabsl_random_internal_r
 anden_slow.so.2206.0.0  /usr/lib/libabsl_random_internal_platform.so.2206.0.0  /usr/lib/libabsl_random_internal_seed_material.so.2206.0.0  /usr/lib/libabsl_random_seed_gen_exception.so.2206.0.0  /usr/lib/libabsl_cord.so.2206.0.0  /usr/lib/libabsl_bad_optional_access.so.2206.0.0  /usr/lib/libabsl_cordz_info.so.2206.0.0  /usr/lib/libabsl_cord_internal.so.2206.0.0  /usr/lib/libabsl_cordz_functions.so.2206.0.0  /usr/lib/libabsl_exponential_biased.so.2206.0.0  /usr/lib/libabsl_cordz_handle.so.2206.0.0  /usr/lib/libabsl_synchronization.so.2206.0.0  /usr/lib/libabsl_stacktrace.so.2206.0.0  /usr/lib/libabsl_symbolize.so.2206.0.0  /usr/lib/libabsl_debugging_internal.so.2206.0.0  /usr/lib/libabsl_demangle_internal.so.2206.0.0  /usr/lib/libabsl_graphcycles_internal.so.2206.0.0  /usr/lib/libabsl_time.so.2206.0.0  /usr/lib/libabsl_strings.so.2206.0.0  /usr/lib/libabsl_strings_internal.so.2206.0.0  /usr/lib/libabsl_throw_delegate.so.2206.0.0  /usr/lib/libabsl_int128.so.2206.0.0  /usr/lib/libabsl_
 civil_time.so.2206.0.0  /usr/lib/libabsl_time_zone.so.2206.0.0  /usr/lib/libabsl_malloc_internal.so.2206.0.0  /usr/lib/libabsl_base.so.2206.0.0  /usr/lib/libabsl_spinlock_wait.so.2206.0.0  /usr/lib/libabsl_raw_logging_internal.so.2206.0.0  /usr/lib/libabsl_log_severity.so.2206.0.0  /usr/lib/libprotobuf.so && :
   /usr/lib/gcc/x86_64-alpine-linux-musl/12.2.1/../../../../x86_64-alpine-linux-musl/bin/ld: cannot find -larrow_flight_sql_shared: No such file or directory
   collect2: error: ld returned 1 exit status
   ninja: subcommand failed
   ```
   
   If I just added `-DgRPC_SOURCE=SYSTEM`, it seemed to be using `grpc_ep-install` generated in the build directory, so I added `-DProtobuf_SOURCE=SYSTEM`.
   Also added `-DARROW_FLIGHT_SQL=ON` to build `debug/flight-sql-example`.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] abetomo commented on pull request #34350: GH-33849: [C++] Fix builds with ARROW_BUILD_SHARED=OFF and ARROW_BUILD_EXAMPLES=ON

Posted by "abetomo (via GitHub)" <gi...@apache.org>.
abetomo commented on PR #34350:
URL: https://github.com/apache/arrow/pull/34350#issuecomment-1447503016

   Thanks for your comment.
   I will try it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] github-actions[bot] commented on pull request #34350: GH-33849: [C++] Fix builds with ARROW_BUILD_SHARED=OFF and ARROW_BUILD_EXAMPLES=ON

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34350:
URL: https://github.com/apache/arrow/pull/34350#issuecomment-1445124821

   * Closes: #33849


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] abetomo commented on pull request #34350: GH-33849: [C++] Fix builds with ARROW_BUILD_SHARED=OFF and ARROW_BUILD_EXAMPLES=ON

Posted by "abetomo (via GitHub)" <gi...@apache.org>.
abetomo commented on PR #34350:
URL: https://github.com/apache/arrow/pull/34350#issuecomment-1465330757

   The build was successful with the https://github.com/apache/arrow/pull/34350#issuecomment-1445209179 patch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] kou merged pull request #34350: GH-33849: [C++] Fix builds with ARROW_BUILD_SHARED=OFF and ARROW_BUILD_EXAMPLES=ON

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #34350:
URL: https://github.com/apache/arrow/pull/34350


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org