You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/07/24 14:10:27 UTC

[GitHub] [pulsar] merlimat commented on a change in pull request #7572: [CPP] Fix segment crashes that caused by race condition of timer in cpp client

merlimat commented on a change in pull request #7572:
URL: https://github.com/apache/pulsar/pull/7572#discussion_r460076343



##########
File path: pulsar-client-cpp/lib/ClientConnection.cc
##########
@@ -1363,6 +1375,8 @@ void ClientConnection::close() {
     if (isClosed()) {
         return;
     }
+    // Use a sleep to stress the timers when the pop to find the race conditions with close().
+    // sleep(30);

Review comment:
       Please remove comment 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org