You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by ham1 <gi...@git.apache.org> on 2017/01/29 10:12:56 UTC
[GitHub] jmeter pull request #260: Manually synchronized on synchronizedMap as per do...
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/260
Manually synchronized on synchronizedMap as per docs and bz55827
Fixes issue identified in [bz55827](https://bz.apache.org/bugzilla/show_bug.cgi?id=55827)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ham1/jmeter bz55827-synchronized-map
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jmeter/pull/260.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #260
----
commit 380a0f4269c2c8a28d4ffeea2a1c5bc15bde7877
Author: Graham Russell <gr...@ham1.co.uk>
Date: 2017-01-29T10:05:58Z
manually synchronized on synchronizedMap as per docs and bz55827
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter issue #260: Manually synchronized on synchronizedMap as per docs and ...
Posted by pmouawad <gi...@git.apache.org>.
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/260
Hi,
Any thoughts on that ?
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter issue #260: Manually synchronized on synchronizedMap as per docs and ...
Posted by pmouawad <gi...@git.apache.org>.
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/260
Hello,
Thanks for contribution.
I am not sure we should apply this fix as I am not sure initial bug report was correct.
AFAIU, the propMap is never accessed concurrently although I don't know why propMap is wr�apped in a synchronized Map.
I am afraid that introducing this might hurt performances as it is called for every run of a sample .
But others analysis is welcome and particularly if anybody know why propMap was initially synchronized.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request #260: Manually synchronized on synchronizedMap as per do...
Posted by ham1 <gi...@git.apache.org>.
Github user ham1 closed the pull request at:
https://github.com/apache/jmeter/pull/260
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter issue #260: Manually synchronized on synchronizedMap as per docs and ...
Posted by pmouawad <gi...@git.apache.org>.
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/260
Hi all,
Any thoughts on this ?
Regards
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---