[jira] Commented: (NUTCH-309) Uses commons logging Code Guards

["Jerome Charron (JIRA)" <ji...@apache.org>]

    [ http://issues.apache.org/jira/browse/NUTCH-309?page=comments#action_12419670 ] 

Jerome Charron commented on NUTCH-309:
--------------------------------------

As already discussed, it perfectly makes sense and I have planned to work on this issue.
Another minor change I would like to make is to replace the log4j.properties by log4j.xml : The log4j.xml provides more funtionality and flexibility : especially filters that provide a way to log to different appenders depending on the log level for instance (for instance I use this to log all levels to a file and warn and error level to the console).
 

> Uses commons logging Code Guards
> --------------------------------
>
>          Key: NUTCH-309
>          URL: http://issues.apache.org/jira/browse/NUTCH-309
>      Project: Nutch
>         Type: Improvement

>     Versions: 0.8-dev
>     Reporter: Jerome Charron
>     Assignee: Jerome Charron
>     Priority: Minor
>      Fix For: 0.8-dev

>
> "Code guards are typically used to guard code that only needs to execute in support of logging, that otherwise introduces undesirable runtime overhead in the general case (logging disabled). Examples are multiple parameters, or expressions (e.g. string + " more") for parameters. Use the guard methods of the form log.is<Priority>() to verify that logging should be performed, before incurring the overhead of the logging method call. Yes, the logging methods will perform the same check, but only after resolving parameters."
> (description extracted from http://jakarta.apache.org/commons/logging/guide.html#Code_Guards)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira