You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/08/31 23:06:02 UTC

[GitHub] [beam] lukecwik commented on a change in pull request #12742: [BEAM-10843] Fix NPE in websites/build.gradle preventing linkage checker from working since the property isn't defined.

lukecwik commented on a change in pull request #12742:
URL: https://github.com/apache/beam/pull/12742#discussion_r480459505



##########
File path: website/build.gradle
##########
@@ -75,7 +75,7 @@ task createDockerContainer(type: Exec) {
     // "jenkins" user ownership. BEAM-9737
     // Otherwise: run as current user, so as to not require sudo to clean up
     // build/ directory.
-    if (!System.getenv('NODE_NAME').startsWith('websites')) {
+    if (!System.getenv('NODE_NAME')?.startsWith('websites')) {

Review comment:
       I liked your solution just as well since it clarified the comment.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org