[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #9684: Update rebalance API to return no-op when table is already balanced w/ reassignInstances

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on code in PR #9684:
URL: https://github.com/apache/pinot/pull/9684#discussion_r1009745381


##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##########
@@ -229,11 +229,11 @@ public RebalanceResult rebalance(TableConfig tableConfig, Configuration rebalanc
       LOGGER.info("Table: {} is already balanced", tableNameWithType);
       if (reassignInstances) {
         if (dryRun) {
-          return new RebalanceResult(RebalanceResult.Status.DONE,
+          return new RebalanceResult(RebalanceResult.Status.NO_OP,

Review Comment:
   This is not really `NO_OP` because instance might be re-assigned. To improve this, we want to check if the instance re-assignment is also no-op, and return `NO_OP` only if both of the operations are no-op



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org