You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ambari.apache.org by GitBox <gi...@apache.org> on 2019/01/04 14:46:44 UTC

[GitHub] tobias-istvan opened a new pull request #67: [AMBARI-25028] [Log Search UI] Populate `Component Name` in validator

tobias-istvan opened a new pull request #67: [AMBARI-25028] [Log Search UI] Populate `Component Name` in validator
URL: https://github.com/apache/ambari-logsearch/pull/67
 
 
   # What changes were proposed in this pull request?
   
   Instead of using text input for the `Component Name` in validation form, I added a dropdown which is populated from the config JSON from the `Configuration` form.
   
   If the JSON is not valid, or there is no component under the `input` property of the configuration, the dropdown is disabled.
   
   ## How was this patch tested?
   
   It was tested manually (because of the changes of the `DropdownComponent` I tested all the screens) and by unit tests:
   ```
   PhantomJS 2.1.1 (Mac OS X 0.0.0): Executed 295 of 295 SUCCESS (12.378 secs / 12.256 secs)
   ✨  Done in 43.39s.
   ```
   
   Please review [Ambari Contributing Guide](https://cwiki.apache.org/confluence/display/AMBARI/How+to+Contribute) before opening a pull request.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services