You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "mattyb149 (via GitHub)" <gi...@apache.org> on 2023/03/20 15:47:06 UTC

[GitHub] [nifi] mattyb149 opened a new pull request, #7059: NIFI-11305: Fix logic to correctly stop CaptureChangeMySQL

mattyb149 opened a new pull request, #7059:
URL: https://github.com/apache/nifi/pull/7059

   # Summary
   
   [NIFI-11305](https://issues.apache.org/jira/browse/NIFI-11305) This PR removes the unused logic to stop the CaptureChangeMySQL processor when it has been unscheduled, and instead checks to see if it has been unscheduled as a sign to stop the onTrigger binlog event processing loop.
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
   
   ### Pull Request Tracking
   
   - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-11305`
   - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-11305`
   
   ### Pull Request Formatting
   
   - [x] Pull Request based on current revision of the `main` branch
   - [x] Pull Request refers to a feature branch with one commit containing changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request creation.
   
   ### Build
   
   - [ ] Build completed using `mvn clean install -P contrib-check`
     - [x] JDK 11
     - [ ] JDK 17
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] markap14 commented on pull request #7059: NIFI-11305: Fix logic to correctly stop CaptureChangeMySQL

Posted by "markap14 (via GitHub)" <gi...@apache.org>.
markap14 commented on PR #7059:
URL: https://github.com/apache/nifi/pull/7059#issuecomment-1476859059

   Thanks for the fix @mattyb149. Looks good to me. +1 merged to main, and support/nifi-1.x


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] markap14 merged pull request #7059: NIFI-11305: Fix logic to correctly stop CaptureChangeMySQL

Posted by "markap14 (via GitHub)" <gi...@apache.org>.
markap14 merged PR #7059:
URL: https://github.com/apache/nifi/pull/7059


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org