You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2012/06/18 16:25:42 UTC

[jira] [Commented] (MAPREDUCE-4348) JobSubmissionProtocol should be made public, not package private

    [ https://issues.apache.org/jira/browse/MAPREDUCE-4348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13395914#comment-13395914 ] 

Hadoop QA commented on MAPREDUCE-4348:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12532414/MAPREDUCE-4348.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2468//console

This message is automatically generated.
                
> JobSubmissionProtocol should be made public, not package private
> ----------------------------------------------------------------
>
>                 Key: MAPREDUCE-4348
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4348
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: mrv1
>    Affects Versions: 1.0.3
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Minor
>         Attachments: MAPREDUCE-4348.patch
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> The JobSubmissionProtocol interface is package private, yet it is the only way to remotely query the status of the JT or the cluster. 
> Even if Job Submission is considered private, probing JT state shouldn't be.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira