You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@arrow.apache.org by "Wes McKinney (JIRA)" <ji...@apache.org> on 2017/07/28 02:41:00 UTC

[jira] [Resolved] (ARROW-572) [C++] Apply visitor pattern in IPC metadata

     [ https://issues.apache.org/jira/browse/ARROW-572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wes McKinney resolved ARROW-572.
--------------------------------
       Resolution: Won't Fix
         Assignee: Wes McKinney
    Fix Version/s:     (was: 0.6.0)
                   0.5.0

I'd been noodling on this for a little while. The code in question is https://github.com/apache/arrow/blob/master/cpp/src/arrow/ipc/metadata.cc#L354. There are some macros, true, but it's unclear that it's worth the extra machinery of adding an inline visitor for this bit of duplicated code. We can always... revisit. 

> [C++] Apply visitor pattern in IPC metadata
> -------------------------------------------
>
>                 Key: ARROW-572
>                 URL: https://issues.apache.org/jira/browse/ARROW-572
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>            Reporter: Wes McKinney
>            Assignee: Wes McKinney
>             Fix For: 0.5.0
>
>
> This would be cleaner than the current code. I will wait until after ARROW-534 and ARROW-459 to do this to avoid merge/rebase conflicts



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)