You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2018/01/19 15:49:47 UTC

[GitHub] sdedic commented on a change in pull request #374: [NETBEANS-138] Fix ScanStartedTest in parsing.indexing module.

sdedic commented on a change in pull request #374: [NETBEANS-138] Fix ScanStartedTest in parsing.indexing module.
URL: https://github.com/apache/incubator-netbeans/pull/374#discussion_r162657285
 
 

 ##########
 File path: parsing.indexing/test/unit/src/org/netbeans/modules/parsing/impl/indexing/ScanStartedTest.java
 ##########
 @@ -497,7 +497,9 @@ public void publish(LogRecord record) {
                 msg != null &&
                 msg.startsWith("scanStarting:") &&  //NOI18N
                 ie.first().equals(record.getParameters()[0])) {
-                throw ie.second();
+                RuntimeException exception = internalException.second();
 
 Review comment:
   The exception should be taken from "ie" local var anyway so the reported exception from .second() is consistent with ie.first().
   
   It could be better to remove the handler instance added in ``setUp()`` by  `logger.removeHandler(this.handler);` in `tearDown`. Handler from preceding testcases runnin in the same VM pile up. Maybe it wouldn't be even necessary to clean handler state then.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists