You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shale.apache.org by "Reind (JIRA)" <ji...@apache.org> on 2006/08/03 17:59:22 UTC
[jira] Created: (SHALE-247) s:validatorScript produces invalid html
markup
s:validatorScript produces invalid html markup
-----------------------------------------------
Key: SHALE-247
URL: http://issues.apache.org/struts/browse/SHALE-247
Project: Shale
Issue Type: Bug
Components: Core
Affects Versions: Nightly
Environment: myfaces 1.1.5
Reporter: Reind
Priority: Minor
The javascript that the <s:validatorScript> component generates does not validate against XHTML 1.0 Transitional using the validator on http://validator.w3.org/.
The validation error happens because the component creates an extraneous html comment start/stop before and after the javascript it generates.
Output:
<script type="text/javascript" language="Javascript1.1">
<!--
<!--
var bCancel = false;
...
-->
//-->
Fix:
<script type="text/javascript" language="Javascript1.1"><!--
var bCancel = false;
...
...
//-->
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (SHALE-247) s:validatorScript produces invalid html
markup
Posted by "Reind (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/SHALE-247?page=all ]
Reind updated SHALE-247:
------------------------
Affects Version/s: 1.0.2
(was: Nightly)
Edit:
The attached patch is for 1.0.2 , not the nightly build. There seems to be another issue with validatorScript in the nightlies
> s:validatorScript produces invalid html markup
> ----------------------------------------------
>
> Key: SHALE-247
> URL: http://issues.apache.org/struts/browse/SHALE-247
> Project: Shale
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.0.2
> Environment: myfaces 1.1.5
> Reporter: Reind
> Priority: Minor
> Attachments: site.patch
>
>
> The javascript that the <s:validatorScript> component generates does not validate against XHTML 1.0 Transitional using the validator on http://validator.w3.org/.
> The validation error happens because the component creates an extraneous html comment start/stop before and after the javascript it generates.
> Output:
> <script type="text/javascript" language="Javascript1.1">
> <!--
> <!--
> var bCancel = false;
> ...
> -->
> //-->
> Fix:
> <script type="text/javascript" language="Javascript1.1"><!--
> var bCancel = false;
> ...
> ...
> //-->
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SHALE-247) s:validatorScript produces invalid
html markup
Posted by "Reind (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/SHALE-247?page=comments#action_37911 ]
Reind commented on SHALE-247:
-----------------------------
Just wanted to add. I checked out a new copy of shale from subversion and validatorScript works (contrary to my previous post). Incidentally the patch work as well.
> s:validatorScript produces invalid html markup
> ----------------------------------------------
>
> Key: SHALE-247
> URL: http://issues.apache.org/struts/browse/SHALE-247
> Project: Shale
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.0.2
> Environment: myfaces 1.1.5
> Reporter: Reind
> Priority: Minor
> Attachments: site.patch
>
>
> The javascript that the <s:validatorScript> component generates does not validate against XHTML 1.0 Transitional using the validator on http://validator.w3.org/.
> The validation error happens because the component creates an extraneous html comment start/stop before and after the javascript it generates.
> Output:
> <script type="text/javascript" language="Javascript1.1">
> <!--
> <!--
> var bCancel = false;
> ...
> -->
> //-->
> Fix:
> <script type="text/javascript" language="Javascript1.1"><!--
> var bCancel = false;
> ...
> ...
> //-->
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Reopened: (SHALE-247) s:validatorScript produces invalid
html markup
Posted by "Gary VanMatre (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/SHALE-247?page=all ]
Gary VanMatre reopened SHALE-247:
---------------------------------
Assignee: Gary VanMatre
> s:validatorScript produces invalid html markup
> ----------------------------------------------
>
> Key: SHALE-247
> URL: http://issues.apache.org/struts/browse/SHALE-247
> Project: Shale
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.0.2
> Environment: myfaces 1.1.5
> Reporter: Reind
> Assigned To: Gary VanMatre
> Priority: Minor
> Fix For: 1.0.3
>
> Attachments: site.patch
>
>
> The javascript that the <s:validatorScript> component generates does not validate against XHTML 1.0 Transitional using the validator on http://validator.w3.org/.
> The validation error happens because the component creates an extraneous html comment start/stop before and after the javascript it generates.
> Output:
> <script type="text/javascript" language="Javascript1.1">
> <!--
> <!--
> var bCancel = false;
> ...
> -->
> //-->
> Fix:
> <script type="text/javascript" language="Javascript1.1"><!--
> var bCancel = false;
> ...
> ...
> //-->
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (SHALE-247) s:validatorScript produces invalid html
markup
Posted by "Reind (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/SHALE-247?page=all ]
Reind updated SHALE-247:
------------------------
Attachment: site.patch
This patch makes a small change to:
org.apache.shale.component.ValidatorScript.writeScriptStart(ResponseWriter writer)
and
org.apache.shale.component.ValidatorScript.writeScriptEnd(ResponseWriter writer)
It removes the "<!--\n" from the former and "-->\n" from the later.
This fixes the xhtml validation issues - and, hopefully, doesn't cause any other issues.
> s:validatorScript produces invalid html markup
> ----------------------------------------------
>
> Key: SHALE-247
> URL: http://issues.apache.org/struts/browse/SHALE-247
> Project: Shale
> Issue Type: Bug
> Components: Core
> Affects Versions: Nightly
> Environment: myfaces 1.1.5
> Reporter: Reind
> Priority: Minor
> Attachments: site.patch
>
>
> The javascript that the <s:validatorScript> component generates does not validate against XHTML 1.0 Transitional using the validator on http://validator.w3.org/.
> The validation error happens because the component creates an extraneous html comment start/stop before and after the javascript it generates.
> Output:
> <script type="text/javascript" language="Javascript1.1">
> <!--
> <!--
> var bCancel = false;
> ...
> -->
> //-->
> Fix:
> <script type="text/javascript" language="Javascript1.1"><!--
> var bCancel = false;
> ...
> ...
> //-->
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (SHALE-247) s:validatorScript produces invalid
html markup
Posted by "Gary VanMatre (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/SHALE-247?page=all ]
Gary VanMatre resolved SHALE-247.
---------------------------------
Resolution: Fixed
The patch should be available in the 20060807 nightly. Thanks for the help.
> s:validatorScript produces invalid html markup
> ----------------------------------------------
>
> Key: SHALE-247
> URL: http://issues.apache.org/struts/browse/SHALE-247
> Project: Shale
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.0.2
> Environment: myfaces 1.1.5
> Reporter: Reind
> Assigned To: Gary VanMatre
> Priority: Minor
> Fix For: 1.0.3
>
> Attachments: site.patch
>
>
> The javascript that the <s:validatorScript> component generates does not validate against XHTML 1.0 Transitional using the validator on http://validator.w3.org/.
> The validation error happens because the component creates an extraneous html comment start/stop before and after the javascript it generates.
> Output:
> <script type="text/javascript" language="Javascript1.1">
> <!--
> <!--
> var bCancel = false;
> ...
> -->
> //-->
> Fix:
> <script type="text/javascript" language="Javascript1.1"><!--
> var bCancel = false;
> ...
> ...
> //-->
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SHALE-247) s:validatorScript produces invalid
html markup
Posted by "Gary VanMatre (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/SHALE-247?page=comments#action_37912 ]
Gary VanMatre commented on SHALE-247:
-------------------------------------
I must have addressed this one in SHALE-217. But, thanks for the patch.
> s:validatorScript produces invalid html markup
> ----------------------------------------------
>
> Key: SHALE-247
> URL: http://issues.apache.org/struts/browse/SHALE-247
> Project: Shale
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.0.2
> Environment: myfaces 1.1.5
> Reporter: Reind
> Priority: Minor
> Fix For: 1.0.3
>
> Attachments: site.patch
>
>
> The javascript that the <s:validatorScript> component generates does not validate against XHTML 1.0 Transitional using the validator on http://validator.w3.org/.
> The validation error happens because the component creates an extraneous html comment start/stop before and after the javascript it generates.
> Output:
> <script type="text/javascript" language="Javascript1.1">
> <!--
> <!--
> var bCancel = false;
> ...
> -->
> //-->
> Fix:
> <script type="text/javascript" language="Javascript1.1"><!--
> var bCancel = false;
> ...
> ...
> //-->
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira