You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "matthiasblaesing (via GitHub)" <gi...@apache.org> on 2026/09/11 18:59:36 UTC
[PR] Update to NB master and fix missing OSGI runtime [netbeans-vscode]
matthiasblaesing opened a new pull request, #35:
URL: https://github.com/apache/netbeans-vscode/pull/35
With https://github.com/apache/netbeans/pull/9483/changes/f067194a049e6ced9aea99385a11f01494c7abf9 NetBinox was removed from NetBeans. For reasoning please refer to the corresponding commit.
For the IDE this not a problem as NetBeans was delivered with two OSGI runtimes (Netbinox and Apache Felix) and the second runtime took over. VSCode was broken as Apache Felix was explicitly blocked and thus not distributed, resulting in a distribution without an OSGI runtime.
This PR brings the NetBeans base to current master (915296a97f2327153d3ad87c9fef2d0bc8586fbb) and removes Felix from the blocklist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update to NB master and fix missing OSGI runtime [netbeans-vscode]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #35:
URL: https://github.com/apache/netbeans-vscode/pull/35#issuecomment-5699161251
@MartinBalin feel free to merge. Thanks for testing/checking and sorry for the breakage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update to NB master and fix missing OSGI runtime [netbeans-vscode]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #35:
URL: https://github.com/apache/netbeans-vscode/pull/35#issuecomment-5639508892
Only a start test was done: Bringing the embedded netbeans module to current master without updating the exclusion list creates a `nbcode` build that immediately fails on start:
```
java.lang.IllegalStateException: No NetigsoFramework found, is org.netbeans.core.netigso module enabled?
at org.netbeans.NetigsoHandle.getDefault(NetigsoHandle.java:63)
at org.netbeans.NetigsoHandle.turnOn(NetigsoHandle.java:115)
at org.netbeans.ModuleManager.doEnable(ModuleManager.java:1488)
at org.netbeans.ModuleManager.enable(ModuleManager.java:1343)
at org.netbeans.ModuleManager.enable(ModuleManager.java:1266)
at org.netbeans.core.startup.ModuleList.installNew(ModuleList.java:313)
at org.netbeans.core.startup.ModuleList.trigger(ModuleList.java:249)
at org.netbeans.core.startup.ModuleSystem.restore(ModuleSystem.java:294)
at org.netbeans.core.startup.Main.getModuleSystem(Main.java:174)
at org.netbeans.core.startup.Main.getModuleSystem(Main.java:143)
at org.netbeans.core.startup.Main.start(Main.java:305)
at org.netbeans.core.startup.TopThreadGroup.run(TopThreadGroup.java:97)
at java.base/java.lang.Thread.run(Thread.java:1474)
```
Together with the update of the dependency list this now works (i.e. the process does not terminate).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update to NB master and fix missing OSGI runtime [netbeans-vscode]
Posted by "MartinBalin (via GitHub)" <gi...@apache.org>.
MartinBalin commented on PR #35:
URL: https://github.com/apache/netbeans-vscode/pull/35#issuecomment-5680632915
@matthiasblaesing thank you for this fix and PR. I've built from your branch agains last commit in netbeans master, did some testing and it seems all work 👍 I will do some more testing tonight to make sure there is not some corner case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update to NB master and fix missing OSGI runtime [netbeans-vscode]
Posted by "MartinBalin (via GitHub)" <gi...@apache.org>.
MartinBalin commented on PR #35:
URL: https://github.com/apache/netbeans-vscode/pull/35#issuecomment-5697232358
@matthiasblaesing - Do you mind if I merge it today?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update to NB master and fix missing OSGI runtime [netbeans-vscode]
Posted by "MartinBalin (via GitHub)" <gi...@apache.org>.
MartinBalin commented on PR #35:
URL: https://github.com/apache/netbeans-vscode/pull/35#issuecomment-5685978594
@sdedic - If you will have a time, please review on Wed. Otherwise ready to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update to NB master and fix missing OSGI runtime [netbeans-vscode]
Posted by "JaroslavTulach (via GitHub)" <gi...@apache.org>.
JaroslavTulach commented on PR #35:
URL: https://github.com/apache/netbeans-vscode/pull/35#issuecomment-5643687431
- Thanks @matthiasblaesing for looking into the issue
- thanks also for trying (to start) Apache NetBeans VSCode extension
- btw. do you use VSCode occasionally (for non-Java development)?
- Your fix is simple and can certainly mitigate the problem way simpler ...
- then waiting for https://github.com/apache/netbeans/pull/9610
- where I am still struggling to find my head around the concepts changed after the Equinox upgrade
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update to NB master and fix missing OSGI runtime [netbeans-vscode]
Posted by "MartinBalin (via GitHub)" <gi...@apache.org>.
MartinBalin merged PR #35:
URL: https://github.com/apache/netbeans-vscode/pull/35
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists