[GitHub] [ozone] adoroszlai commented on a diff in pull request #3682: HDDS-7120. Fix Prometheus reporting only 1 VolumeIOStat

[GitBox <gi...@apache.org>]

adoroszlai commented on code in PR #3682:
URL: https://github.com/apache/ozone/pull/3682#discussion_r946842543


##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/VolumeIOStats.java:
##########
@@ -156,6 +157,8 @@ public long getReadTime() {
   public long getWriteTime() {
     return writeTime.value();
   }
-
-
+  @Metric(value = "Returns the storage directory name for the volume")

Review Comment:
   > Turns out that `@Metric` on fields ignores type.
   
   Maybe I'm missing something, but we don't have `type` specified here, so what is being ignored?
   
   (BTW, please write `@Metric` as code, to avoid mentioning the GitHub user named [Metric](https://github.com/Metric).)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org