[GitHub] [pulsar] codelipenghui commented on a diff in pull request #18995: [fix][broker] forbid uploading BYTES schema with admin API

[GitBox <gi...@apache.org>]

codelipenghui commented on code in PR #18995:
URL: https://github.com/apache/pulsar/pull/18995#discussion_r1054358129


##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApiSchemaTest.java:
##########
@@ -185,6 +185,16 @@ private <T> void testSchemaInfoApi(Schema<T> schema,
 
     }
 
+    @Test
+    public void testCreateBytesSchema() {
+        // forbid admin api creating BYTES schema to be consistent with client side
+        try {
+            testSchemaInfoApi(Schema.BYTES, "schematest/test/test-BYTES");

Review Comment:
   Please add `fail()` here. Otherwise, the test will get passed if the bytes schema is uploaded.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org