[GitHub] [spark] ramesh-muthusamy edited a comment on issue #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative task

[GitBox <gi...@apache.org>]

ramesh-muthusamy edited a comment on issue #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative task
URL: https://github.com/apache/spark/pull/26339#issuecomment-609383345
 
 
   @turboFei I don't think the existing UT would validate the fix. Following is a suggestion with reference to an existing test on speculative execution. https://github.com/apache/spark/blob/474b1bb5c2bce2f83c4dd8e19b9b7c5b3aebd6c4/core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala#L782
   
   Once you have enabled the above config's you need to ensure that there are multiple tasks triggered as part of UT, which can be achieved by increasing the data and associated partitions in the UT. I hope the suggestion will be helpful for your UT. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org