You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/11/23 08:59:40 UTC
[GitHub] [flink] MartijnVisser opened a new pull request #17881: [FLINK-24971][tests] Adding retry mechanism in case git clone fails
MartijnVisser opened a new pull request #17881:
URL: https://github.com/apache/flink/pull/17881
## What is the purpose of the change
* There are multiple occurrences of the Bash based `Streaming File Sink s3 end-to-end test stalled on azure` failing. After analysis, all failures have in common that git clone of flink-shaded is failing. This PR introduces a retry mechanism in case a git clone fails.
## Brief change log
* Added retry mechanism to git clone of flink-shaded
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17881: [FLINK-24971][tests] Adding retry mechanism in case git clone fails
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17881:
URL: https://github.com/apache/flink/pull/17881#issuecomment-976302259
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e26f93603b44c28a0bf284e3c4ba51e2b1565c94",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e26f93603b44c28a0bf284e3c4ba51e2b1565c94",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e26f93603b44c28a0bf284e3c4ba51e2b1565c94 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on a change in pull request #17881: [FLINK-24971][tests] Adding retry mechanism in case git clone fails
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on a change in pull request #17881:
URL: https://github.com/apache/flink/pull/17881#discussion_r755786268
##########
File path: flink-end-to-end-tests/test-scripts/common_ssl.sh
##########
@@ -77,7 +77,17 @@ function _set_conf_ssl_helper {
# -> we need to build it ourselves
FLINK_SHADED_VERSION=$(cat ${END_TO_END_DIR}/../pom.xml | sed -n 's/.*<flink.shaded.version>\(.*\)<\/flink.shaded.version>/\1/p')
echo "BUILDING flink-shaded-netty-tcnative-static"
- git clone https://github.com/apache/flink-shaded.git
+ # Adding retry to git clone, due to FLINK-24971
+ CLONE_COUNTER=1
+ CLONE_RETRIES=4 # Since we start the counter at 1, we are retrying this 3 times
+ CLONE_SLEEP=1
+ until [ $CLONE_COUNTER -ge $CLONE_RETRIES ]
+ do
+ echo "Cloning flink-shaded, attempt number" $CLONE_COUNTER
+ git clone https://github.com/apache/flink-shaded.git && break
+ CLONE_COUNTER=$[$CLONE_COUNTER+1]
+ sleep $CLONE_SLEEP
+ done
Review comment:
That shouldn't be too hard. I guess the generic function should be in `common.sh` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise merged pull request #17881: [FLINK-24971][tests] Adding retry mechanism in case git clone fails
Posted by GitBox <gi...@apache.org>.
AHeise merged pull request #17881:
URL: https://github.com/apache/flink/pull/17881
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17881: [FLINK-24971][tests] Adding retry mechanism in case git clone fails
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17881:
URL: https://github.com/apache/flink/pull/17881#issuecomment-976302259
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e26f93603b44c28a0bf284e3c4ba51e2b1565c94",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26901",
"triggerID" : "e26f93603b44c28a0bf284e3c4ba51e2b1565c94",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e26f93603b44c28a0bf284e3c4ba51e2b1565c94 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26901)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #17881: [FLINK-24971][tests] Adding retry mechanism in case git clone fails
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on pull request #17881:
URL: https://github.com/apache/flink/pull/17881#issuecomment-977909632
Ran the test locally:
```FLINK_DIR=/Users/martijnvisser/Developer/flink/build-target /Users/martijnvisser/Developer/flink/flink-end-to-end-tests/run-single-test.sh skip "/Users/martijnvisser/Developer/flink/flink-end-to-end-tests/test-scripts/test_file_sink.sh s3 StreamingFileSink"```
The logs show:
```
BUILDING flink-shaded-netty-tcnative-static
Executing command: git clone https://github.com/apache/flink-shaded.git
Cloning into 'flink-shaded'...
```
Result:
```
[PASS] '/Users/martijnvisser/Developer/flink/flink-end-to-end-tests/test-scripts/test_file_sink.sh s3 StreamingFileSink' passed after 3 minutes and 34 seconds! Test exited with exit code 0.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on a change in pull request #17881: [FLINK-24971][tests] Adding retry mechanism in case git clone fails
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #17881:
URL: https://github.com/apache/flink/pull/17881#discussion_r755782939
##########
File path: flink-end-to-end-tests/test-scripts/common_ssl.sh
##########
@@ -77,7 +77,17 @@ function _set_conf_ssl_helper {
# -> we need to build it ourselves
FLINK_SHADED_VERSION=$(cat ${END_TO_END_DIR}/../pom.xml | sed -n 's/.*<flink.shaded.version>\(.*\)<\/flink.shaded.version>/\1/p')
echo "BUILDING flink-shaded-netty-tcnative-static"
- git clone https://github.com/apache/flink-shaded.git
+ # Adding retry to git clone, due to FLINK-24971
+ CLONE_COUNTER=1
+ CLONE_RETRIES=4 # Since we start the counter at 1, we are retrying this 3 times
+ CLONE_SLEEP=1
+ until [ $CLONE_COUNTER -ge $CLONE_RETRIES ]
+ do
+ echo "Cloning flink-shaded, attempt number" $CLONE_COUNTER
+ git clone https://github.com/apache/flink-shaded.git && break
+ CLONE_COUNTER=$[$CLONE_COUNTER+1]
+ sleep $CLONE_SLEEP
+ done
Review comment:
I wonder if we can add that as a general function for reuse on other batch tests...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17881: [FLINK-24971][tests] Adding retry mechanism in case git clone fails
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17881:
URL: https://github.com/apache/flink/pull/17881#issuecomment-976302259
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e26f93603b44c28a0bf284e3c4ba51e2b1565c94",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26901",
"triggerID" : "e26f93603b44c28a0bf284e3c4ba51e2b1565c94",
"triggerType" : "PUSH"
}, {
"hash" : "8df3b668e66cb56d9c8450446624d504d04d8d1f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26991",
"triggerID" : "8df3b668e66cb56d9c8450446624d504d04d8d1f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e26f93603b44c28a0bf284e3c4ba51e2b1565c94 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26901)
* 8df3b668e66cb56d9c8450446624d504d04d8d1f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26991)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17881: [FLINK-24971][tests] Adding retry mechanism in case git clone fails
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17881:
URL: https://github.com/apache/flink/pull/17881#issuecomment-976302259
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e26f93603b44c28a0bf284e3c4ba51e2b1565c94",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26901",
"triggerID" : "e26f93603b44c28a0bf284e3c4ba51e2b1565c94",
"triggerType" : "PUSH"
}, {
"hash" : "8df3b668e66cb56d9c8450446624d504d04d8d1f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8df3b668e66cb56d9c8450446624d504d04d8d1f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e26f93603b44c28a0bf284e3c4ba51e2b1565c94 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26901)
* 8df3b668e66cb56d9c8450446624d504d04d8d1f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17881: [FLINK-24971][tests] Adding retry mechanism in case git clone fails
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17881:
URL: https://github.com/apache/flink/pull/17881#issuecomment-976302259
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e26f93603b44c28a0bf284e3c4ba51e2b1565c94",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26901",
"triggerID" : "e26f93603b44c28a0bf284e3c4ba51e2b1565c94",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e26f93603b44c28a0bf284e3c4ba51e2b1565c94 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26901)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17881: [FLINK-24971][tests] Adding retry mechanism in case git clone fails
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17881:
URL: https://github.com/apache/flink/pull/17881#issuecomment-976300951
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit e26f93603b44c28a0bf284e3c4ba51e2b1565c94 (Tue Nov 23 09:03:15 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17881: [FLINK-24971][tests] Adding retry mechanism in case git clone fails
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17881:
URL: https://github.com/apache/flink/pull/17881#issuecomment-976302259
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e26f93603b44c28a0bf284e3c4ba51e2b1565c94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26901",
"triggerID" : "e26f93603b44c28a0bf284e3c4ba51e2b1565c94",
"triggerType" : "PUSH"
}, {
"hash" : "8df3b668e66cb56d9c8450446624d504d04d8d1f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26991",
"triggerID" : "8df3b668e66cb56d9c8450446624d504d04d8d1f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8df3b668e66cb56d9c8450446624d504d04d8d1f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26991)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org