You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2022/07/21 14:04:15 UTC
[GitHub] [cordova-android] fquirin opened a new issue, #1463: navigator.splashscreen.hide() issue in cordova-android v11.0.0
fquirin opened a new issue, #1463:
URL: https://github.com/apache/cordova-android/issues/1463
# Bug Report
## Problem
I recently updated Cordova and the Android platform plugin both to v11.0.0, adjusted my config.xml to use `AndroidWindowSplashScreenAnimatedIcon`, removed old splash screen entries (except the ones mentioned below) and made a **clean build** of my project (Node.js 14).
My app was previously able to close the splash screen manually so I had `AutoHideSplashScreen` set to `true`, `SplashScreenDelay` set to `10000` and simply used `navigator.splashscreen.hide()` to close the splash screen when my app is ready (depending on the device and connection quality 1-4s). In the worst case it would close after 10s.
### What is expected to happen?
`navigator.splashscreen.hide()` is supposed to close the splash screen before `SplashScreenDelay` expires.
### What does actually happen?
The splash screen always stays for the full `SplashScreenDelay` time.
## Information
- I've tried different settings for `AutoHideSplashScreen` and `SplashScreenDelay` but nothing worked
- I can see log entries of my app trying to call `navigator.splashscreen.hide()` after a while with no effect
- I've done some remote debugging of the app using Chrome and tried to call the hide function manually with no effect (and no error message). Interestingly the remote screen is blank as long as the splash screen is open, but the dev console clearly shows that my app finished loading (including login of the user).
- The exact same code was working in Cordova 9 with Android platform plugin v8.1.0
### Command or Code
Set the `SplashScreenDelay` to 60s and call `navigator.splashscreen.hide()` after device-ready but while the splash screen is still showing.
### Environment, Platform, Device
I've tested the Android Emulator with Android 12.1, (real) Samsung mobile with Android 8, (real) Samsung tablet with Android 11.
Every device has the same issue.
### Version information
Cordova: "Pure" Cordova v11.0.0 with Android platform v11.0.0, no Ionic, no Capacitor
Windows 11, Android Studio 2021.2.1 Patch 1
## Checklist
- [x] I searched for existing GitHub issues
- [x] I updated all Cordova tooling to most recent version
- [x] I included all the necessary information above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] florian72810 commented on issue #1463: navigator.splashscreen.hide() issue in cordova-android v11.0.0 when AutoHideSplashScreen is true or app uses redirect
Posted by GitBox <gi...@apache.org>.
florian72810 commented on issue #1463:
URL: https://github.com/apache/cordova-android/issues/1463#issuecomment-1275795551
I also had a problem with `hide()` not working, regardless of AutoHideSplashScreen.
I found that installing cordova-plugin-splashscreen is the problem. Version 6.0.2 is incompatible with Cordova-android 11. It is expected as it is not needed. But in my case, Cordova was still installing the last available version: 6.0.1. With this version, `hide()` is "broken".
I had to add plugin with a specific version: `cordova plugin add cordova-plugin-splashscreen@6.0.2`. Here, cordova cannot install a previous version for Android, it only adds for iOS. And everything works fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] bonjourjoel commented on issue #1463: navigator.splashscreen.hide() issue in cordova-android v11.0.0 when AutoHideSplashScreen is true or app uses redirect
Posted by GitBox <gi...@apache.org>.
bonjourjoel commented on issue #1463:
URL: https://github.com/apache/cordova-android/issues/1463#issuecomment-1219663707
@erisu After uninstalling and reinstalling a lot of things, and i don't remember what I did and how many times i did it, the splash screen hide() function works with cordova android 11. I believe there is something that prevents a smooth update from the previous version of cordova android, but whatever. Thanks for the reply.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] erisu commented on issue #1463: navigator.splashscreen.hide() issue in cordova-android v11.0.0 when AutoHideSplashScreen is true or app uses redirect
Posted by GitBox <gi...@apache.org>.
erisu commented on issue #1463:
URL: https://github.com/apache/cordova-android/issues/1463#issuecomment-1275882845
@florian72810 If you are only building for Cordova-Android (11.x) and Cordova-iOS (6.x), you do not need to install `cordova-plugin-splashscreen` anymore.
The iOS portion of the plugin was already removed in version 6.0.0 as it was integrated into the core of `cordova-ios@6.0.0`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] yeich commented on issue #1463: navigator.splashscreen.hide() issue in cordova-android v11.0.0 when AutoHideSplashScreen is true or app uses redirect
Posted by GitBox <gi...@apache.org>.
yeich commented on issue #1463:
URL: https://github.com/apache/cordova-android/issues/1463#issuecomment-1329255282
Currently i am facing an similar issue.
Am I right, that i cant use "`navigator.splashscreen.hide()`" with "`cordova-android@11.0.0`"?
--
My Problem: After the "`AutoHideSplashScreen`" gets triggered, the screen remains white and my content will not load.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] bonjourjoel commented on issue #1463: navigator.splashscreen.hide() issue in cordova-android v11.0.0
Posted by GitBox <gi...@apache.org>.
bonjourjoel commented on issue #1463:
URL: https://github.com/apache/cordova-android/issues/1463#issuecomment-1216706627
Hi, I'm not mixing these flags. I'm using it with autoHide=false.
And it's not working, as I mentioned earlier: navigator.splashscreen.hide() does not hide the splashscreen in cordova android 11.0.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] fquirin commented on issue #1463: navigator.splashscreen.hide() issue in cordova-android v11.0.0 when AutoHideSplashScreen is true/false
Posted by GitBox <gi...@apache.org>.
fquirin commented on issue #1463:
URL: https://github.com/apache/cordova-android/issues/1463#issuecomment-1219619306
So, I did some digging and built the "Hello World" app from scratch 🙂:
```
sudo npm install -g cordova@11.0.0
cordova create hello com.example.hello HelloWorld
cd hello
cordova platform add android@11.0.0
```
After setting up the config and adding the hide function to the device-ready event as seen above **it was indeed working** if `AutoHideSplashScreen` is `false`!
Then I asked myself what is the difference to my "real" app, installed a dozen plugins and ... it was still working 😅 .
Finally I reviewed my initial code and remembered this in my `onDeviceReady` function: `cordova.InAppBrowser.open("index.html", "_self");`. It is a redirect to my actual starting-page (my default is start.html) and for a reason I can't remember I decided years ago to use the `InAppBrowser.open` to do it.
After that `navigator.splashscreen.hide()` is broken when called in the new `onDeviceReady` or anywhere else in my app.
When I replace `cordova.InAppBrowser.open("index.html", "_self");` with `window.location.href = "index.html";` it miraculously starts working again! The old version of splash-screen didn't really care so the code worked fine for the last ~3-4 years 🤷♂️ .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] varshas111 commented on issue #1463: navigator.splashscreen.hide() issue in cordova-android v11.0.0 when AutoHideSplashScreen is true or app uses redirect
Posted by GitBox <gi...@apache.org>.
varshas111 commented on issue #1463:
URL: https://github.com/apache/cordova-android/issues/1463#issuecomment-1326671102
I am having issue in splash screen after cordova android 11 upgrade. The splash screen is stretched now after adding preference tag
before:
<splash density="land-ldpi" src="resources/android/splash/drawable-land-ldpi-screen.png" />
<splash density="land-mdpi" src="resources/android/splash/drawable-land-mdpi-screen.png" />
<splash density="land-hdpi" src="resources/android/splash/drawable-land-hdpi-screen.png" />
after upgrade:
<preference name="AndroidWindowSplashScreenAnimatedIcon" value="resources/android/splash/drawable-land-ldpi-screen.png" />
<preference name="AndroidWindowSplashScreenAnimatedIcon" value="resources/android/splash/drawable-land-mdpi-screen.png" />
<preference name="AndroidWindowSplashScreenAnimatedIcon" value="resources/android/splash/drawable-land-hdpi-screen.png" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] ilyary commented on issue #1463: navigator.splashscreen.hide() issue in cordova-android v11.0.0 when AutoHideSplashScreen is true or app uses redirect
Posted by "ilyary (via GitHub)" <gi...@apache.org>.
ilyary commented on issue #1463:
URL: https://github.com/apache/cordova-android/issues/1463#issuecomment-1532133137
On my setup hide() method failed on page error, when I was calling navigator.splashscreen.hide(); from my error.html handling page.
However, I have noticed the SplashScreenPlugin has been initialised twice in this case.
I made a jump of truth: `private boolean keepOnScreen = true;` -> `private static boolean keepOnScreen = true;` in the plugin, and it worked!
Of course, it's not a real solution, but gives a spot of light what's going on here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] veronicatc commented on issue #1463: navigator.splashscreen.hide() issue in cordova-android v11.0.0 when AutoHideSplashScreen is true or app uses redirect
Posted by GitBox <gi...@apache.org>.
veronicatc commented on issue #1463:
URL: https://github.com/apache/cordova-android/issues/1463#issuecomment-1283283612
> Same issue here. I couldn't hide the splashscreen on Android after upgrading the platform to v11.0.0 In my case removing and adding back **cordova-plugin-inappbrowser** did the trick. Now works as inteded with AutoHideSplashScreen true or false. The plugin version is 5.0.0 both when removing and adding it back Hope this can help in any way
@S3nivus worked for me. I had tried removing and adding the android platform before, no use. Splash screen would not hide. I then removed and added back the inappbrowser plugin, and also turned AutoHideSplashScreen to TRUE. Again removed and added the android platform after this. And then it worked. Then I changed AutoHideSplashScreen to FALSE, and it kept working, now hiding the splash with navigator.splashscreen.hide() ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] breautek commented on issue #1463: navigator.splashscreen.hide() issue in cordova-android v11.0.0 when AutoHideSplashScreen is true or app uses redirect
Posted by GitBox <gi...@apache.org>.
breautek commented on issue #1463:
URL: https://github.com/apache/cordova-android/issues/1463#issuecomment-1336010396
> Am I right, that i cant use "navigator.splashscreen.hide()" with "cordova-android@11.0.0"?
[navigor.splashscreen.hide](https://cordova.apache.org/docs/en/11.x/core/features/splashscreen/index.html#navigatorsplashscreenhide) is a supported API with Cordova Android 11 splashscreens, but the `show` API is no longer supported (cause Android splashscreens doesn't support reshowing the splashscreen).
When upgrading to cordova-android@11, make sure you also upgrade the splashscreen plugin. Older versions will conflict with cordova-android@11. If you only develop for android and iOS, the splashscreen plugin can be uninstalled as both of these platforms now include the splashscreen API as part of their core platform.
It appears that the issue has been identified and resolved by ensuring the splashscreen plugin is either upgraded or removed, so I'll be closing this ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] bonjourjoel commented on issue #1463: navigator.splashscreen.hide() issue in cordova-android v11.0.0 when AutoHideSplashScreen is true or app uses redirect
Posted by "bonjourjoel (via GitHub)" <gi...@apache.org>.
bonjourjoel commented on issue #1463:
URL: https://github.com/apache/cordova-android/issues/1463#issuecomment-1436098973
> is there still no solution to this issue?
Hi @xbox101xbox, I think this is an issue related to the update of cordova components. It doesn't happen if you create a new project, but if you update your former project, it can do this error.
I think the solution is to recreate the cordova project. Or at least to remove the related plugins and the platform android, and then add them back. That worked for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] erisu commented on issue #1463: navigator.splashscreen.hide() issue in cordova-android v11.0.0 when AutoHideSplashScreen is true/false
Posted by GitBox <gi...@apache.org>.
erisu commented on issue #1463:
URL: https://github.com/apache/cordova-android/issues/1463#issuecomment-1217418459
Please upload a minimum reproduction repo that shows the issue.
I am still unable to reproduce the issue.
My test project had used:
**Config.xml**
```xml
<preference name="AutoHideSplashScreen" value="false" />
```
**index.js**
```js
document.addEventListener('deviceready', onDeviceReady, false);
function onDeviceReady() {
// Cordova is now initialized. Have fun!
console.log('Running cordova-' + cordova.platformId + '@' + cordova.version);
document.getElementById('deviceready').classList.add('ready');
console.log('10 seconds timeout has been set');
setTimeout(function () {
console.log('10 seconds has passed. I will now hide the splash screen.');
navigator.splashscreen.hide();
}, 10000);
}
```
**Logcat**
```log
2022-08-17 12:16:19.427 8661-8661/com.cdv.cordovaTest I/chromium: [INFO:CONSOLE(27)] "Running cordova-android@11.0.0", source: https://localhost/js/index.js (27)
2022-08-17 12:16:19.427 8661-8661/com.cdv.cordovaTest I/chromium: [INFO:CONSOLE(30)] "10 seconds timeout has been set", source: https://localhost/js/index.js (30)
2022-08-17 12:16:19.432 8661-8661/com.cdv.cordovaTest D/PluginManager: postMessage: spinner
2022-08-17 12:16:29.428 8661-8661/com.cdv.cordovaTest I/chromium: [INFO:CONSOLE(32)] "10 seconds has passed. I will now hide the splash screen.", source: https://localhost/js/index.js (32)
2022-08-17 12:16:29.428 8661-8718/com.cdv.cordovaTest D/CordovaSplashScreenPlugin: navigator.splashscreen.hide() was called and now setting the keepOnScreen to false.
2022-08-17 12:16:29.428 8661-8718/com.cdv.cordovaTest D/CordovaSplashScreenPlugin: Splashscreen is hidden.
```
**Video Reference**
[10-second-splash-screen.webm](https://user-images.githubusercontent.com/1029107/185028086-3a1aad1b-fab4-49cf-885b-aed107cd0da1.webm)
**Additional Notes**
I added two additional log printout lines in `SplashScreenPlugin.java` which displays the last two lines in the adb logcat.
```log
2022-08-17 12:16:29.428 8661-8718/com.cdv.cordovaTest D/CordovaSplashScreenPlugin: navigator.splashscreen.hide() was called and now setting the keepOnScreen to false.
2022-08-17 12:16:29.428 8661-8718/com.cdv.cordovaTest D/CordovaSplashScreenPlugin: Splashscreen is hidden.
```
This shows that the native side of the code, that can only be triggered by the `.hide` action was executed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] ljudbane commented on issue #1463: navigator.splashscreen.hide() issue in cordova-android v11.0.0
Posted by GitBox <gi...@apache.org>.
ljudbane commented on issue #1463:
URL: https://github.com/apache/cordova-android/issues/1463#issuecomment-1216541691
Hello.
I can observe the same behaviour if i set `<preference name="AutoHideSplashScreen" value="true" />`. The call to `navigator.splashscreen.hide()` won't actually hide the splash screen. If i set the above preference to false, then it works.
Is this the intended behaviour? If so, then it would be nice if it was mentioned in docs (https://cordova.apache.org/docs/en/latest/core/features/splashscreen/index.html#navigatorsplashscreenhide).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] KhAliMoh commented on issue #1463: navigator.splashscreen.hide() issue in cordova-android v11.0.0 when AutoHideSplashScreen is true or app uses redirect
Posted by "KhAliMoh (via GitHub)" <gi...@apache.org>.
KhAliMoh commented on issue #1463:
URL: https://github.com/apache/cordova-android/issues/1463#issuecomment-1568228156
I had the same problem while working with Polymer 2 and Cordova. At first, I made it work by adding the code `navigator.splashscreen.hide()` in the index file. But then, I needed to call it from my custom element called `<main-app>` after something loaded. When I tried adding the same code inside `<main-app>`, it didn't work. So, I tried using a setTimeout function with a 0-second delay, and it worked perfectly. I hope this information can help anyone who faces a similar problem.
`
setTimeout(()=> {
navigator.splashscreen.hide()
}, 0)
`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] aesculus commented on issue #1463: navigator.splashscreen.hide() issue in cordova-android v11.0.0 when AutoHideSplashScreen is true or app uses redirect
Posted by "aesculus (via GitHub)" <gi...@apache.org>.
aesculus commented on issue #1463:
URL: https://github.com/apache/cordova-android/issues/1463#issuecomment-1481995065
I had the same issue. For me the hint from @S3nivus did the trick. Just updated the cordova-plugin-inappbrowser plugin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] erisu commented on issue #1463: navigator.splashscreen.hide() issue in cordova-android v11.0.0
Posted by GitBox <gi...@apache.org>.
erisu commented on issue #1463:
URL: https://github.com/apache/cordova-android/issues/1463#issuecomment-1216725874
Also, can you make a new issue ticket.
The issue you are reporting is avout the method not working at all even with `AutoHideSplashScreen` set to `false` while the original author is talking about `AutoHideSplashScreen` set to `true` for the purpose of mixing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] erisu commented on issue #1463: navigator.splashscreen.hide() issue in cordova-android v11.0.0
Posted by GitBox <gi...@apache.org>.
erisu commented on issue #1463:
URL: https://github.com/apache/cordova-android/issues/1463#issuecomment-1216702448
It was an unintentional change.
There is no reason why it can not go back to the original behavior.
I created code changes locally that should revert to the original behavior, but have not been tested yet. I can push a branch and create a PR if you like to test.
Also, as a note, I still do not see a valid benefit for mixing the manual and automatic hiding.
For example, from the ticket description:
> My app was previously able to close the splash screen manually so I had `AutoHideSplashScreen` set to `true`,` SplashScreenDelay` set to `10000` and simply used `navigator.splashscreen.hide()` to close the splash screen when my app is ready (depending on the device and connection quality 1-4s). In the worst case it would close after 10s.
If the app hits the 10-second worst-case scenario and you used Cordova to hide the splash screen, then **what will the end user see? A white screen?**
I was thinking in these more advanced scenarios, it is up to the app developer to control the timeout, from the app level. So in the above case, the 10 seconds countdown would be in the app's javascript code, and then when 10 seconds are reached, the app can decide what to do. For example, hide the splash screen and prepare and render a static "Failed To Fetch Data" screen or whatever warning.
As the changes were made, for supporting Android 12 Splash, I tried to support as many of the previous preferences as possible and tried to keep the original behavior. Some couldn't be retained perfectly, but as for the AutoHide preference, I was looking at it, as if it was used only for a simple use case. For example, a simple application that was designed to use primarily static HTML, and JS, and didn't require external data.
How everyone used these flags and mixed them was not something I was completely aware of.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] bonjourjoel commented on issue #1463: navigator.splashscreen.hide() issue in cordova-android v11.0.0
Posted by GitBox <gi...@apache.org>.
bonjourjoel commented on issue #1463:
URL: https://github.com/apache/cordova-android/issues/1463#issuecomment-1200140030
navigator.splashscreen.hide() does not hide the splashscreen in cordova android 11.0.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] bhandaribhumin commented on issue #1463: navigator.splashscreen.hide() issue in cordova-android v11.0.0
Posted by GitBox <gi...@apache.org>.
bhandaribhumin commented on issue #1463:
URL: https://github.com/apache/cordova-android/issues/1463#issuecomment-1206794067
Hi @bonjourjoel @breautek Application stuck at splash screen, after run application the splash screen is not hide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] ljudbane commented on issue #1463: navigator.splashscreen.hide() issue in cordova-android v11.0.0 when AutoHideSplashScreen is true or app uses redirect
Posted by GitBox <gi...@apache.org>.
ljudbane commented on issue #1463:
URL: https://github.com/apache/cordova-android/issues/1463#issuecomment-1275968893
When removin plugin completely from your project, make sure to remove both references in package.json file. One is npm package under `devDependencies` and another is under `cordova.plugins`. I had an issue where i removed only npm package from dependecies and plugin was still being added to android project because it was listed in `cordova.plugins`.
Removing all references to the plugin and re-creating android project/platform fixed the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] breautek closed issue #1463: navigator.splashscreen.hide() issue in cordova-android v11.0.0 when AutoHideSplashScreen is true or app uses redirect
Posted by GitBox <gi...@apache.org>.
breautek closed issue #1463: navigator.splashscreen.hide() issue in cordova-android v11.0.0 when AutoHideSplashScreen is true or app uses redirect
URL: https://github.com/apache/cordova-android/issues/1463
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] nyan-cat commented on issue #1463: navigator.splashscreen.hide() issue in cordova-android v11.0.0 when AutoHideSplashScreen is true or app uses redirect
Posted by "nyan-cat (via GitHub)" <gi...@apache.org>.
nyan-cat commented on issue #1463:
URL: https://github.com/apache/cordova-android/issues/1463#issuecomment-1427002531
Same bug here. Fresh new cordova 11 app -> splash screen doesn't go away. Is there a way to completely remove this useless "feature"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] xbox101xbox commented on issue #1463: navigator.splashscreen.hide() issue in cordova-android v11.0.0 when AutoHideSplashScreen is true or app uses redirect
Posted by "xbox101xbox (via GitHub)" <gi...@apache.org>.
xbox101xbox commented on issue #1463:
URL: https://github.com/apache/cordova-android/issues/1463#issuecomment-1435792422
is there still no solution to this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] mcastets commented on issue #1463: navigator.splashscreen.hide() issue in cordova-android v11.0.0 when AutoHideSplashScreen is true or app uses redirect
Posted by GitBox <gi...@apache.org>.
mcastets commented on issue #1463:
URL: https://github.com/apache/cordova-android/issues/1463#issuecomment-1324701246
I'm having the same regression following an upgrade from `cordova-android@10.1.1` to `cordova-android@11.0.0`: `navigator.splashscreen.hide()` no longer works when used with `<preference name="AutoHideSplashScreen" value="true" />`.
Notes:
- `cordova-plugin-splash-screen` has been successfully removed
- a fresh install of the cordova platform has been done (`platforms` and `plugins` folders have been correctly removed and reinstalled)
- I'm also using `cordova-plugin-inappbrowser@5.0.0` and reinstall had no effects (i'm not using redirection while showing splash screen though)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] S3nivus commented on issue #1463: navigator.splashscreen.hide() issue in cordova-android v11.0.0 when AutoHideSplashScreen is true or app uses redirect
Posted by GitBox <gi...@apache.org>.
S3nivus commented on issue #1463:
URL: https://github.com/apache/cordova-android/issues/1463#issuecomment-1234627807
Same issue here. I couldn't hide the splashscreen on Android after upgrading the platform to v11.0.0
In my case removing and adding back **cordova-plugin-inappbrowser** did the trick. Now works as inteded with AutoHideSplashScreen true or false.
The plugin version is 5.0.0 both when removing and adding it back
Hope this can help in any way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] azrinhafizie commented on issue #1463: navigator.splashscreen.hide() issue in cordova-android v11.0.0
Posted by GitBox <gi...@apache.org>.
azrinhafizie commented on issue #1463:
URL: https://github.com/apache/cordova-android/issues/1463#issuecomment-1207454333
Hi @breautek @erisu . I found this while trying to fix for splashscreen won't hide issue.
`<preference name="AutoHideSplashScreen" value="false" />` in `config.xml` will not satisfy the following method in `SplashScreenPlugin.java`.
- `setupSplashScreen(SplashScreen splashScreen)`
- `attemptCloseOnPageFinished()`
(`autoHide` expected to be true.)
Hope this will help!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] fquirin commented on issue #1463: navigator.splashscreen.hide() issue in cordova-android v11.0.0 when AutoHideSplashScreen set to true
Posted by GitBox <gi...@apache.org>.
fquirin commented on issue #1463:
URL: https://github.com/apache/cordova-android/issues/1463#issuecomment-1217263692
> I've done some remote debugging of the app using Chrome and tried to call the hide function manually
When I tested this I set `AutoHideSplashScreen` to `false` and since the splash-screen never closed I had time to connect remotely and call the function manually -> no effect. So for me neither setting will make the hide function work.
There should be some clean Cordova test app to try this in a controlled environment right? Some template maybe?
> If the app hits the 10-second worst-case scenario and you used Cordova to hide the splash screen, then what will the end user see? A white screen?
He will see that the app is actually still doing something like loading content XY (a screen that the dev might prefer to hide for a certain grace period) or he will se an error message. Now obviously one could add the hide function to every error path and add some manual time-outs etc ... or one could simply rely on the auto-close feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] fquirin commented on issue #1463: navigator.splashscreen.hide() issue in cordova-android v11.0.0 when AutoHideSplashScreen is true or app uses redirect
Posted by "fquirin (via GitHub)" <gi...@apache.org>.
fquirin commented on issue #1463:
URL: https://github.com/apache/cordova-android/issues/1463#issuecomment-1436096359
For me it was resolved with what I found out here: https://github.com/apache/cordova-android/issues/1463#issuecomment-1219619306
Since it works on the clean test app, I'm assuming the remaining bugs are specific to individual setups.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org