You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/07/31 10:10:02 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #1496: libc: Change ctype macro to normal function

xiaoxiang781216 opened a new pull request #1496:
URL: https://github.com/apache/incubator-nuttx/pull/1496


   ## Summary
   to avoid the argument evaluation more than once
   
   ## Impact
   
   ## Testing
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1496: libc: Change ctype macro to normal function

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1496:
URL: https://github.com/apache/incubator-nuttx/pull/1496#issuecomment-675574390


   @patacongo the implementation don't bloat the size and simplify the code(userspace use table and kernel use normal function). Does it make sense?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] liuguo09 merged pull request #1496: libc: Change ctype macro to normal function

Posted by GitBox <gi...@apache.org>.
liuguo09 merged pull request #1496:
URL: https://github.com/apache/incubator-nuttx/pull/1496


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] yamt commented on a change in pull request #1496: libc: Change ctype macro to normal function

Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #1496:
URL: https://github.com/apache/incubator-nuttx/pull/1496#discussion_r466127394



##########
File path: libs/libc/ctype/lib_toupper.c
##########
@@ -0,0 +1,34 @@
+/****************************************************************************
+ * libs/libc/ctype/lib_toupper.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.  The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.  See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <ctype.h>
+
+/****************************************************************************
+ * Public Functions
+ ****************************************************************************/
+
+int toupper(int c)
+{
+  return (c >= 'a' && c <= 'z') ? c - 'a' + 'A' : c;

Review comment:
       it looks a bit awkward to use different parens for toupper and tolower




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org