You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/16 21:49:36 UTC
[GitHub] [doris] xinyiZzz opened a new pull request, #13401: [enhancement](memtracker) Fix query brpc server mem tracker
xinyiZzz opened a new pull request, #13401:
URL: https://github.com/apache/doris/pull/13401
# Proposed changes
Issue Number: close #xxx
## Problem summary
After the query ends, inaccurate query mem tracker in tpch : Q1, Q6, Q13
|tpch|old query mem tracker|fix query mem tracker|
|--|--|--|
|Q1|-300M|178.34M|
|Q6|-100M|13.56M|
|Q13|-2G|4.75G|
The reason for the negative number is that a lot of memory is freed after the query mem tracker is destructed.
Q13 minimal case:
```
-2G
select
count(o_orderkey) as c_count
from
orders right outer join customer on
c_custkey = o_custkey
and o_comment not like '%special%requests%';
```
1.1 lts have the same problem
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #13401: [enhancement](memtracker) Fix brpc causing query mem tracker to be inaccurate
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #13401:
URL: https://github.com/apache/doris/pull/13401
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org