You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@karaf.apache.org by "Christian Schneider (JIRA)" <ji...@apache.org> on 2011/07/06 18:43:16 UTC
[jira] [Created] (KARAF-713) Refactor karaf main
Refactor karaf main
-------------------
Key: KARAF-713
URL: https://issues.apache.org/jira/browse/KARAF-713
Project: Karaf
Issue Type: Improvement
Components: runtime
Affects Versions: 2.2.2, 3.0.0
Reporter: Christian Schneider
Assignee: Christian Schneider
Fix For: 2.2.3, 3.0.0
The karaf main project is currently not so well structured.
The class Main has too many responsibilities and is too big (almost 1500 lines).
The lock classes are in the main package. They should be moved to a separate package.
Proposal:
create package lock and put everything about locking there. The case without locking should be handled as another lock implementation
Split the Main class into setup of the framework and LifeCycleManager that handles the lock / start and stopping
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KARAF-713) Refactor karaf main
Posted by "Christian Schneider (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christian Schneider updated KARAF-713:
--------------------------------------
Fix Version/s: (was: 3.0.0)
3.1.0
> Refactor karaf main
> -------------------
>
> Key: KARAF-713
> URL: https://issues.apache.org/jira/browse/KARAF-713
> Project: Karaf
> Issue Type: Improvement
> Components: karaf-core
> Affects Versions: 2.2.2, 3.0.0
> Reporter: Christian Schneider
> Assignee: Guillaume Nodet
> Fix For: 3.1.0
>
>
> The karaf main project is currently not so well structured.
> The class Main has too many responsibilities and is too big (almost 1500 lines).
> The lock classes are in the main package. They should be moved to a separate package.
> Proposal:
> create package lock and put everything about locking there. The case without locking should be handled as another lock implementation
> Split the Main class into setup of the framework and LifeCycleManager that handles the lock / start and stopping
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (KARAF-713) Refactor karaf main
Posted by "Christian Schneider (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christian Schneider closed KARAF-713.
-------------------------------------
> Refactor karaf main
> -------------------
>
> Key: KARAF-713
> URL: https://issues.apache.org/jira/browse/KARAF-713
> Project: Karaf
> Issue Type: Improvement
> Components: karaf-core
> Affects Versions: 2.2.2
> Reporter: Christian Schneider
> Assignee: Christian Schneider
> Fix For: 3.0.0
>
>
> The karaf main project is currently not so well structured.
> The class Main has too many responsibilities and is too big (almost 1500 lines).
> The lock classes are in the main package. They should be moved to a separate package.
> Proposal:
> create package lock and put everything about locking there. The case without locking should be handled as another lock implementation
> Split the Main class into setup of the framework and LifeCycleManager that handles the lock / start and stopping
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KARAF-713) Refactor karaf main
Posted by "Christian Schneider (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christian Schneider updated KARAF-713:
--------------------------------------
Affects Version/s: (was: 3.0.0)
Fix Version/s: (was: 3.1.0)
3.0.0
> Refactor karaf main
> -------------------
>
> Key: KARAF-713
> URL: https://issues.apache.org/jira/browse/KARAF-713
> Project: Karaf
> Issue Type: Improvement
> Components: karaf-core
> Affects Versions: 2.2.2
> Reporter: Christian Schneider
> Assignee: Christian Schneider
> Fix For: 3.0.0
>
>
> The karaf main project is currently not so well structured.
> The class Main has too many responsibilities and is too big (almost 1500 lines).
> The lock classes are in the main package. They should be moved to a separate package.
> Proposal:
> create package lock and put everything about locking there. The case without locking should be handled as another lock implementation
> Split the Main class into setup of the framework and LifeCycleManager that handles the lock / start and stopping
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-713) Refactor karaf main
Posted by "Jean-Baptiste Onofré (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13063331#comment-13063331 ]
Jean-Baptiste Onofré commented on KARAF-713:
--------------------------------------------
Thanks Christian, it looks good to me :)
> Refactor karaf main
> -------------------
>
> Key: KARAF-713
> URL: https://issues.apache.org/jira/browse/KARAF-713
> Project: Karaf
> Issue Type: Improvement
> Components: karaf-core
> Affects Versions: 2.2.2, 3.0.0
> Reporter: Christian Schneider
> Assignee: Jean-Baptiste Onofré
> Fix For: 3.0.0
>
>
> The karaf main project is currently not so well structured.
> The class Main has too many responsibilities and is too big (almost 1500 lines).
> The lock classes are in the main package. They should be moved to a separate package.
> Proposal:
> create package lock and put everything about locking there. The case without locking should be handled as another lock implementation
> Split the Main class into setup of the framework and LifeCycleManager that handles the lock / start and stopping
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (KARAF-713) Refactor karaf main
Posted by "Christian Schneider (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christian Schneider resolved KARAF-713.
---------------------------------------
Resolution: Fixed
> Refactor karaf main
> -------------------
>
> Key: KARAF-713
> URL: https://issues.apache.org/jira/browse/KARAF-713
> Project: Karaf
> Issue Type: Improvement
> Components: runtime
> Affects Versions: 2.2.2, 3.0.0
> Reporter: Christian Schneider
> Assignee: Christian Schneider
> Fix For: 3.0.0
>
>
> The karaf main project is currently not so well structured.
> The class Main has too many responsibilities and is too big (almost 1500 lines).
> The lock classes are in the main package. They should be moved to a separate package.
> Proposal:
> create package lock and put everything about locking there. The case without locking should be handled as another lock implementation
> Split the Main class into setup of the framework and LifeCycleManager that handles the lock / start and stopping
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Work started] (KARAF-713) Refactor karaf main
Posted by "Christian Schneider (Work started) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on KARAF-713 started by Christian Schneider.
> Refactor karaf main
> -------------------
>
> Key: KARAF-713
> URL: https://issues.apache.org/jira/browse/KARAF-713
> Project: Karaf
> Issue Type: Improvement
> Components: karaf-core
> Affects Versions: 2.2.2
> Reporter: Christian Schneider
> Assignee: Christian Schneider
> Fix For: 3.0.0
>
>
> The karaf main project is currently not so well structured.
> The class Main has too many responsibilities and is too big (almost 1500 lines).
> The lock classes are in the main package. They should be moved to a separate package.
> Proposal:
> create package lock and put everything about locking there. The case without locking should be handled as another lock implementation
> Split the Main class into setup of the framework and LifeCycleManager that handles the lock / start and stopping
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-713) Refactor karaf main
Posted by "Guillaume Nodet (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147672#comment-13147672 ]
Guillaume Nodet commented on KARAF-713:
---------------------------------------
Changes have been reverted partially (at least the Main class has been reverted).
Christian, if you plan to work again on that, feel free to extract utility methods in classes, but try to minimize changes to the whole main class, as there are lots of cases that have been dealt with over the past years.
> Refactor karaf main
> -------------------
>
> Key: KARAF-713
> URL: https://issues.apache.org/jira/browse/KARAF-713
> Project: Karaf
> Issue Type: Improvement
> Components: karaf-core
> Affects Versions: 2.2.2, 3.0.0
> Reporter: Christian Schneider
> Assignee: Guillaume Nodet
> Fix For: 3.0.0
>
>
> The karaf main project is currently not so well structured.
> The class Main has too many responsibilities and is too big (almost 1500 lines).
> The lock classes are in the main package. They should be moved to a separate package.
> Proposal:
> create package lock and put everything about locking there. The case without locking should be handled as another lock implementation
> Split the Main class into setup of the framework and LifeCycleManager that handles the lock / start and stopping
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KARAF-713) Refactor karaf main
Posted by "Christian Schneider (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christian Schneider updated KARAF-713:
--------------------------------------
Fix Version/s: (was: 3.1.0)
3.0.0
> Refactor karaf main
> -------------------
>
> Key: KARAF-713
> URL: https://issues.apache.org/jira/browse/KARAF-713
> Project: Karaf
> Issue Type: Improvement
> Components: karaf-core
> Affects Versions: 2.2.2
> Reporter: Christian Schneider
> Assignee: Christian Schneider
> Fix For: 3.0.0
>
>
> The karaf main project is currently not so well structured.
> The class Main has too many responsibilities and is too big (almost 1500 lines).
> The lock classes are in the main package. They should be moved to a separate package.
> Proposal:
> create package lock and put everything about locking there. The case without locking should be handled as another lock implementation
> Split the Main class into setup of the framework and LifeCycleManager that handles the lock / start and stopping
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KARAF-713) Refactor karaf main
Posted by "Jean-Baptiste Onofré (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Baptiste Onofré updated KARAF-713:
---------------------------------------
Fix Version/s: (was: 2.2.3)
> Refactor karaf main
> -------------------
>
> Key: KARAF-713
> URL: https://issues.apache.org/jira/browse/KARAF-713
> Project: Karaf
> Issue Type: Improvement
> Components: runtime
> Affects Versions: 2.2.2, 3.0.0
> Reporter: Christian Schneider
> Assignee: Christian Schneider
> Fix For: 3.0.0
>
>
> The karaf main project is currently not so well structured.
> The class Main has too many responsibilities and is too big (almost 1500 lines).
> The lock classes are in the main package. They should be moved to a separate package.
> Proposal:
> create package lock and put everything about locking there. The case without locking should be handled as another lock implementation
> Split the Main class into setup of the framework and LifeCycleManager that handles the lock / start and stopping
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-713) Refactor karaf main
Posted by "Guillaume Nodet (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147706#comment-13147706 ]
Guillaume Nodet commented on KARAF-713:
---------------------------------------
The startup mechanism is that the start level is set to 1, initial bundles are installed, then the lock thread starts. When the lock is grabbed, the start level is moved to 100 (usually).
In your patch, the start up level was set to 100, then later to 1 and then again to 100 for some reason, which casused the framework to kinda stop and restart and leading to various problems (but those aren't alwasy reproductible because it's a timing issue). Also your patch did break the startup when no lock was specified.
That's the two main things I saw today, but I'm kinda reluctant to completely refactor the class. Cleaning things by extracing utility methods would certainly help though.
> Refactor karaf main
> -------------------
>
> Key: KARAF-713
> URL: https://issues.apache.org/jira/browse/KARAF-713
> Project: Karaf
> Issue Type: Improvement
> Components: karaf-core
> Affects Versions: 2.2.2, 3.0.0
> Reporter: Christian Schneider
> Assignee: Guillaume Nodet
> Fix For: 3.0.0
>
>
> The karaf main project is currently not so well structured.
> The class Main has too many responsibilities and is too big (almost 1500 lines).
> The lock classes are in the main package. They should be moved to a separate package.
> Proposal:
> create package lock and put everything about locking there. The case without locking should be handled as another lock implementation
> Split the Main class into setup of the framework and LifeCycleManager that handles the lock / start and stopping
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-713) Refactor karaf main
Posted by "Guillaume Nodet (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147630#comment-13147630 ]
Guillaume Nodet commented on KARAF-713:
---------------------------------------
I'm gonna revert the change as too many cases seems to behave differently.
> Refactor karaf main
> -------------------
>
> Key: KARAF-713
> URL: https://issues.apache.org/jira/browse/KARAF-713
> Project: Karaf
> Issue Type: Improvement
> Components: karaf-core
> Affects Versions: 2.2.2, 3.0.0
> Reporter: Christian Schneider
> Assignee: Guillaume Nodet
> Fix For: 3.0.0
>
>
> The karaf main project is currently not so well structured.
> The class Main has too many responsibilities and is too big (almost 1500 lines).
> The lock classes are in the main package. They should be moved to a separate package.
> Proposal:
> create package lock and put everything about locking there. The case without locking should be handled as another lock implementation
> Split the Main class into setup of the framework and LifeCycleManager that handles the lock / start and stopping
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-713) Refactor karaf main
Posted by "Christian Schneider (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238395#comment-13238395 ]
Christian Schneider commented on KARAF-713:
-------------------------------------------
I will do another try in refactoring main .. this time a bit slower and in some steps :-)
> Refactor karaf main
> -------------------
>
> Key: KARAF-713
> URL: https://issues.apache.org/jira/browse/KARAF-713
> Project: Karaf
> Issue Type: Improvement
> Components: karaf-core
> Affects Versions: 2.2.2
> Reporter: Christian Schneider
> Assignee: Christian Schneider
> Fix For: 3.0.0
>
>
> The karaf main project is currently not so well structured.
> The class Main has too many responsibilities and is too big (almost 1500 lines).
> The lock classes are in the main package. They should be moved to a separate package.
> Proposal:
> create package lock and put everything about locking there. The case without locking should be handled as another lock implementation
> Split the Main class into setup of the framework and LifeCycleManager that handles the lock / start and stopping
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (KARAF-713) Refactor karaf main
Posted by "Christian Schneider (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christian Schneider reassigned KARAF-713:
-----------------------------------------
Assignee: Christian Schneider (was: Guillaume Nodet)
> Refactor karaf main
> -------------------
>
> Key: KARAF-713
> URL: https://issues.apache.org/jira/browse/KARAF-713
> Project: Karaf
> Issue Type: Improvement
> Components: karaf-core
> Affects Versions: 2.2.2, 3.0.0
> Reporter: Christian Schneider
> Assignee: Christian Schneider
> Fix For: 3.1.0
>
>
> The karaf main project is currently not so well structured.
> The class Main has too many responsibilities and is too big (almost 1500 lines).
> The lock classes are in the main package. They should be moved to a separate package.
> Proposal:
> create package lock and put everything about locking there. The case without locking should be handled as another lock implementation
> Split the Main class into setup of the framework and LifeCycleManager that handles the lock / start and stopping
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-713) Refactor karaf main
Posted by "Christian Schneider (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147699#comment-13147699 ]
Christian Schneider commented on KARAF-713:
-------------------------------------------
Hi Guillaume,
sorry that I broke existing functionality. I will try to commit a simpler change soon.
As far as I know the test did not show the break in functionality. Do you think we could describe the expected behaviour somehow?
> Refactor karaf main
> -------------------
>
> Key: KARAF-713
> URL: https://issues.apache.org/jira/browse/KARAF-713
> Project: Karaf
> Issue Type: Improvement
> Components: karaf-core
> Affects Versions: 2.2.2, 3.0.0
> Reporter: Christian Schneider
> Assignee: Guillaume Nodet
> Fix For: 3.0.0
>
>
> The karaf main project is currently not so well structured.
> The class Main has too many responsibilities and is too big (almost 1500 lines).
> The lock classes are in the main package. They should be moved to a separate package.
> Proposal:
> create package lock and put everything about locking there. The case without locking should be handled as another lock implementation
> Split the Main class into setup of the framework and LifeCycleManager that handles the lock / start and stopping
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (KARAF-713) Refactor karaf main
Posted by "Christian Schneider (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christian Schneider resolved KARAF-713.
---------------------------------------
Resolution: Fixed
Through my other changes the class is now down to about 400 lines and much more readable
> Refactor karaf main
> -------------------
>
> Key: KARAF-713
> URL: https://issues.apache.org/jira/browse/KARAF-713
> Project: Karaf
> Issue Type: Improvement
> Components: karaf-core
> Affects Versions: 2.2.2
> Reporter: Christian Schneider
> Assignee: Christian Schneider
> Fix For: 3.0.0
>
>
> The karaf main project is currently not so well structured.
> The class Main has too many responsibilities and is too big (almost 1500 lines).
> The lock classes are in the main package. They should be moved to a separate package.
> Proposal:
> create package lock and put everything about locking there. The case without locking should be handled as another lock implementation
> Split the Main class into setup of the framework and LifeCycleManager that handles the lock / start and stopping
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (KARAF-713) Refactor karaf main
Posted by "Jean-Baptiste Onofré (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Baptiste Onofré resolved KARAF-713.
----------------------------------------
Resolution: Fixed
> Refactor karaf main
> -------------------
>
> Key: KARAF-713
> URL: https://issues.apache.org/jira/browse/KARAF-713
> Project: Karaf
> Issue Type: Improvement
> Components: karaf-core
> Affects Versions: 2.2.2, 3.0.0
> Reporter: Christian Schneider
> Assignee: Jean-Baptiste Onofré
> Fix For: 3.0.0
>
>
> The karaf main project is currently not so well structured.
> The class Main has too many responsibilities and is too big (almost 1500 lines).
> The lock classes are in the main package. They should be moved to a separate package.
> Proposal:
> create package lock and put everything about locking there. The case without locking should be handled as another lock implementation
> Split the Main class into setup of the framework and LifeCycleManager that handles the lock / start and stopping
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KARAF-713) Refactor karaf main
Posted by "Christian Schneider (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christian Schneider updated KARAF-713:
--------------------------------------
Fix Version/s: (was: 3.0.0)
3.1.0
Moving the rest of the refactorings for main to 3.1
> Refactor karaf main
> -------------------
>
> Key: KARAF-713
> URL: https://issues.apache.org/jira/browse/KARAF-713
> Project: Karaf
> Issue Type: Improvement
> Components: karaf-core
> Affects Versions: 2.2.2
> Reporter: Christian Schneider
> Assignee: Christian Schneider
> Fix For: 3.1.0
>
>
> The karaf main project is currently not so well structured.
> The class Main has too many responsibilities and is too big (almost 1500 lines).
> The lock classes are in the main package. They should be moved to a separate package.
> Proposal:
> create package lock and put everything about locking there. The case without locking should be handled as another lock implementation
> Split the Main class into setup of the framework and LifeCycleManager that handles the lock / start and stopping
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (KARAF-713) Refactor karaf main
Posted by "Guillaume Nodet (Reopened) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guillaume Nodet reopened KARAF-713:
-----------------------------------
Assignee: Guillaume Nodet (was: Jean-Baptiste Onofré)
This commit seems to have broken the clean startup of Karaf.
Karaf seems to reboot sometimes just after it started.
> Refactor karaf main
> -------------------
>
> Key: KARAF-713
> URL: https://issues.apache.org/jira/browse/KARAF-713
> Project: Karaf
> Issue Type: Improvement
> Components: karaf-core
> Affects Versions: 2.2.2, 3.0.0
> Reporter: Christian Schneider
> Assignee: Guillaume Nodet
> Fix For: 3.0.0
>
>
> The karaf main project is currently not so well structured.
> The class Main has too many responsibilities and is too big (almost 1500 lines).
> The lock classes are in the main package. They should be moved to a separate package.
> Proposal:
> create package lock and put everything about locking there. The case without locking should be handled as another lock implementation
> Split the Main class into setup of the framework and LifeCycleManager that handles the lock / start and stopping
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (KARAF-713) Refactor karaf main
Posted by "Jean-Baptiste Onofré (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Baptiste Onofré reopened KARAF-713:
----------------------------------------
Assignee: Jean-Baptiste Onofré (was: Christian Schneider)
As asked by Christian, I'm gonna review the main refactoring.
> Refactor karaf main
> -------------------
>
> Key: KARAF-713
> URL: https://issues.apache.org/jira/browse/KARAF-713
> Project: Karaf
> Issue Type: Improvement
> Components: runtime
> Affects Versions: 2.2.2, 3.0.0
> Reporter: Christian Schneider
> Assignee: Jean-Baptiste Onofré
> Fix For: 3.0.0
>
>
> The karaf main project is currently not so well structured.
> The class Main has too many responsibilities and is too big (almost 1500 lines).
> The lock classes are in the main package. They should be moved to a separate package.
> Proposal:
> create package lock and put everything about locking there. The case without locking should be handled as another lock implementation
> Split the Main class into setup of the framework and LifeCycleManager that handles the lock / start and stopping
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira