You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/06/15 01:53:05 UTC
[GitHub] [incubator-dolphinscheduler] codecov-commenter edited a comment on pull request #2969: add break & default logic for NettyDecoder.decode
codecov-commenter edited a comment on pull request #2969:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2969#issuecomment-643723174
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2969?src=pr&el=h1) Report
> Merging [#2969](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2969?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/3a7fd725c7b67950540c3959fda359e6ab66f229&el=desc) will **decrease** coverage by `0.08%`.
> The diff coverage is `71.42%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2969?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #2969 +/- ##
============================================
- Coverage 39.11% 39.02% -0.09%
Complexity 2678 2678
============================================
Files 435 435
Lines 20119 20126 +7
Branches 2454 2454
============================================
- Hits 7870 7855 -15
- Misses 11514 11535 +21
- Partials 735 736 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2969?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...he/dolphinscheduler/remote/codec/NettyDecoder.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2969/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2NvZGVjL05ldHR5RGVjb2Rlci5qYXZh) | `58.53% <71.42%> (-26.76%)` | `7.00 <1.00> (+2.00)` | :arrow_down: |
| [...g/apache/dolphinscheduler/remote/command/Pong.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2969/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2NvbW1hbmQvUG9uZy5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-2.00%)` | |
| [...dolphinscheduler/remote/command/CommandHeader.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2969/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2NvbW1hbmQvQ29tbWFuZEhlYWRlci5qYXZh) | `70.00% <0.00%> (-30.00%)` | `4.00% <0.00%> (-3.00%)` | |
| [...inscheduler/remote/handler/NettyServerHandler.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2969/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2hhbmRsZXIvTmV0dHlTZXJ2ZXJIYW5kbGVyLmphdmE=) | `23.40% <0.00%> (-25.54%)` | `3.00% <0.00%> (-2.00%)` | |
| [...inscheduler/remote/handler/NettyClientHandler.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2969/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2hhbmRsZXIvTmV0dHlDbGllbnRIYW5kbGVyLmphdmE=) | `20.40% <0.00%> (-22.45%)` | `2.00% <0.00%> (-3.00%)` | |
| [...org/apache/dolphinscheduler/remote/utils/Pair.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2969/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL3V0aWxzL1BhaXIuamF2YQ==) | `36.36% <0.00%> (-18.19%)` | `1.00% <0.00%> (-2.00%)` | |
| [...pache/dolphinscheduler/remote/command/Command.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2969/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2NvbW1hbmQvQ29tbWFuZC5qYXZh) | `37.93% <0.00%> (-17.25%)` | `7.00% <0.00%> (-2.00%)` | |
| [...dolphinscheduler/remote/future/ResponseFuture.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2969/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2Z1dHVyZS9SZXNwb25zZUZ1dHVyZS5qYXZh) | `72.88% <0.00%> (-8.48%)` | `17.00% <0.00%> (-1.00%)` | |
| [...phinscheduler/remote/utils/NamedThreadFactory.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2969/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL3V0aWxzL05hbWVkVGhyZWFkRmFjdG9yeS5qYXZh) | `91.66% <0.00%> (-8.34%)` | `3.00% <0.00%> (-1.00%)` | |
| ... and [9 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2969/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2969?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2969?src=pr&el=footer). Last update [3a7fd72...ee96f34](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2969?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org