You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucenenet.apache.org by jpsullivan <gi...@git.apache.org> on 2015/08/23 06:31:39 UTC
[GitHub] lucenenet pull request: Complete port of Lucene.Net.Join
GitHub user jpsullivan opened a pull request:
https://github.com/apache/lucenenet/pull/153
Complete port of Lucene.Net.Join
The port of the lucene-solr Join project is now complete. Tests are also implemented and passing.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jpsullivan/lucenenet join-port
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucenenet/pull/153.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #153
----
commit ecd2860520fc211ccdcc9784ca23b36d0d949a9c
Author: Josh Sullivan <ja...@gmail.com>
Date: 2015-08-11T05:39:20Z
Merge pull request #1 from jpsullivan/queries-test-coverage
Add tests to Lucene.Net.Queries
commit bd772f024f87a8e5b1115d5ce5ce07cd944fcdef
Author: Josh Sullivan <ja...@gmail.com>
Date: 2015-08-14T06:40:45Z
Ported over the first batch of items from the Join project
commit 47f20b9ac6a5890936fb48887cfef20830d9c4d9
Author: Josh Sullivan <ja...@gmail.com>
Date: 2015-08-17T15:30:55Z
Completed the implementation port of the Join project
commit dff959ff4125a1bd78b3caffe0ae7e99bd0bc6bb
Author: Josh Sullivan <ja...@gmail.com>
Date: 2015-08-17T18:36:54Z
Introduced tests for Lucene.Net.Join
Fixing bugs along the way.
commit 1213ca7c61e990ba008f087f00f167eb554d783c
Author: Josh Sullivan <ja...@gmail.com>
Date: 2015-08-17T19:24:46Z
All ToChildBlockJoinQuery tests passing
commit 0213f5301801aa372750b576af50ead184173072
Author: Josh Sullivan <ja...@gmail.com>
Date: 2015-08-17T20:04:05Z
Implemented the last of the Lucene.Net.Join tests
commit 4820f236b2444636452012c42e2450e408720335
Author: Josh Sullivan <ja...@gmail.com>
Date: 2015-08-23T04:27:54Z
Lucene.Net.Join tests now passing
Moved the Join/Grouping projects into the src folder and updated the sln
path mapping accordingly.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] lucenenet pull request: Complete port of Lucene.Net.Join
Posted by jpsullivan <gi...@git.apache.org>.
Github user jpsullivan commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/153#discussion_r37711040
--- Diff: src/Lucene.Net.TestFramework/Util/LuceneTestCase.cs ---
@@ -607,7 +607,7 @@ public virtual void TearDown()
/// </summary>
public static Random Random()
{
- return _random ?? (_random = new Random( /* LUCENENET TODO seed */));
+ return _random ?? (_random = new Random(1));
--- End diff --
Whoops! Missed that one. Will fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] lucenenet pull request: Complete port of Lucene.Net.Join
Posted by synhershko <gi...@git.apache.org>.
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/153#discussion_r37710985
--- Diff: src/Lucene.Net.TestFramework/Util/LuceneTestCase.cs ---
@@ -607,7 +607,7 @@ public virtual void TearDown()
/// </summary>
public static Random Random()
{
- return _random ?? (_random = new Random( /* LUCENENET TODO seed */));
+ return _random ?? (_random = new Random(1));
--- End diff --
remove the 1 seed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] lucenenet pull request: Complete port of Lucene.Net.Join
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/lucenenet/pull/153
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---