You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by derrickdoo <gi...@git.apache.org> on 2016/09/30 19:58:59 UTC
[GitHub] kafka-site pull request #20: new design
GitHub user derrickdoo opened a pull request:
https://github.com/apache/kafka-site/pull/20
new design
Updated theme
- new nav and layout
- updated homepage copy
- mobile styles
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/derrickdoo/kafka-site newTheme2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka-site/pull/20.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20
----
commit bfd64420c105fc2bb15f765458d8cac2a6ee6380
Author: Derrick Or <de...@gmail.com>
Date: 2016-09-30T04:52:13Z
new design
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] kafka-site pull request #20: new design
Posted by gwenshap <gi...@git.apache.org>.
Github user gwenshap commented on a diff in the pull request:
https://github.com/apache/kafka-site/pull/20#discussion_r81674610
--- Diff: 0100/protocol.html ---
@@ -16,208 +16,215 @@
-->
<!--#include virtual="../includes/header.html" -->
+<!--#include virtual="../includes/top.html" -->
+<div class="content">
+ <!--#include virtual="../includes/nav.html" -->
+ <div class="right">
--- End diff --
couldn't find where we are closing this either?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] kafka-site pull request #20: new design
Posted by derrickdoo <gi...@git.apache.org>.
Github user derrickdoo commented on a diff in the pull request:
https://github.com/apache/kafka-site/pull/20#discussion_r81684259
--- Diff: 0100/protocol.html ---
@@ -16,208 +16,215 @@
-->
<!--#include virtual="../includes/header.html" -->
+<!--#include virtual="../includes/top.html" -->
+<div class="content">
+ <!--#include virtual="../includes/nav.html" -->
+ <div class="right">
--- End diff --
Both of these get closed in /includes/footer.html. The old /includes/header.html used to leave these tags open and they'd get closed in footer.
I broke header.html up a little bit so we could have more flexibility with placing page specific stuff on top of .content.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] kafka-site pull request #20: new design
Posted by gwenshap <gi...@git.apache.org>.
Github user gwenshap commented on a diff in the pull request:
https://github.com/apache/kafka-site/pull/20#discussion_r81674590
--- Diff: 0100/protocol.html ---
@@ -16,208 +16,215 @@
-->
<!--#include virtual="../includes/header.html" -->
+<!--#include virtual="../includes/top.html" -->
+<div class="content">
--- End diff --
it doesn't look like we are closing this div tag anywhere?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] kafka-site pull request #20: new design
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/kafka-site/pull/20
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] kafka-site issue #20: new design
Posted by gwenshap <gi...@git.apache.org>.
Github user gwenshap commented on the issue:
https://github.com/apache/kafka-site/pull/20
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---