You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/06/06 19:13:14 UTC
Review Request 22310: Changed the terminal action semantics in routing
library to match that in tc toolset.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22310/
-----------------------------------------------------------
Review request for mesos, Ian Downes, Vinod Kone, and Cong Wang.
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
src/linux/routing/filter/action.hpp 8cc6594
src/linux/routing/filter/internal.hpp cd3279a
src/linux/routing/filter/ip.hpp 8f46ee5
src/linux/routing/filter/ip.cpp 86dbf35
Diff: https://reviews.apache.org/r/22310/diff/
Testing
-------
make check
sudo make check
Also, tested with the un-submitted network isolator.
Thanks,
Jie Yu
Re: Review Request 22310: Changed the terminal action semantics in routing
library to match that in tc toolset.
Posted by Jie Yu <yu...@gmail.com>.
> On June 6, 2014, 5:18 p.m., Ian Downes wrote:
> > src/linux/routing/filter/internal.hpp, line 306
> > <https://reviews.apache.org/r/22310/diff/1/?file=604770#file604770line306>
> >
> > Is it okay to drop this TODO?
Yes, we checked the source code in tc. The flowid is just a workaround for setting the 'terminal' flag.
> On June 6, 2014, 5:18 p.m., Ian Downes wrote:
> > src/linux/routing/filter/internal.hpp, line 223
> > <https://reviews.apache.org/r/22310/diff/1/?file=604770#file604770line223>
> >
> > So it's not considered an error to attempt to attach it to a non u32?
Good point. Returned error when attaching to a non u32.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22310/#review44930
-----------------------------------------------------------
On June 6, 2014, 5:13 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22310/
> -----------------------------------------------------------
>
> (Updated June 6, 2014, 5:13 p.m.)
>
>
> Review request for mesos, Ian Downes, Vinod Kone, and Cong Wang.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/linux/routing/filter/action.hpp 8cc6594
> src/linux/routing/filter/internal.hpp cd3279a
> src/linux/routing/filter/ip.hpp 8f46ee5
> src/linux/routing/filter/ip.cpp 86dbf35
>
> Diff: https://reviews.apache.org/r/22310/diff/
>
>
> Testing
> -------
>
> make check
> sudo make check
>
> Also, tested with the un-submitted network isolator.
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 22310: Changed the terminal action semantics in routing
library to match that in tc toolset.
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22310/#review44930
-----------------------------------------------------------
Ship it!
src/linux/routing/filter/internal.hpp
<https://reviews.apache.org/r/22310/#comment79520>
So it's not considered an error to attempt to attach it to a non u32?
src/linux/routing/filter/internal.hpp
<https://reviews.apache.org/r/22310/#comment79521>
Is it okay to drop this TODO?
- Ian Downes
On June 6, 2014, 10:13 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22310/
> -----------------------------------------------------------
>
> (Updated June 6, 2014, 10:13 a.m.)
>
>
> Review request for mesos, Ian Downes, Vinod Kone, and Cong Wang.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/linux/routing/filter/action.hpp 8cc6594
> src/linux/routing/filter/internal.hpp cd3279a
> src/linux/routing/filter/ip.hpp 8f46ee5
> src/linux/routing/filter/ip.cpp 86dbf35
>
> Diff: https://reviews.apache.org/r/22310/diff/
>
>
> Testing
> -------
>
> make check
> sudo make check
>
> Also, tested with the un-submitted network isolator.
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 22310: Changed the terminal action semantics in routing
library to match that in tc toolset.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22310/
-----------------------------------------------------------
(Updated June 6, 2014, 5:35 p.m.)
Review request for mesos, Ian Downes, Vinod Kone, and Cong Wang.
Changes
-------
Ian's comments.
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
src/linux/routing/filter/action.hpp 8cc6594
src/linux/routing/filter/internal.hpp cd3279a
src/linux/routing/filter/ip.hpp 8f46ee5
src/linux/routing/filter/ip.cpp 86dbf35
Diff: https://reviews.apache.org/r/22310/diff/
Testing
-------
make check
sudo make check
Also, tested with the un-submitted network isolator.
Thanks,
Jie Yu